[go: up one dir, main page]
Google Git
Sign in
chromium / angle / angle / refs/heads/chromium/3989
commit27c89d2b5c567dbe74cb854e77c45bd15bcdcde8[log] [tgz]
authorShahbaz Youssefi <syoussefi@chromium.org>Mon Nov 25 15:22:01 2019
committerCommit Bot <commit-bot@chromium.org>Sat Dec 07 05:32:04 2019
treeb9b3b50aecd36d9c3dddbbed6fd2cee482064470
parent36ab960e885da6e9b6660d5edc3ac7c51d026b03 [diff]
Vulkan: fix BufferVk::map() synchronization

4398b2b6a2ac13034dff249d8c049c4047b5fed2 made finishToSerial() in
BufferVk::map() conditional to whether the serial is in use to work
around a performance regression.  Notes:

- Prior to 087f1384f233792921d34c0ca5b5a90fac75b070, finishToSerial
  already did that, but that check was inadvertently removed.
- finishToSerial waits for the smallest serial that's bigger than or
  equal to the requested serial.
- The flush() call in BufferVk::map() was conditional to whether the
  serial is in use, but it really meant to check whether the buffer has
  pending commands in the graph.

The end result is that there was an unnecessary flush in BufferVk::map()
if we had to wait for a previous serial to finish.

This change makes the flush conditional to whether the buffer has
pending commands in the graph, and the finishToSerial call to whether
the serial is not yet finished.

Bug: angleproject:3994
Change-Id: Idca436ef2439bcc8c59396a07b2591c1dfadd669
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1932341
Reviewed-by: Brandon Schade <b.schade@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
2 files changed
tree: b9b3b50aecd36d9c3dddbbed6fd2cee482064470
  1. android/
  2. build_overrides/
  3. doc/
  4. extensions/
  5. gni/
  6. include/
  7. infra/
  8. samples/
  9. scripts/
  10. src/
  11. third_party/
  12. tools/
  13. util/
  14. .clang-format
  15. .gitattributes
  16. .gitignore
  17. .gn
  18. .style.yapf
  19. .yapfignore
  20. additional_readme_paths.json
  21. AUTHORS
  22. BUILD.gn
  23. codereview.settings
  24. CONTRIBUTORS
  25. DEPS
  26. dotfile_settings.gni
  27. LICENSE
  28. OWNERS
  29. PRESUBMIT.py
  30. README.chromium
  31. README.md
  32. WATCHLISTS
README.md

ANGLE - Almost Native Graphics Layer Engine

The goal of ANGLE is to allow users of multiple operating systems to seamlessly run WebGL and other OpenGL ES content by translating OpenGL ES API calls to one of the hardware-supported APIs available for that platform. ANGLE currently provides translation from OpenGL ES 2.0 and 3.0 to desktop OpenGL, OpenGL ES, Direct3D 9, and Direct3D 11. Support for translation from OpenGL ES to Vulkan is underway, and future plans include compute shader support (ES 3.1) and MacOS support.

Level of OpenGL ES support via backing renderers

Direct3D 9Direct3D 11Desktop GLGL ESVulkanMetal
OpenGL ES 2.0completecompletecompletecompletecompletein progress
OpenGL ES 3.0completecompletecompletein progress
OpenGL ES 3.1in progresscompletecompletein progress
OpenGL ES 3.2plannedplannedplanned

Platform support via backing renderers

Direct3D 9Direct3D 11Desktop GLGL ESVulkanMetal
Windowscompletecompletecompletecompletecomplete
Linuxcompletecomplete
Mac OS Xcompletein progress
iOSplanned
Chrome OScompleteplanned
Androidcompletecomplete
Fuchsiain progress

ANGLE v1.0.772 was certified compliant by passing the ES 2.0.3 conformance tests in October 2011. ANGLE also provides an implementation of the EGL 1.4 specification.

ANGLE is used as the default WebGL backend for both Google Chrome and Mozilla Firefox on Windows platforms. Chrome uses ANGLE for all graphics rendering on Windows, including the accelerated Canvas2D implementation and the Native Client sandbox environment.

Portions of the ANGLE shader compiler are used as a shader validator and translator by WebGL implementations across multiple platforms. It is used on Mac OS X, Linux, and in mobile variants of the browsers. Having one shader validator helps to ensure that a consistent set of GLSL ES shaders are accepted across browsers and platforms. The shader translator can be used to translate shaders to other shading languages, and to optionally apply shader modifications to work around bugs or quirks in the native graphics drivers. The translator targets Desktop GLSL, Direct3D HLSL, and even ESSL for native GLES2 platforms.

Sources

ANGLE repository is hosted by Chromium project and can be browsed online or cloned with

git clone https://chromium.googlesource.com/angle/angle

Building

View the Dev setup instructions.

Contributing