From 1f6c3c5bcd8eaa83c59aa448650d2640a75e3811 Mon Sep 17 00:00:00 2001 From: Juan Jose Casafranca Date: Thu, 5 Dec 2024 15:25:55 +0000 Subject: [PATCH 1/2] Fix add_collision_pait default arguments Signed-off-by: Juan Jose Casafranca --- bindings/Mandos/python/Model.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bindings/Mandos/python/Model.cpp b/bindings/Mandos/python/Model.cpp index 3373f7a3..df24087e 100644 --- a/bindings/Mandos/python/Model.cpp +++ b/bindings/Mandos/python/Model.cpp @@ -173,7 +173,7 @@ void mandos::py::wrapModel(::py::module_ &m) }, ::py::arg(), ::py::arg(), - ::py::arg("name"), + ::py::arg("name") = std::optional{}, ::py::arg("stiffness") = mandos::core::Scalar(0)) ///////////////// Visitors ////////////////////// -- GitLab From 88e1c95618d35a97b49c54137651a1eb64ec3104 Mon Sep 17 00:00:00 2001 From: Juan Jose Casafranca Date: Thu, 5 Dec 2024 15:31:31 +0000 Subject: [PATCH 2/2] Disable line_search for some demos Signed-off-by: Juan Jose Casafranca --- examples/python/RigidBody/local_vs_global.py | 2 +- examples/python/RigidBody/rigidbody.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/python/RigidBody/local_vs_global.py b/examples/python/RigidBody/local_vs_global.py index 7784c420..6a36b93a 100644 --- a/examples/python/RigidBody/local_vs_global.py +++ b/examples/python/RigidBody/local_vs_global.py @@ -60,7 +60,7 @@ def simulate_callback(model, rigid_body_local, rigid_body_global): stepParameters.newton_iterations = 5 stepParameters.cg_error = 1e-7 stepParameters.grad_norm = 1e-1 - stepParameters.enable_line_search = False + stepParameters.line_search_iterations = 0 pymandos.step(model, stepParameters) ps.get_surface_mesh("rb_local_mesh").set_transform(rigid_body_local.get_transform()) diff --git a/examples/python/RigidBody/rigidbody.py b/examples/python/RigidBody/rigidbody.py index 5180257b..860010ca 100644 --- a/examples/python/RigidBody/rigidbody.py +++ b/examples/python/RigidBody/rigidbody.py @@ -40,7 +40,7 @@ def simulate_callback(model, rigid_body): stepParameters.cg_iterations = 20 stepParameters.cg_error = 1e-4 stepParameters.grad_norm = 1e-3 - stepParameters.enable_line_search = False + stepParameters.line_search_iterations = 0 pymandos.step(model, stepParameters) ps.get_surface_mesh("rb_mesh").set_transform(rigid_body.get_transform()) -- GitLab