[go: up one dir, main page]

Skip to content

edit_url contains invalid URL characters from the branch name. Eg "#".

Situation: There is a branch name docs-fix-iss#138 that is built and published to gh-pages and the edit_url for content on this branch gives a 404.

Cause: The hash '#' in the branch name is not a valid character in a URL. GitHub shows the same URL with %23 replacing the #.

Solution: The edit_url after being calculated has any special characters transformed, eg # becomes %23.

This is not an urgent problem as the workaround is to not use # in branch names.

How would you like me to help address this?

Maybe it needs fixing only in one place however I'm unsure of any other dependencies. My guess as to where is here:

https://gitlab.com/antora/antora/-/blob/main/packages/content-aggregator/lib/compute-origin.js#L50

Edited by Sturt Ison
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information