From ee314f908f6dd07c96f4d420f4332608fb14d3ca Mon Sep 17 00:00:00 2001 From: karup Date: Wed, 8 Oct 2025 16:22:22 -0700 Subject: [PATCH 1/5] Fixed error when getting banned list to show in UI if bad was done from server management ui Traceback (most recent call last): File "/crafty/.venv/lib/python3.12/site-packages/tornado/web.py", line 1848, in _execute result = await result ^^^^^^^^^^^^ File "/crafty/app/classes/web/panel_handler.py", line 733, in get page_data["banned_players_html"] = get_banned_players_html() ^^^^^^^^^^^^^^^^^^^^^^^^^ File "/crafty/app/classes/web/panel_handler.py", line 718, in get_banned_players_html

{player['name']}

~~~~~~^^^^^^^^ KeyError: 'name' --- app/classes/web/panel_handler.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/classes/web/panel_handler.py b/app/classes/web/panel_handler.py index 429fc626..ea4eb117 100644 --- a/app/classes/web/panel_handler.py +++ b/app/classes/web/panel_handler.py @@ -716,7 +716,7 @@ class PanelHandler(BaseHandler): html += f"""

  • {player['name']}

    - Banned by {player['source']} for reason: {player['reason']} + Banned by {player['source']} for reason: {player.get('reason', 'None')}
    • """ -- GitLab From 68432bab58469171fc22bcae656d8cbd34cc8b93 Mon Sep 17 00:00:00 2001 From: karup Date: Wed, 8 Oct 2025 20:41:27 -0700 Subject: [PATCH 2/5] Fixed template --- app/frontend/templates/panel/parts/server_players.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/frontend/templates/panel/parts/server_players.html b/app/frontend/templates/panel/parts/server_players.html index 3cd8ce12..7a72f981 100644 --- a/app/frontend/templates/panel/parts/server_players.html +++ b/app/frontend/templates/panel/parts/server_players.html @@ -55,7 +55,7 @@ {{ player['name'] }} Banned on {{ player['banned_on'] }} - Banned by : {{ player['source'] }}
    Reason : {{ player['reason'] }} + Banned by : {{ player['source'] }}
    Reason : {{ player.get('reason', 'None') }} -- GitLab From 78c3a54bc39af144a1c47b4be0c4e0ef4487d672 Mon Sep 17 00:00:00 2001 From: karup Date: Wed, 8 Oct 2025 16:22:22 -0700 Subject: [PATCH 3/5] Fixed error when getting banned list to show in UI if bad was done from server management ui Traceback (most recent call last): File "/crafty/.venv/lib/python3.12/site-packages/tornado/web.py", line 1848, in _execute result = await result ^^^^^^^^^^^^ File "/crafty/app/classes/web/panel_handler.py", line 733, in get page_data["banned_players_html"] = get_banned_players_html() ^^^^^^^^^^^^^^^^^^^^^^^^^ File "/crafty/app/classes/web/panel_handler.py", line 718, in get_banned_players_html

    {player['name']}

    ~~~~~~^^^^^^^^ KeyError: 'name' --- app/classes/web/panel_handler.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/classes/web/panel_handler.py b/app/classes/web/panel_handler.py index 429fc626..ea4eb117 100644 --- a/app/classes/web/panel_handler.py +++ b/app/classes/web/panel_handler.py @@ -716,7 +716,7 @@ class PanelHandler(BaseHandler): html += f"""

  • {player['name']}

    - Banned by {player['source']} for reason: {player['reason']} + Banned by {player['source']} for reason: {player.get('reason', 'None')}
    • """ -- GitLab From 0495742a7fc637d6dfc80fd79d409f4b130c99bb Mon Sep 17 00:00:00 2001 From: karup Date: Wed, 8 Oct 2025 20:41:27 -0700 Subject: [PATCH 4/5] Fixed template --- app/frontend/templates/panel/parts/server_players.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/frontend/templates/panel/parts/server_players.html b/app/frontend/templates/panel/parts/server_players.html index 3cd8ce12..7a72f981 100644 --- a/app/frontend/templates/panel/parts/server_players.html +++ b/app/frontend/templates/panel/parts/server_players.html @@ -55,7 +55,7 @@ {{ player['name'] }} Banned on {{ player['banned_on'] }} - Banned by : {{ player['source'] }}
    Reason : {{ player['reason'] }} + Banned by : {{ player['source'] }}
    Reason : {{ player.get('reason', 'None') }} -- GitLab From 0b165c78052493b82e137c18d57462bceb487e0d Mon Sep 17 00:00:00 2001 From: karup Date: Sat, 11 Oct 2025 23:52:59 -0700 Subject: [PATCH 5/5] Set a default value of empty string if not set. Can not be None as None may be a valid value --- app/classes/web/panel_handler.py | 2 +- app/frontend/templates/panel/parts/server_players.html | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/classes/web/panel_handler.py b/app/classes/web/panel_handler.py index ea4eb117..91a451e9 100644 --- a/app/classes/web/panel_handler.py +++ b/app/classes/web/panel_handler.py @@ -716,7 +716,7 @@ class PanelHandler(BaseHandler): html += f"""

  • {player['name']}

    - Banned by {player['source']} for reason: {player.get('reason', 'None')} + Banned by {player.get('source', '')} for reason: {player.get('reason', 'None')}
    • """ diff --git a/app/frontend/templates/panel/parts/server_players.html b/app/frontend/templates/panel/parts/server_players.html index 7a72f981..039e7e82 100644 --- a/app/frontend/templates/panel/parts/server_players.html +++ b/app/frontend/templates/panel/parts/server_players.html @@ -55,7 +55,7 @@ {{ player['name'] }} Banned on {{ player['banned_on'] }} - Banned by : {{ player['source'] }}
    Reason : {{ player.get('reason', 'None') }} + Banned by : {{ player.get('source', '') }}
    Reason : {{ player.get('reason', 'None') }} -- GitLab