From cee0c6bd8433ec2d8fd2e2939f337785d270f608 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Mon, 8 Apr 2024 12:59:23 +0530 Subject: [PATCH] fix: type error in workflow (#25847) if state is null, we can't get roles for it. --- frappe/public/js/frappe/model/workflow.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/frappe/public/js/frappe/model/workflow.js b/frappe/public/js/frappe/model/workflow.js index 2587a93ed1..d7a37b0f82 100644 --- a/frappe/public/js/frappe/model/workflow.js +++ b/frappe/public/js/frappe/model/workflow.js @@ -59,11 +59,9 @@ frappe.workflow = { var state = doc[state_fieldname] || frappe.workflow.get_default_state(doctype, doc.docstatus); + if (!state) return false; - let allow_edit_roles = state - ? frappe.workflow.get_document_state_roles(doctype, state) - : null; - + let allow_edit_roles = frappe.workflow.get_document_state_roles(doctype, state); let has_common_role = frappe.user_roles.some((role) => allow_edit_roles.includes(role) ); -- GitLab