From 6bf69963c6fbfe30c1e60f965d870aaa576b3ca1 Mon Sep 17 00:00:00 2001 From: Charles-Henri Decultot Date: Mon, 5 Feb 2024 13:11:36 +0100 Subject: [PATCH] fix: Allow multiple rows for the same item but different uoms --- .../doctype/booking_credit_type/booking_credit_type.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/erpnext/venue/doctype/booking_credit_type/booking_credit_type.py b/erpnext/venue/doctype/booking_credit_type/booking_credit_type.py index 62840ce87d1..65ad370660f 100644 --- a/erpnext/venue/doctype/booking_credit_type/booking_credit_type.py +++ b/erpnext/venue/doctype/booking_credit_type/booking_credit_type.py @@ -1,9 +1,9 @@ # Copyright (c) 2023, Dokos SAS and contributors # For license information, please see license.txt -import frappe from frappe.model.document import Document + class BookingCreditType(Document): def validate(self): self.validate_conversions() @@ -11,7 +11,7 @@ class BookingCreditType(Document): def validate_conversions(self): convertible_items = [] for conversion in self.conversion_table: - if conversion.item in convertible_items: + if (conversion.item, conversion.uom) in convertible_items: self.remove(conversion) continue - convertible_items.append(conversion.item) + convertible_items.append((conversion.item, conversion.uom)) -- GitLab