From 3afc07ffa5a65e2e381b32856c9f83264bf9f7dc Mon Sep 17 00:00:00 2001 From: ruthra kumar Date: Wed, 10 Apr 2024 13:21:24 +0530 Subject: [PATCH] fix: ignore dimension validation for cancelled entries --- erpnext/accounts/doctype/gl_entry/gl_entry.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/erpnext/accounts/doctype/gl_entry/gl_entry.py b/erpnext/accounts/doctype/gl_entry/gl_entry.py index 9e6beeec752..def26d96886 100644 --- a/erpnext/accounts/doctype/gl_entry/gl_entry.py +++ b/erpnext/accounts/doctype/gl_entry/gl_entry.py @@ -183,6 +183,7 @@ class GLEntry(Document): and self.company == dimension.company and dimension.mandatory_for_pl and not dimension.disabled + and not self.is_cancelled ): if not self.get(dimension.fieldname): frappe.throw( @@ -196,6 +197,7 @@ class GLEntry(Document): and self.company == dimension.company and dimension.mandatory_for_bs and not dimension.disabled + and not self.is_cancelled ): if not self.get(dimension.fieldname): frappe.throw( -- GitLab