From 258c6289ef4f67346e6fda21efd792f7cb1e6d09 Mon Sep 17 00:00:00 2001 From: Corentin Forler Date: Wed, 2 Apr 2025 17:10:31 +0200 Subject: [PATCH] fix(catalog): Remove first row if empty when closing catalog --- .../item_catalog/erpnext_item_catalog.bundle.js | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/erpnext/public/js/utils/item_catalog/erpnext_item_catalog.bundle.js b/erpnext/public/js/utils/item_catalog/erpnext_item_catalog.bundle.js index 2b5301712c8..0dd9212020d 100644 --- a/erpnext/public/js/utils/item_catalog/erpnext_item_catalog.bundle.js +++ b/erpnext/public/js/utils/item_catalog/erpnext_item_catalog.bundle.js @@ -35,10 +35,22 @@ erpnext.ItemCatalogRender = class ItemCatalogRender { this.dialog.show(); } + onHide() { + // Remove first item row if empty + const table = this.frm.get_field("items"); + if (table) { + const row = this.frm.doc.items[0]; + if (row && !row.item_code && !row.item_name && !row.qty && !row.rate) { + table.grid.grid_rows[0].remove(); + } + } + } + make_dialog() { this.dialog = new frappe.ui.Dialog({ size: "extra-large", fields: [{ fieldtype: "HTML", fieldname: "catalog" }], + on_hide: this.onHide.bind(this), }); const wrapper = this.dialog.body; // const wrapper = $(dialog.fields_dict.catalog.$wrapper).get(0); -- GitLab