From f2566fba66b1e3fa926d49dcdb494f0f9c128338 Mon Sep 17 00:00:00 2001 From: Charles-Henri Decultot Date: Tue, 8 Apr 2025 08:28:47 +0200 Subject: [PATCH] refactor: Update Bank Transaction set_query implemetation --- .../doctype/bank_transaction/bank_transaction.js | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/erpnext/accounts/doctype/bank_transaction/bank_transaction.js b/erpnext/accounts/doctype/bank_transaction/bank_transaction.js index bb9bfde3082..f3aea473a11 100644 --- a/erpnext/accounts/doctype/bank_transaction/bank_transaction.js +++ b/erpnext/accounts/doctype/bank_transaction/bank_transaction.js @@ -2,7 +2,7 @@ // For license information, please see license.txt frappe.ui.form.on("Bank Transaction", { - onload(frm) { + setup(frm) { frm.set_query("payment_document", "payment_entries", function () { const payment_doctypes = frm.events.get_payment_doctypes(frm); return { @@ -17,6 +17,7 @@ frappe.ui.form.on("Bank Transaction", { const filters = { filters: { unreconciled_amount: [">", 0], + docstatus: ["!=", 2], }, }; @@ -35,7 +36,15 @@ frappe.ui.form.on("Bank Transaction", { frm.set_query("party_type", function () { return { - query: "erpnext.setup.doctype.party_type.party_type.get_party_type", + filters: { + name: ["in", Object.keys(frappe.boot.party_account_types)], + }, + }; + }); + + frm.set_query("bank_account", function () { + return { + filters: { is_company_account: 1 }, }; }); }, -- GitLab