From 0dd30d389e759bf118be4667bfdfe9d1a1f6f25f Mon Sep 17 00:00:00 2001
From: Alain Mebsout <alain.mebsout@functori.com>
Date: Tue, 27 May 2025 10:52:59 +0200
Subject: [PATCH] OpenAPI: fix examples

---
 server/lib/directory.ml | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/server/lib/directory.ml b/server/lib/directory.ml
index 9ef4ace..a8c9a01 100644
--- a/server/lib/directory.ml
+++ b/server/lib/directory.ml
@@ -118,8 +118,7 @@ module Encoding = struct
     Rollup_node_client.Notarized { timestamp }
 
   let hash_example =
-    Hex.to_string
-      (`Hex "01ba4719c80b6fe911b091a7c05124b64eeece964e09c058ef8f9805daca546b")
+    "01ba4719c80b6fe911b091a7c05124b64eeece964e09c058ef8f9805daca546b"
 
   let tz1_example =
     Tz1.of_base58 (Base58 "tz1Z9FUrB2KaxBX87Tn5EhkWcjsPWwMhysy2") |> Option.get
@@ -220,13 +219,16 @@ module External_message = struct
       ~descr:
         "Helper to build an external message to send to the rollup in order to \
          notarize a hash"
-      ~input:Encoding.hex_string ~input_example:Encoding.hash_example
-      ~output:Encoding.hex_string
+      ~errors:[err_400] ~input:Encoding.hash
+      ~input_example:Encoding.hash_example ~output:Encoding.hex_string
       ~output_example:
-        "00dcb2f68b87baec5a45f5b2d242b9c08ee612e68c001abb38b7419dbc11a6ca6020a8511b11d819984b83e727ac53cbd0373a8c0c7f3030303030303030303030303030303030303030303030303030303030303030f0d3d2e6fb26ab6a04c867cf52d085371e160960919847eff823c6d6fc44223701ea61aec3d83b9f182bea24e74d9bf6553948750d3a156068f7bc568cebf40f"
+        (Hex.to_string
+           (`Hex
+             "00dcb2f68b87baec5a45f5b2d242b9c08ee612e68c001abb38b7419dbc11a6ca6020a8511b11d819984b83e727ac53cbd0373a8c0c7f3030303030303030303030303030303030303030303030303030303030303030f0d3d2e6fb26ab6a04c867cf52d085371e160960919847eff823c6d6fc44223701ea61aec3d83b9f182bea24e74d9bf6553948750d3a156068f7bc568cebf40f"))
       Path.(root // "external_message")
 
   let handler state _params _ hash =
+    let*? hash = Encoding.parse_hex hash in
     Rollup_node_client.make_external_message state hash |> Lwt_result.return
 
   let () = register service handler
@@ -279,7 +281,6 @@ module Openapi = struct
       Path.(root // "openapi")
 
   let handler _state _params _ () =
-    (* TODO: Missing info for some reason. *)
     let _, r =
       EzOpenAPI.make ~descr:"API documentation for Pandora"
         ~contact:
-- 
GitLab