[go: up one dir, main page]

Skip to content

Please review whether registry notifier is needed, and remove if not

Summary

The GitLab Registry chart configuration is set up to send a notification to the primary API url. I've been made aware of a discussion where it was pointed out that this isn't needed, and may not actually be desired at all.

Steps to reproduce

(Please provide the steps to reproduce the issue)

Configuration used

Default template code: https://gitlab.com/gitlab-org/charts/gitlab/-/blob/3a509377bdf8be0dccf3fc91286d37cfa51fd7dd/templates/_registry.tpl#L57-73

geo:
  enabled: true
  nodeName: REDACTED
  psql:
    host: REDACTED
    password:
      key: password
      secret: REDACTED
    port: "5432"
  registry:
    replication:
      enabled: true
      primaryApiUrl: https://gitlab.example.com
  role: secondary

Current behavior

A Registry in a secondary site is sending notifications to the primary site, and getting 401s.

Expected behavior

A Registry in a secondary site should not send notifications.

(Note that a Registry in a primary site should send notifications to the primary site.)

Versions

  • Chart: (tagged version | branch | hash git rev-parse HEAD)
  • Platform:
    • Cloud: (GKE | AKS | EKS | ?)
    • Self-hosted: (OpenShift | Minikube | Rancher RKE | ?)
  • Kubernetes: (kubectl version)
    • Client:
    • Server:
  • Helm: (helm version)
    • Client:
    • Server:

Relevant logs

2025-01-13T21:21:42.516474456Z {"level":"error","msg":"retryingsink: error writing events: httpSink{https://gitlab.example.com/api/v4/container_registry_event/events}: response status 401 Unauthorized unaccepted, retrying","time":"2025-01-13T21:21:42.516Z"}
2025-01-13T21:21:42.516493545Z {"level":"warning","msg":"httpSink{https://gitlab.example.com/api/v4/container_registry_event/events} encountered too many errors, backing off","time":"2025-01-13T21:21:42.516Z"}

(Please provide any relevate log snippets you have collected, using code blocks (```) to format)

Edited by Michael Kozono