[go: up one dir, main page]

Skip to content

Minio PVC does not allow a custom annotations

Summary

https://gitlab.com/gitlab-org/charts/gitlab/-/blob/master/charts/minio/templates/minio_pvc.yaml

# code snipped from gitlabs minio chart
metadata:
  name: {{ template "minio.fullname" . }}
  namespace: {{ $.Release.Namespace }}
  labels:
{{- include "gitlab.standardLabels" . | nindent 4 }}
{{- include "gitlab.commonLabels" . | nindent 4 }}
spec:

Its not possible to assign a SPECIFIC ANNOTATION to MINIO PVC. The helm chart is simply missing any code for this.

Expected behavior

I would expect minio to contains a posibility to add a annotation like

    minio:
      persistence:
        annotations:
          "helm.sh/resource-policy": keep

in order to keep my persistence even when i delete my helm chart.

# expected code snipped
metadata:
  name: {{ template "minio.fullname" . }}
  namespace: {{ $.Release.Namespace }}
  labels:
{{- include "gitlab.standardLabels" . | nindent 4 }}
{{- include "gitlab.commonLabels" . | nindent 4 }}
  annotations:
{{- include "minio.persistence.annotations" . | nindent 4 }}
spec:

Versions

current master

Edited by Marcel