[go: up one dir, main page]

Skip to content

ci: add danger-review job

Problem to solve

We currently don't have a danger-review job running in the project. This means there are a few checks we miss, but most importantly, we don't have a way to suggest reviewers for MRs.

Proposal

Adding a danger-review job is fairly simple thanks to the template that exists in the https://gitlab.com/gitlab-org/quality/pipeline-common project. There are a few rules that run, like applying correct labels as well as finding reviewers from the handbook's data files.

Further details

We added the job in Add dangerbot to enable reviewer roulette (gitlab-pages!729 - merged) to GitLab Pages and the Container Registry project and the results have been pretty good.

Links / references

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information