From ff20e0d906670081d24157d49163a241afd58644 Mon Sep 17 00:00:00 2001 From: Jaime Martinez Date: Thu, 17 Nov 2022 11:02:56 +1100 Subject: [PATCH 1/5] ci: add danger-review job --- .gitlab-ci.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 1a0f66321..4052460ff 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -20,6 +20,12 @@ include: - template: Security/SAST.gitlab-ci.yml - template: Security/Dependency-Scanning.gitlab-ci.yml - template: Security/Secret-Detection.gitlab-ci.yml + - project: 'gitlab-org/quality/pipeline-common' + file: + - '/ci/danger-review.yml' + rules: + - if: '$CI_SERVER_HOST == "gitlab.com"' + # From: https://docs.gitlab.com/ee/ci/caching/#cache-go-dependencies -- GitLab From d74c897475aa734b50f986f15e5c2fa218ba0a4d Mon Sep 17 00:00:00 2001 From: Jaime Martinez Date: Thu, 17 Nov 2022 11:07:09 +1100 Subject: [PATCH 2/5] chore: add missing danger file --- Dangerfile | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 Dangerfile diff --git a/Dangerfile b/Dangerfile new file mode 100644 index 000000000..bf29e04dc --- /dev/null +++ b/Dangerfile @@ -0,0 +1,6 @@ +require "gitlab-dangerfiles" + +Gitlab::Dangerfiles.for_project(self) do |dangerfiles| + dangerfiles.import_plugins + dangerfiles.import_dangerfiles +end -- GitLab From 415daf32b4f6efa88643a50a12fb7b15a30a9e78 Mon Sep 17 00:00:00 2001 From: Jaime Martinez Date: Thu, 17 Nov 2022 11:12:32 +1100 Subject: [PATCH 3/5] chore: remove commit message rules --- Dangerfile | 2 +- Gemfile | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) create mode 100644 Gemfile diff --git a/Dangerfile b/Dangerfile index bf29e04dc..845f7974f 100644 --- a/Dangerfile +++ b/Dangerfile @@ -2,5 +2,5 @@ require "gitlab-dangerfiles" Gitlab::Dangerfiles.for_project(self) do |dangerfiles| dangerfiles.import_plugins - dangerfiles.import_dangerfiles + dangerfiles.import_dangerfiles(except: %w[commit_messages]) end diff --git a/Gemfile b/Gemfile new file mode 100644 index 000000000..3455604b5 --- /dev/null +++ b/Gemfile @@ -0,0 +1,7 @@ +# frozen_string_literal: true + +source 'https://rubygems.org' + +group :development, :test, :danger do + gem 'gitlab-dangerfiles', '~> 3.0', require: false +end \ No newline at end of file -- GitLab From b87679d2be84d09e76b33bbe423bffa2202014eb Mon Sep 17 00:00:00 2001 From: Jaime Martinez Date: Thu, 17 Nov 2022 11:13:00 +1100 Subject: [PATCH 4/5] chore: remove Gemfile --- Gemfile | 7 ------- 1 file changed, 7 deletions(-) delete mode 100644 Gemfile diff --git a/Gemfile b/Gemfile deleted file mode 100644 index 3455604b5..000000000 --- a/Gemfile +++ /dev/null @@ -1,7 +0,0 @@ -# frozen_string_literal: true - -source 'https://rubygems.org' - -group :development, :test, :danger do - gem 'gitlab-dangerfiles', '~> 3.0', require: false -end \ No newline at end of file -- GitLab From 249472d4a6b6fbac729c18206165cbfd7442044b Mon Sep 17 00:00:00 2001 From: Jaime Martinez Date: Thu, 17 Nov 2022 11:19:12 +1100 Subject: [PATCH 5/5] chore: remove changelog rule --- Dangerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Dangerfile b/Dangerfile index 845f7974f..9ad455b0a 100644 --- a/Dangerfile +++ b/Dangerfile @@ -2,5 +2,5 @@ require "gitlab-dangerfiles" Gitlab::Dangerfiles.for_project(self) do |dangerfiles| dangerfiles.import_plugins - dangerfiles.import_dangerfiles(except: %w[commit_messages]) + dangerfiles.import_dangerfiles(except: %w[commit_messages changelog]) end -- GitLab