[go: up one dir, main page]

Skip to content

Incorrect values for gitaly_catfile_processes metric

It looks like the gitaly_catfile_processes metric only reports negative values, and continuously grows rather than reporting the number of active processes.

Screenshot_2025-02-27_at_12.16.34

Is it because the cancel function may be called multiple times? Should this function use https://pkg.go.dev/sync#OnceFunc to prevent this?

https://gitlab.com/gitlab-org/gitaly/-/blob/f16c7c18016d6ffa5ef1cf5eedbf1c01f464ddad/internal/git/catfile/cache.go#L321

Edited by Thomas Way
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information