From 110e1e8bcb98d872ac09c4a24192c151edef003d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kim=20=22BKC=22=20Carlb=C3=A4cker?= Date: Fri, 21 Apr 2017 11:01:35 +0200 Subject: [PATCH 1/2] Shorten Error-messages --- internal/helper/command.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/helper/command.go b/internal/helper/command.go index 46cf1543e8d..370fa4c5087 100644 --- a/internal/helper/command.go +++ b/internal/helper/command.go @@ -60,7 +60,7 @@ func NewCommand(cmd *exec.Cmd, stdin io.Reader, stdout io.Writer, env ...string) cmd.Stderr = os.Stderr if err := cmd.Start(); err != nil { - return nil, fmt.Errorf("GitCommand: start %v: %v", cmd.Args, err) + return nil, fmt.Errorf("start %v: %v", cmd.Args, err) } return command, nil -- GitLab From b6ea68afb87c346437413af491a93e9e6ada51fb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kim=20=22BKC=22=20Carlb=C3=A4cker?= Date: Thu, 4 May 2017 15:35:10 +0200 Subject: [PATCH 2/2] lower-case err-msg --- internal/service/commit/isancestor.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/service/commit/isancestor.go b/internal/service/commit/isancestor.go index 3afa86fa33c..99973794105 100644 --- a/internal/service/commit/isancestor.go +++ b/internal/service/commit/isancestor.go @@ -20,12 +20,12 @@ func (s *server) CommitIsAncestor(ctx context.Context, in *pb.CommitIsAncestorRe return nil, err } if in.AncestorId == "" { - message := "Bad Request (empty ancestor sha)" + message := "bad request (empty ancestor sha)" log.Printf("CommitIsAncestor: %q", message) return nil, grpc.Errorf(codes.InvalidArgument, message) } if in.ChildId == "" { - message := "Bad Request (empty child sha)" + message := "bad request (empty child sha)" log.Printf("CommitIsAncestor: %q", message) return nil, grpc.Errorf(codes.InvalidArgument, message) } -- GitLab