From 9d3c591e5d0069f73cc44631a33966aeade1874a Mon Sep 17 00:00:00 2001 From: Paul Okstad Date: Tue, 5 Jan 2021 21:21:12 -0800 Subject: [PATCH 1/3] Avoid using dependency grpc-go v1.35.0 There is an issue with UNIX domain socket dialing with grpc-go version 1.35.0. This change includes a Go module directive to exclude the affected versions until a newer fixed version can be used. More details can be found at the bug issue: https://github.com/grpc/grpc-go/issues/3990 --- go.mod | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/go.mod b/go.mod index 49dc4e3e4cb..4cd2092da59 100644 --- a/go.mod +++ b/go.mod @@ -1,5 +1,14 @@ module gitlab.com/gitlab-org/gitaly +exclude ( + // grpc-go version v1.35.0 has a bug that affects unix domain docket + // dialing. It should be avoided until upgraded to a newer fixed + // version. More details: + // https://github.com/grpc/grpc-go/issues/3990 + github.com/grpc/grpc-go v1.35.0 + github.com/grpc/grpc-go v1.35.0-dev +) + require ( github.com/beorn7/perks v1.0.1 // indirect github.com/cloudflare/tableflip v1.2.1-0.20200514155827-4baec9811f2b -- GitLab From 578a5fbffd011d1918eec85a83e84963d5083ef1 Mon Sep 17 00:00:00 2001 From: Paul Okstad Date: Wed, 6 Jan 2021 22:16:27 +0000 Subject: [PATCH 2/3] Apply 1 suggestion(s) to 1 file(s) --- go.mod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 4cd2092da59..19d20362352 100644 --- a/go.mod +++ b/go.mod @@ -5,7 +5,7 @@ exclude ( // dialing. It should be avoided until upgraded to a newer fixed // version. More details: // https://github.com/grpc/grpc-go/issues/3990 - github.com/grpc/grpc-go v1.35.0 + github.com/grpc/grpc-go v1.34.0 github.com/grpc/grpc-go v1.35.0-dev ) -- GitLab From 2bc631e2ce7cdabd34ab797bd18feafec41c5b12 Mon Sep 17 00:00:00 2001 From: Paul Okstad Date: Wed, 6 Jan 2021 22:20:04 +0000 Subject: [PATCH 3/3] Apply 1 suggestion(s) to 1 file(s) --- go.mod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 19d20362352..31c22be1aa3 100644 --- a/go.mod +++ b/go.mod @@ -1,7 +1,7 @@ module gitlab.com/gitlab-org/gitaly exclude ( - // grpc-go version v1.35.0 has a bug that affects unix domain docket + // grpc-go version v1.34.0 and v1.35.0-dev have a bug that affects unix domain docket // dialing. It should be avoided until upgraded to a newer fixed // version. More details: // https://github.com/grpc/grpc-go/issues/3990 -- GitLab