Repo mirroring stoped

ZD: https://gitlab.zendesk.com/agent/tickets/21953

Description

I set up the mirrors using this notation: https://user:password@github1.dm.com/ORG/REPO.git It seems that GitLab drops "user:password" from the URLs. I added it back to one of the repositories: it does one successful mirroring action and then falls back to the same problem.

Two questions:

1. Why does GitLab drop the login credentials?
2. Why isn't there a visible warning? I needed to go into the commit list before I saw an indication of trouble.

Error

fatal: could not read Username for 'https://github1.dm.com': No such device or address 
947932

Some refactoring went wrong: commits a1a1d1f7 and 030b1394. The code is in app/models/project.rb, line 467

super(import_url.sanitized_url) 
# should be: 
super(import_url.full_url)

Proposed Solution

File /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/import_url.rb 
def safe_url 
safe_url = @url.dup 
##REMOVED## safe_url.password = nil 
##REMOVED## safe_url.user = nil 
safe_url 
end

---

/cc @jameslopez