[go: up one dir, main page]

Skip to content

GlTokenSelector: add `data-qa-selector` props

Follow-up to gitlab!36240 (comment 378455487)

In QA E2E tests we are currently interacting with the component via CSS classes. This is less than ideal because the tests will break if the CSS classes change. We can add props to be able to interact with this component via data-qa-selector.

Component Prop Element to apply data-qa-selector attribute to
GlTokenSelector data-qa-text-input-selector <input type="text" ... />
GlTokenSelector data-qa-close-token-selector <gl-token />
GlToken data-qa-close-token-selector <gl-icon />

Update https://gitlab.com/gitlab-org/gitlab/-/blob/e044f3946a8773cdeeb4bc8b283ef12b906bfc52/qa/qa/ee/page/group/settings/general.rb#L69 once this is completed

Edited by Peter Hegman