[go: up one dir, main page]

Skip to content

Show Whitespace Changes in Diffs dropdown menu is bold

Problem

Show whitespace changes in the dropdown menu is bold. Show one file at a time is not bold.

Cause

Show whitespace changes uses an input and a label element. All labels are assigned a heavier font-weight.
Show one file at a time uses GlFormCheckbox, which does not have the heavier weight for its label.

Proposed solution

The Show whitespace changes checkbox should be updated to a GlFormCheckbox.

Known complexity

The way this dropdown is tested causes some issues with testing. Switching to the encapsulated GlFormCheckbox component and triggering a click there circumvents the stubbed Vuex actions in the tests and triggers the real action, leading to lots of code running that shouldn't. Updating this may require rewriting the mocks/stubs for this component.

Edited by Thomas Randolph