[go: up one dir, main page]

Skip to content

Move submodule header link in diffs

Summary

Clicking the submodule name is not consistent with other kinds of files. It navigates to the submodule repository, and in other kinds of files it changes the current URL to a permalink of the file in the context of that commit/merge request.

Steps to reproduce

  1. Add/change/remove a Git submodule from a repository
  2. View the file list in a commit or merge request

Example Project

What is the current bug behavior?

Clicking the submodule name is not consistent with other kinds of files. It navigates to the submodule repository, and in other kinds of files it changes the current URL to a permalink of the file in the context of that commit/merge request.

What is the expected correct behavior?

  • Change the current URL to a permalink of the submodule change in the context of the commit/merge request.
  • Additionally, consider converting the existing submodule links (to its repository and revision) to buttons at the top right of the file header.

Output of checks

This bug happens on GitLab.com