[go: up one dir, main page]

Skip to content

Number of MR approvals is wrong

Summary

In the list of MRs, the number of approvals is wrong.

Steps to reproduce

Create an MR requiring approvals from 2 groups of people - Ensure it requires 1 approval in each group (2 total). Approve the MR from group one and return to the list.

Example Project

Not got one yet, let me know if you need one set up.

What is the current bug behavior?

The number displays incorrectly as 1 of 1, which I initially read as the MR was fully approved when its not.

What is the expected correct behavior?

The number should display as 1 of 2 since we're still waiting on another approval.

Relevant logs and/or screenshots

image

Output of checks

This bug happens on GitLab.com

Results of GitLab environment info

N/A - Gitlab.com

Results of GitLab application Check

N/A - Gitlab.com

Possible fixes

No idea to be honest. The text does go green at the right time and adds a check icon, so the logic for that is correct - maybe copy that logic for the count?