[go: up one dir, main page]
Skip to content

[Pages] Ruby 3.3/3.4 Gem Compatibility Review

Team Information

  • Category: Pages
  • Engineering Manager: Vladimir Shushlin
  • Stage: Plan
  • Gem Count: 3
  • Gems: acme-client, rubyzip, validates_hostname
  • Manager Sign-off: Pending

Related Issue

This is part of the Ruby 3.3/3.4 compatibility project: Issue #517985

Action Required

Please review the Ruby gems listed above and confirm:

  1. These gems are relevant to your team's work
  2. Your team should maintain ownership of these gems
  3. There are no missing gems that should be listed

Review Process for Ruby 3.3/3.4 Compatibility

As an Engineering Manager, please help identify engineers who can audit these gems for Ruby 3.3/3.4 compatibility. The review should include:

  1. Initial Assessment (by Engineering Manager):

    • Focus on gems where your team has expertise
    • Assign team members to specific gems for review
    • Link each gem to its code/project repository for reference
    • Please update this issue with a Due Date for when you think you can get this work completed

  2. Technical Assessment:

    • Check for C-extensions that may be affected by Ruby version changes
    • Browse the gem's issue tracker for Ruby 3.3/3.4 incompatibilities
    • Verify if the gem is running CI builds against Ruby 3.3/3.4
    • Consider edge cases not covered by existing automated tests

  3. Documentation:

    • Please update the spreadsheet
    • Mark "Review complete" when your assessment is finished
    • Set "Action required" to Y/N/? based on your findings
    • Document any issues found and suggested follow-ups (preferably link to GitLab issues)
    • Note that we'll roll out Ruby 3.3 first, but document both 3.3 and 3.4 issues

  4. Follow-up:

    • If you resolve any issues (by updating gems or submitting code fixes), update the status
    • Toggle "Action required" to N once issues are addressed

Next Steps

  1. Review the gems listed above
  2. Add comments if any gems should be added, removed or transferred
  3. Create follow-up issues for any Ruby 3.3/3.4 compatibility problems
  4. Update the status when issues are resolved
  5. Sign off on the related issue when complete

Tools

  • Consider using ruby-audit to help pull the correct gem source code for your testing
  • Focus on high-severity problems, document edge cases