[go: up one dir, main page]

Skip to content

Zoekt Exclude forks and Include archived filters are not working properly when the response is cached

Summary

We are not adding a forked and archived filters in the cache key. That is why the user could see the cached result even if they change the filter.

Steps to reproduce

Perform a group-level search that has forked projects inside it. Search for the term that exists in the forked project. Check/Uncheck the Exclude forks filter from the sidebar.

What is the current bug behavior?

Search results are not respecting the fork filter for 5 minutes

What is the expected correct behavior?

Search results should respect the fork filter.

Relevant logs and/or screenshots

https://gitlab.com/search?group_id=2750817&scope=blobs&search=cookbook-wrapper-gitlab-runn&regex=true&exclude_forks=true

Possible fixes

Add fork and archived in the Search::Zoekt::Cache fingerprint

Edited by Ravi Kumar