[go: up one dir, main page]

Skip to content

The `Merge request dependencies` input doesn't capture button presses which causes tab to navigate and enter to submit the form.

I've noticed this a few times and it's a very frustrating UX.

When creating a new MR I often have an upstream MR that is a dependency.

I'll often add this before adding labels, however, entering the MR URL and hitting enter submits the form instead of "saving" the dependency. Similarly tab navigates to the next input instead of "saving" the dependency and allowing you to enter another one.

Screen_Recording_2024-12-06_at_16.55.16

Notice here, the first time I press enter and because the dependency hasn't been "saved" yet (turned into a pill inside the input) it is not submitted. Unless you know this and go back to edit the MR, the dependency is lost to the ether. This is a bad UX and may lead to MRs being merged before their dependencies.

The second time I press tab which I expect to save the state and remain focused on the dependencies input. However, what actually happens is the focus moves to the next input on the page.

The correct way to do this is to press space (as shown after typing asdf in the video), however, this feels unexpected when I'm assuming the majority of users are copy and pasting these URLs into the input.

Edited by Joe Woodward