From 36a37544ce4cc33c4780dda7dbe7a4e20442491c Mon Sep 17 00:00:00 2001
From: Thomas Randolph <trandolph@gitlab.com>
Date: Tue, 8 Aug 2023 16:56:17 -0600
Subject: [PATCH 1/9] Track usage of saved replies when on an MR page

---
 .../components/markdown/comment_templates_dropdown.vue       | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/app/assets/javascripts/vue_shared/components/markdown/comment_templates_dropdown.vue b/app/assets/javascripts/vue_shared/components/markdown/comment_templates_dropdown.vue
index abfb92f772d5e2..2ba3f3ffbc1d1c 100644
--- a/app/assets/javascripts/vue_shared/components/markdown/comment_templates_dropdown.vue
+++ b/app/assets/javascripts/vue_shared/components/markdown/comment_templates_dropdown.vue
@@ -1,6 +1,7 @@
 <script>
 import { GlCollapsibleListbox, GlTooltip, GlButton } from '@gitlab/ui';
 import fuzzaldrinPlus from 'fuzzaldrin-plus';
+import { getDerivedMergeRequestInformation } from '~/diffs/utils/merge_request';
 import { InternalEvents } from '~/tracking';
 import savedRepliesQuery from './saved_replies.query.graphql';
 
@@ -54,10 +55,14 @@ export default {
       this.commentTemplateSearch = search;
     },
     onSelect(id) {
+      const isInMr = Boolean(getDerivedMergeRequestInformation({ endpoint: window.location }).id);
       const savedReply = this.savedReplies.find((r) => r.id === id);
       if (savedReply) {
         this.$emit('select', savedReply.content);
         this.track_event('i_code_review_saved_replies_use');
+        if (isInMr) {
+          this.track_event('i_code_review_saved_replies_use_in_mr');
+        }
       }
     },
   },
-- 
GitLab


From 33d3f56f708d2061120c7c3d78f06024802b1d9a Mon Sep 17 00:00:00 2001
From: Thomas Randolph <trandolph@gitlab.com>
Date: Wed, 9 Aug 2023 13:21:52 -0600
Subject: [PATCH 2/9] Refactor saved replies tracking tests

---
 .../comment_templates_dropdown_spec.js        | 40 +++++++++++--------
 1 file changed, 23 insertions(+), 17 deletions(-)

diff --git a/spec/frontend/vue_shared/components/markdown/comment_templates_dropdown_spec.js b/spec/frontend/vue_shared/components/markdown/comment_templates_dropdown_spec.js
index e4689a84900488..64a68f390d2915 100644
--- a/spec/frontend/vue_shared/components/markdown/comment_templates_dropdown_spec.js
+++ b/spec/frontend/vue_shared/components/markdown/comment_templates_dropdown_spec.js
@@ -37,6 +37,18 @@ function findDropdownComponent() {
   return wrapper.findComponent(GlCollapsibleListbox);
 }
 
+async function selectSavedReply(){
+  const dropdown = findDropdownComponent();
+
+  dropdown.vm.$emit('shown');
+
+  await waitForPromises();
+
+  dropdown.vm.$emit('select', savedRepliesResponse.data.currentUser.savedReplies.nodes[0].id);
+
+  return waitForPromises();
+}
+
 describe('Comment templates dropdown', () => {
   it('fetches data when dropdown gets opened', async () => {
     const mockApollo = createMockApolloProvider(savedRepliesResponse);
@@ -69,22 +81,16 @@ describe('Comment templates dropdown', () => {
       expect(wrapper.emitted().select[0]).toEqual(['Saved Reply Content']);
     });
 
-    it('tracks the usage of the saved comment', async () => {
-      const dropdown = findDropdownComponent();
-
-      dropdown.vm.$emit('shown');
-
-      await waitForPromises();
-
-      dropdown.vm.$emit('select', savedRepliesResponse.data.currentUser.savedReplies.nodes[0].id);
-
-      await waitForPromises();
-
-      expect(trackingSpy).toHaveBeenCalledWith(
-        expect.any(String),
-        'i_code_review_saved_replies_use',
-        expect.any(Object),
-      );
-    });
+    describe('tracking', () => {
+      it('tracks overall usage', async () => {
+        await selectSavedReply();
+
+        expect(trackingSpy).toHaveBeenCalledWith(
+          expect.any(String),
+          'i_code_review_saved_replies_use',
+          expect.any(Object),
+        );
+      });
+    })
   });
 });
-- 
GitLab


From 2651a1e7581faa36d8cd2deede4eac0d2afa2db9 Mon Sep 17 00:00:00 2001
From: Thomas Randolph <trandolph@gitlab.com>
Date: Wed, 9 Aug 2023 13:33:18 -0600
Subject: [PATCH 3/9] Test the event sent only for MR page usage of saved
 replies

---
 .../comment_templates_dropdown_spec.js        | 33 +++++++++++++++++--
 1 file changed, 31 insertions(+), 2 deletions(-)

diff --git a/spec/frontend/vue_shared/components/markdown/comment_templates_dropdown_spec.js b/spec/frontend/vue_shared/components/markdown/comment_templates_dropdown_spec.js
index 64a68f390d2915..77b328ef7a9e20 100644
--- a/spec/frontend/vue_shared/components/markdown/comment_templates_dropdown_spec.js
+++ b/spec/frontend/vue_shared/components/markdown/comment_templates_dropdown_spec.js
@@ -5,6 +5,7 @@ import savedRepliesResponse from 'test_fixtures/graphql/comment_templates/saved_
 import { mockTracking } from 'helpers/tracking_helper';
 import { mountExtended } from 'helpers/vue_test_utils_helper';
 import createMockApollo from 'helpers/mock_apollo_helper';
+import { useMockLocationHelper } from 'helpers/mock_window_location_helper';
 import waitForPromises from 'helpers/wait_for_promises';
 import CommentTemplatesDropdown from '~/vue_shared/components/markdown/comment_templates_dropdown.vue';
 import savedRepliesQuery from '~/vue_shared/components/markdown/saved_replies.query.graphql';
@@ -37,7 +38,7 @@ function findDropdownComponent() {
   return wrapper.findComponent(GlCollapsibleListbox);
 }
 
-async function selectSavedReply(){
+async function selectSavedReply() {
   const dropdown = findDropdownComponent();
 
   dropdown.vm.$emit('shown');
@@ -49,6 +50,8 @@ async function selectSavedReply(){
   return waitForPromises();
 }
 
+useMockLocationHelper();
+
 describe('Comment templates dropdown', () => {
   it('fetches data when dropdown gets opened', async () => {
     const mockApollo = createMockApolloProvider(savedRepliesResponse);
@@ -91,6 +94,32 @@ describe('Comment templates dropdown', () => {
           expect.any(Object),
         );
       });
-    })
+
+      describe('MR-specific usage event', () => {
+        it('is sent when in an MR', async () => {
+          window.location.toString.mockReturnValue('this/looks/like/a/-/merge_requests/1');
+
+          await selectSavedReply();
+
+          expect(trackingSpy).toHaveBeenCalledWith(
+            expect.any(String),
+            'i_code_review_saved_replies_use_in_mr',
+            expect.any(Object),
+          );
+        });
+
+        it('is not sent when not in an MR', async () => {
+          window.location.toString.mockReturnValue('this/looks/like/a/-/issues/1');
+
+          await selectSavedReply();
+
+          expect(trackingSpy).not.toHaveBeenCalledWith(
+            expect.any(String),
+            'i_code_review_saved_replies_use_in_mr',
+            expect.any(Object),
+          );
+        });
+      });
+    });
   });
 });
-- 
GitLab


From 0e975963dd161332a6a925bed6fa0aa3680715e6 Mon Sep 17 00:00:00 2001
From: Thomas Randolph <trandolph@gitlab.com>
Date: Wed, 9 Aug 2023 13:46:03 -0600
Subject: [PATCH 4/9] Add total count metric for saved reply usage on MRs

---
 ..._i_code_review_saved_replies_use_in_mr.yml | 25 +++++++++++++++++++
 1 file changed, 25 insertions(+)
 create mode 100644 config/metrics/counts_all/20230809194308_i_code_review_saved_replies_use_in_mr.yml

diff --git a/config/metrics/counts_all/20230809194308_i_code_review_saved_replies_use_in_mr.yml b/config/metrics/counts_all/20230809194308_i_code_review_saved_replies_use_in_mr.yml
new file mode 100644
index 00000000000000..a12d694306ea5a
--- /dev/null
+++ b/config/metrics/counts_all/20230809194308_i_code_review_saved_replies_use_in_mr.yml
@@ -0,0 +1,25 @@
+---
+key_path: counts.i_code_review_saved_replies_use_in_mr
+description: Total number of times a saved reply was used from an MR page
+product_section: dev
+product_stage: create
+product_group: code_review
+value_type: number
+status: active
+milestone: "16.3"
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/128821
+time_frame: all
+data_source: redis
+data_category: optional
+instrumentation_class: RedisMetric
+performance_indicator_type: []
+distribution:
+- ce
+- ee
+tier:
+- free
+- premium
+- ultimate
+options:
+  event: use_in_mr
+  prefix: i_code_review_saved_replies
-- 
GitLab


From c9a3acfba8eb11ff9557ddc0e3990c37de99dba2 Mon Sep 17 00:00:00 2001
From: Thomas Randolph <trandolph@gitlab.com>
Date: Wed, 9 Aug 2023 13:53:35 -0600
Subject: [PATCH 5/9] Add unique user (HLL) metrics for saved reply usage in
 MRs

---
 ...e_review_category_monthly_active_users.yml |  1 +
 ...code_review_group_monthly_active_users.yml |  1 +
 ...review_saved_replies_use_in_mr_monthly.yml | 25 +++++++++++++++++++
 ...code_review_group_monthly_active_users.yml |  1 +
 ...e_review_category_monthly_active_users.yml |  1 +
 ..._review_saved_replies_use_in_mr_weekly.yml | 25 +++++++++++++++++++
 6 files changed, 54 insertions(+)
 create mode 100644 config/metrics/counts_28d/20230809194743_i_code_review_saved_replies_use_in_mr_monthly.yml
 create mode 100644 config/metrics/counts_7d/20230809194743_i_code_review_saved_replies_use_in_mr_weekly.yml

diff --git a/config/metrics/counts_28d/20210427102618_code_review_category_monthly_active_users.yml b/config/metrics/counts_28d/20210427102618_code_review_category_monthly_active_users.yml
index 8d1f00446d78be..18f4ed248370b6 100644
--- a/config/metrics/counts_28d/20210427102618_code_review_category_monthly_active_users.yml
+++ b/config/metrics/counts_28d/20210427102618_code_review_category_monthly_active_users.yml
@@ -141,3 +141,4 @@ options:
     - 'i_code_review_merge_request_widget_security_reports_expand_failed'
     - 'i_code_review_saved_replies_create'
     - 'i_code_review_saved_replies_use'
+    - 'i_code_review_saved_replies_use_in_mr'
diff --git a/config/metrics/counts_28d/20210427103119_code_review_group_monthly_active_users.yml b/config/metrics/counts_28d/20210427103119_code_review_group_monthly_active_users.yml
index e19e0965e05443..796acd20d15b39 100644
--- a/config/metrics/counts_28d/20210427103119_code_review_group_monthly_active_users.yml
+++ b/config/metrics/counts_28d/20210427103119_code_review_group_monthly_active_users.yml
@@ -146,3 +146,4 @@ options:
     - 'i_code_review_merge_request_widget_security_reports_expand_failed'
     - 'i_code_review_saved_replies_create'
     - 'i_code_review_saved_replies_use'
+    - 'i_code_review_saved_replies_use_in_mr'
diff --git a/config/metrics/counts_28d/20230809194743_i_code_review_saved_replies_use_in_mr_monthly.yml b/config/metrics/counts_28d/20230809194743_i_code_review_saved_replies_use_in_mr_monthly.yml
new file mode 100644
index 00000000000000..490dbfadcd260e
--- /dev/null
+++ b/config/metrics/counts_28d/20230809194743_i_code_review_saved_replies_use_in_mr_monthly.yml
@@ -0,0 +1,25 @@
+---
+key_path: redis_hll_counters.code_review.i_code_review_saved_replies_use_in_mr_monthly
+description: Monthly unique users who used saved replies from an MR page
+product_section: dev
+product_stage: create
+product_group: code_review
+value_type: number
+status: active
+milestone: "16.3"
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/128821
+time_frame: 28d
+data_source: redis_hll
+data_category: optional
+instrumentation_class: RedisHLLMetric
+performance_indicator_type: []
+distribution:
+- ce
+- ee
+tier:
+- free
+- premium
+- ultimate
+options:
+  events:
+  - i_code_review_saved_replies_use_in_mr
diff --git a/config/metrics/counts_7d/20210427103328_code_review_group_monthly_active_users.yml b/config/metrics/counts_7d/20210427103328_code_review_group_monthly_active_users.yml
index 94cf3bcc63c3c6..b7a65d38ab3cb7 100644
--- a/config/metrics/counts_7d/20210427103328_code_review_group_monthly_active_users.yml
+++ b/config/metrics/counts_7d/20210427103328_code_review_group_monthly_active_users.yml
@@ -144,3 +144,4 @@ options:
     - 'i_code_review_merge_request_widget_security_reports_expand_failed'
     - 'i_code_review_saved_replies_create'
     - 'i_code_review_saved_replies_use'
+    - 'i_code_review_saved_replies_use_in_mr'
diff --git a/config/metrics/counts_7d/20210427103407_code_review_category_monthly_active_users.yml b/config/metrics/counts_7d/20210427103407_code_review_category_monthly_active_users.yml
index a15273b156b759..c7c7e248ea0b1c 100644
--- a/config/metrics/counts_7d/20210427103407_code_review_category_monthly_active_users.yml
+++ b/config/metrics/counts_7d/20210427103407_code_review_category_monthly_active_users.yml
@@ -139,3 +139,4 @@ options:
     - 'i_code_review_merge_request_widget_security_reports_expand_failed'
     - 'i_code_review_saved_replies_create'
     - 'i_code_review_saved_replies_use'
+    - 'i_code_review_saved_replies_use_in_mr'
diff --git a/config/metrics/counts_7d/20230809194743_i_code_review_saved_replies_use_in_mr_weekly.yml b/config/metrics/counts_7d/20230809194743_i_code_review_saved_replies_use_in_mr_weekly.yml
new file mode 100644
index 00000000000000..81dc130397b33a
--- /dev/null
+++ b/config/metrics/counts_7d/20230809194743_i_code_review_saved_replies_use_in_mr_weekly.yml
@@ -0,0 +1,25 @@
+---
+key_path: redis_hll_counters.code_review.i_code_review_saved_replies_use_in_mr_weekly
+description: Weekly unique users who used saved replies from an MR page
+product_section: dev
+product_stage: create
+product_group: code_review
+value_type: number
+status: active
+milestone: "16.3"
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/128821
+time_frame: 7d
+data_source: redis_hll
+data_category: optional
+instrumentation_class: RedisHLLMetric
+performance_indicator_type: []
+distribution:
+- ce
+- ee
+tier:
+- free
+- premium
+- ultimate
+options:
+  events:
+  - i_code_review_saved_replies_use_in_mr
-- 
GitLab


From 94c60f15064a4f3bd922704d6c29053d53cfc561 Mon Sep 17 00:00:00 2001
From: Thomas Randolph <trandolph@gitlab.com>
Date: Thu, 10 Aug 2023 11:07:14 -0600
Subject: [PATCH 6/9] Review: Use constants for tracking event names

---
 .../components/markdown/comment_templates_dropdown.vue     | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/app/assets/javascripts/vue_shared/components/markdown/comment_templates_dropdown.vue b/app/assets/javascripts/vue_shared/components/markdown/comment_templates_dropdown.vue
index 2ba3f3ffbc1d1c..4112b5b4548eb3 100644
--- a/app/assets/javascripts/vue_shared/components/markdown/comment_templates_dropdown.vue
+++ b/app/assets/javascripts/vue_shared/components/markdown/comment_templates_dropdown.vue
@@ -5,6 +5,9 @@ import { getDerivedMergeRequestInformation } from '~/diffs/utils/merge_request';
 import { InternalEvents } from '~/tracking';
 import savedRepliesQuery from './saved_replies.query.graphql';
 
+const TRACKING_SAVED_REPLIES_USE = 'i_code_review_saved_replies_use';
+const TRACKING_SAVED_REPLIES_USE_IN_MR = 'i_code_review_saved_replies_use_in_mr';
+
 export default {
   apollo: {
     savedReplies: {
@@ -59,9 +62,9 @@ export default {
       const savedReply = this.savedReplies.find((r) => r.id === id);
       if (savedReply) {
         this.$emit('select', savedReply.content);
-        this.track_event('i_code_review_saved_replies_use');
+        this.track_event(TRACKING_SAVED_REPLIES_USE);
         if (isInMr) {
-          this.track_event('i_code_review_saved_replies_use_in_mr');
+          this.track_event(TRACKING_SAVED_REPLIES_USE_IN_MR);
         }
       }
     },
-- 
GitLab


From 7d516fdf3e9a8e4d44c9ab6950225d28c0670e9c Mon Sep 17 00:00:00 2001
From: Thomas Randolph <trandolph@gitlab.com>
Date: Thu, 10 Aug 2023 11:09:17 -0600
Subject: [PATCH 7/9] Review: Remove final waitForPromises

The tests in this case don't care what happens after the 'select'
event, so the final wait doesn't actually change anything.
---
 .../components/markdown/comment_templates_dropdown_spec.js      | 2 --
 1 file changed, 2 deletions(-)

diff --git a/spec/frontend/vue_shared/components/markdown/comment_templates_dropdown_spec.js b/spec/frontend/vue_shared/components/markdown/comment_templates_dropdown_spec.js
index 77b328ef7a9e20..23c93a070c9e7e 100644
--- a/spec/frontend/vue_shared/components/markdown/comment_templates_dropdown_spec.js
+++ b/spec/frontend/vue_shared/components/markdown/comment_templates_dropdown_spec.js
@@ -46,8 +46,6 @@ async function selectSavedReply() {
   await waitForPromises();
 
   dropdown.vm.$emit('select', savedRepliesResponse.data.currentUser.savedReplies.nodes[0].id);
-
-  return waitForPromises();
 }
 
 useMockLocationHelper();
-- 
GitLab


From 975e07da576fb9c40f469e637618792aacf35adc Mon Sep 17 00:00:00 2001
From: Thomas Randolph <trandolph@gitlab.com>
Date: Thu, 10 Aug 2023 11:20:53 -0600
Subject: [PATCH 8/9] Review: Use constants for event names in tests

---
 .../markdown/comment_templates_dropdown_spec.js          | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/spec/frontend/vue_shared/components/markdown/comment_templates_dropdown_spec.js b/spec/frontend/vue_shared/components/markdown/comment_templates_dropdown_spec.js
index 23c93a070c9e7e..327b95b7e03fd3 100644
--- a/spec/frontend/vue_shared/components/markdown/comment_templates_dropdown_spec.js
+++ b/spec/frontend/vue_shared/components/markdown/comment_templates_dropdown_spec.js
@@ -13,6 +13,9 @@ import savedRepliesQuery from '~/vue_shared/components/markdown/saved_replies.qu
 let wrapper;
 let savedRepliesResp;
 
+const TRACK_SAVED_REPLY_USE = 'i_code_review_saved_replies_use';
+const TRACK_SAVED_REPLY_USE_IN_MR = 'i_code_review_saved_replies_use_in_mr';
+
 function createMockApolloProvider(response) {
   Vue.use(VueApollo);
 
@@ -88,7 +91,7 @@ describe('Comment templates dropdown', () => {
 
         expect(trackingSpy).toHaveBeenCalledWith(
           expect.any(String),
-          'i_code_review_saved_replies_use',
+          TRACK_SAVED_REPLY_USE,
           expect.any(Object),
         );
       });
@@ -101,7 +104,7 @@ describe('Comment templates dropdown', () => {
 
           expect(trackingSpy).toHaveBeenCalledWith(
             expect.any(String),
-            'i_code_review_saved_replies_use_in_mr',
+            TRACK_SAVED_REPLY_USE_IN_MR,
             expect.any(Object),
           );
         });
@@ -113,7 +116,7 @@ describe('Comment templates dropdown', () => {
 
           expect(trackingSpy).not.toHaveBeenCalledWith(
             expect.any(String),
-            'i_code_review_saved_replies_use_in_mr',
+            TRACK_SAVED_REPLY_USE_IN_MR,
             expect.any(Object),
           );
         });
-- 
GitLab


From e207ef606423f29dc197f994a5ef020447536b12 Mon Sep 17 00:00:00 2001
From: Thomas Randolph <trandolph@gitlab.com>
Date: Thu, 10 Aug 2023 11:21:08 -0600
Subject: [PATCH 9/9] Review: Move constants to a file

---
 .../markdown/comment_templates_dropdown.vue       |  4 +---
 .../vue_shared/components/markdown/constants.js   |  2 ++
 .../markdown/comment_templates_dropdown_spec.js   | 15 +++++++++------
 3 files changed, 12 insertions(+), 9 deletions(-)
 create mode 100644 app/assets/javascripts/vue_shared/components/markdown/constants.js

diff --git a/app/assets/javascripts/vue_shared/components/markdown/comment_templates_dropdown.vue b/app/assets/javascripts/vue_shared/components/markdown/comment_templates_dropdown.vue
index 4112b5b4548eb3..b1c6f5e6056f63 100644
--- a/app/assets/javascripts/vue_shared/components/markdown/comment_templates_dropdown.vue
+++ b/app/assets/javascripts/vue_shared/components/markdown/comment_templates_dropdown.vue
@@ -4,9 +4,7 @@ import fuzzaldrinPlus from 'fuzzaldrin-plus';
 import { getDerivedMergeRequestInformation } from '~/diffs/utils/merge_request';
 import { InternalEvents } from '~/tracking';
 import savedRepliesQuery from './saved_replies.query.graphql';
-
-const TRACKING_SAVED_REPLIES_USE = 'i_code_review_saved_replies_use';
-const TRACKING_SAVED_REPLIES_USE_IN_MR = 'i_code_review_saved_replies_use_in_mr';
+import { TRACKING_SAVED_REPLIES_USE, TRACKING_SAVED_REPLIES_USE_IN_MR } from './constants';
 
 export default {
   apollo: {
diff --git a/app/assets/javascripts/vue_shared/components/markdown/constants.js b/app/assets/javascripts/vue_shared/components/markdown/constants.js
new file mode 100644
index 00000000000000..47ef7cccbc22ee
--- /dev/null
+++ b/app/assets/javascripts/vue_shared/components/markdown/constants.js
@@ -0,0 +1,2 @@
+export const TRACKING_SAVED_REPLIES_USE = 'i_code_review_saved_replies_use';
+export const TRACKING_SAVED_REPLIES_USE_IN_MR = 'i_code_review_saved_replies_use_in_mr';
diff --git a/spec/frontend/vue_shared/components/markdown/comment_templates_dropdown_spec.js b/spec/frontend/vue_shared/components/markdown/comment_templates_dropdown_spec.js
index 327b95b7e03fd3..cd9f27dccbd6e9 100644
--- a/spec/frontend/vue_shared/components/markdown/comment_templates_dropdown_spec.js
+++ b/spec/frontend/vue_shared/components/markdown/comment_templates_dropdown_spec.js
@@ -9,13 +9,14 @@ import { useMockLocationHelper } from 'helpers/mock_window_location_helper';
 import waitForPromises from 'helpers/wait_for_promises';
 import CommentTemplatesDropdown from '~/vue_shared/components/markdown/comment_templates_dropdown.vue';
 import savedRepliesQuery from '~/vue_shared/components/markdown/saved_replies.query.graphql';
+import {
+  TRACKING_SAVED_REPLIES_USE,
+  TRACKING_SAVED_REPLIES_USE_IN_MR,
+} from '~/vue_shared/components/markdown/constants';
 
 let wrapper;
 let savedRepliesResp;
 
-const TRACK_SAVED_REPLY_USE = 'i_code_review_saved_replies_use';
-const TRACK_SAVED_REPLY_USE_IN_MR = 'i_code_review_saved_replies_use_in_mr';
-
 function createMockApolloProvider(response) {
   Vue.use(VueApollo);
 
@@ -91,7 +92,7 @@ describe('Comment templates dropdown', () => {
 
         expect(trackingSpy).toHaveBeenCalledWith(
           expect.any(String),
-          TRACK_SAVED_REPLY_USE,
+          TRACKING_SAVED_REPLIES_USE,
           expect.any(Object),
         );
       });
@@ -104,9 +105,10 @@ describe('Comment templates dropdown', () => {
 
           expect(trackingSpy).toHaveBeenCalledWith(
             expect.any(String),
-            TRACK_SAVED_REPLY_USE_IN_MR,
+            TRACKING_SAVED_REPLIES_USE_IN_MR,
             expect.any(Object),
           );
+          expect(trackingSpy).toHaveBeenCalledTimes(2);
         });
 
         it('is not sent when not in an MR', async () => {
@@ -116,9 +118,10 @@ describe('Comment templates dropdown', () => {
 
           expect(trackingSpy).not.toHaveBeenCalledWith(
             expect.any(String),
-            TRACK_SAVED_REPLY_USE_IN_MR,
+            TRACKING_SAVED_REPLIES_USE_IN_MR,
             expect.any(Object),
           );
+          expect(trackingSpy).toHaveBeenCalledTimes(1);
         });
       });
     });
-- 
GitLab