diff --git a/.rubocop_todo/internal_affairs/redundant_message_argument.yml b/.rubocop_todo/internal_affairs/redundant_message_argument.yml deleted file mode 100644 index 4f69368ced6c3281eb83610c7edde14185797d9f..0000000000000000000000000000000000000000 --- a/.rubocop_todo/internal_affairs/redundant_message_argument.yml +++ /dev/null @@ -1,18 +0,0 @@ ---- -# Cop supports --autocorrect. -InternalAffairs/RedundantMessageArgument: - Details: grace period - Exclude: - - 'rubocop/cop/feature_flag_usage.rb' - - 'rubocop/cop/file_decompression.rb' - - 'rubocop/cop/gitlab/feature_flag_without_actor.rb' - - 'rubocop/cop/gitlab/license_available_usage.rb' - - 'rubocop/cop/gitlab/no_find_in_workers.rb' - - 'rubocop/cop/migration/async_post_migrate_only.rb' - - 'rubocop/cop/migration/batch_migrations_post_only.rb' - - 'rubocop/cop/migration/migration_with_milestone.rb' - - 'rubocop/cop/migration/prevent_single_statement_with_disable_ddl_transaction.rb' - - 'rubocop/cop/migration/schema_addition_methods_no_post.rb' - - 'rubocop/cop/redis_queue_usage.rb' - - 'rubocop/cop/sidekiq_api_usage.rb' - - 'rubocop/cop/sidekiq_redis_call.rb' diff --git a/rubocop/cop/feature_flag_usage.rb b/rubocop/cop/feature_flag_usage.rb index 2220238454b54f8186fbf79027ad44d6a9c4d2e6..457f939ad1bdb002064f13ce121f6947df34cb09 100644 --- a/rubocop/cop/feature_flag_usage.rb +++ b/rubocop/cop/feature_flag_usage.rb @@ -13,7 +13,7 @@ class FeatureFlagUsage < RuboCop::Cop::Base def on_send(node) return unless using_feature_flag?(node) - add_offense(node, message: MSG) + add_offense(node) end end end diff --git a/rubocop/cop/file_decompression.rb b/rubocop/cop/file_decompression.rb index ef53e352ff7c7813ebce45fe0d3159bdba09d67f..1a75b55b0bed98c59a645dd4a558baec0b368d82 100644 --- a/rubocop/cop/file_decompression.rb +++ b/rubocop/cop/file_decompression.rb @@ -25,13 +25,13 @@ class FileDecompression < RuboCop::Cop::Base def on_xstr(node) subshell?(node) do |match| - add_offense(node, message: MSG) if forbidden_command?(match) + add_offense(node) if forbidden_command?(match) end end def on_send(node) system?(node) do |match| - add_offense(node, message: MSG) if forbidden_command?(match) + add_offense(node) if forbidden_command?(match) end end diff --git a/rubocop/cop/gitlab/feature_flag_without_actor.rb b/rubocop/cop/gitlab/feature_flag_without_actor.rb index 337cf62c92a05059e5dfc4ae43561ed2ed6a53f7..5808d372a0bafa97f87074db868fa55e9de55275 100644 --- a/rubocop/cop/gitlab/feature_flag_without_actor.rb +++ b/rubocop/cop/gitlab/feature_flag_without_actor.rb @@ -19,7 +19,7 @@ class FeatureFlagWithoutActor < RuboCop::Cop::Base def on_send(node) return unless using_feature_flag_without_actor?(node) - add_offense(node, message: MSG) + add_offense(node) end end end diff --git a/rubocop/cop/gitlab/license_available_usage.rb b/rubocop/cop/gitlab/license_available_usage.rb index 8a3b5f49a33a190e2d403ad612b51e4b9e246a01..6eaddf41de3d28b5fa7828441194738b644d5554 100644 --- a/rubocop/cop/gitlab/license_available_usage.rb +++ b/rubocop/cop/gitlab/license_available_usage.rb @@ -19,7 +19,7 @@ class LicenseAvailableUsage < RuboCop::Cop::Base PATTERN def on_send(node) - add_offense(node, message: MSG) if license_feature_available?(node) + add_offense(node) if license_feature_available?(node) end end end diff --git a/rubocop/cop/gitlab/no_find_in_workers.rb b/rubocop/cop/gitlab/no_find_in_workers.rb index f8d418bd55d006bd066c2301ececf0884afb41dc..8e8f7f674e70bb61ad26d1eb783bf1976787570b 100644 --- a/rubocop/cop/gitlab/no_find_in_workers.rb +++ b/rubocop/cop/gitlab/no_find_in_workers.rb @@ -36,7 +36,7 @@ class NoFindInWorkers < RuboCop::Cop::Base PATTERN def on_send(node) - add_offense(node, message: MSG) + add_offense(node) end end end diff --git a/rubocop/cop/migration/async_post_migrate_only.rb b/rubocop/cop/migration/async_post_migrate_only.rb index e5b78617691b3ad31fc4a99faadb1a3aacc8fca5..5a394d54d14aacc156bcc3087e9adef0b0700541 100644 --- a/rubocop/cop/migration/async_post_migrate_only.rb +++ b/rubocop/cop/migration/async_post_migrate_only.rb @@ -24,7 +24,7 @@ def on_send(node) return unless FORBIDDEN_METHODS.include?(node.method_name) return if in_post_deployment_migration?(node) - add_offense(node, message: MSG) + add_offense(node) end end end diff --git a/rubocop/cop/migration/batch_migrations_post_only.rb b/rubocop/cop/migration/batch_migrations_post_only.rb index 28dfb1228da4ce5ca8e61ebbb51879db0f0f01b3..4ad785a512882ee16d4a185111b98cfee4198d93 100644 --- a/rubocop/cop/migration/batch_migrations_post_only.rb +++ b/rubocop/cop/migration/batch_migrations_post_only.rb @@ -29,7 +29,7 @@ def on_send(node) on_forbidden_method(node) do break if in_post_deployment_migration?(node) - add_offense(node, message: MSG) + add_offense(node) end end end diff --git a/rubocop/cop/migration/migration_with_milestone.rb b/rubocop/cop/migration/migration_with_milestone.rb index d217527b4c76ed8a4eea9175d6aeb16490fe0051..38a93323bf80adfdd8968a8c79b34bd1c0b82d44 100644 --- a/rubocop/cop/migration/migration_with_milestone.rb +++ b/rubocop/cop/migration/migration_with_milestone.rb @@ -22,7 +22,7 @@ def on_class(node) body_node = node.body return unless body_node - add_offense(node, message: MSG) unless milestone_call?(body_node) + add_offense(node) unless milestone_call?(body_node) end end end diff --git a/rubocop/cop/migration/prevent_single_statement_with_disable_ddl_transaction.rb b/rubocop/cop/migration/prevent_single_statement_with_disable_ddl_transaction.rb index 88e1befe5020df738c3bd70928c3cde1c87663ec..c9dcd7aa12ab0ed9fc923aee529a97b726d04899 100644 --- a/rubocop/cop/migration/prevent_single_statement_with_disable_ddl_transaction.rb +++ b/rubocop/cop/migration/prevent_single_statement_with_disable_ddl_transaction.rb @@ -78,7 +78,7 @@ def on_begin(node) end if disable_ddl_transaction_node && has_validate_foreign_key && statement_count == 1 - add_offense(disable_ddl_transaction_node, message: MSG) + add_offense(disable_ddl_transaction_node) end end end diff --git a/rubocop/cop/migration/schema_addition_methods_no_post.rb b/rubocop/cop/migration/schema_addition_methods_no_post.rb index 874ba222d93f08625a3287124b2b4240387ece94..1170c091a4864ed1758784ee9d9e9710182e2c99 100644 --- a/rubocop/cop/migration/schema_addition_methods_no_post.rb +++ b/rubocop/cop/migration/schema_addition_methods_no_post.rb @@ -34,7 +34,7 @@ def on_send(node) return if rolling_back_migration?(node) on_forbidden_method(node) do - add_offense(node, message: MSG) + add_offense(node) end end diff --git a/rubocop/cop/redis_queue_usage.rb b/rubocop/cop/redis_queue_usage.rb index 66202f4666a1d74edcbf0e8b3cbba8a03dee6cd7..c16d03d61beb45ef949d173b4a308b712f8bbbcf 100644 --- a/rubocop/cop/redis_queue_usage.rb +++ b/rubocop/cop/redis_queue_usage.rb @@ -27,13 +27,13 @@ class RedisQueueUsage < RuboCop::Cop::Base def on_send(node) return unless using_redis_queue_module_as_parameter?(node) || calling_redis_queue_module_methods?(node) - add_offense(node, message: MSG) + add_offense(node) end # offenses caught in assignment may overlap with on_send %i[on_lvasgn on_ivasgn on_cvasgn on_gvasgn on_casgn on_masgn on_op_asgn on_or_asgn on_and_asgn].each do |name| define_method(name) do |node| - add_offense(node, message: MSG) if redis_queue_assignment?(node) + add_offense(node) if redis_queue_assignment?(node) end end end diff --git a/rubocop/cop/sidekiq_api_usage.rb b/rubocop/cop/sidekiq_api_usage.rb index 62816a781fd7669e7442c2ceedbdbac5783bc6c6..022755bb0c4a849da611ca5b447a9c4dade08c65 100644 --- a/rubocop/cop/sidekiq_api_usage.rb +++ b/rubocop/cop/sidekiq_api_usage.rb @@ -31,7 +31,7 @@ def on_send(node) # allow Sidekiq::Client.via calls next if klass == :Client && ALLOWED_CLIENT_METHODS.include?(methods_called[0]) - add_offense(node, message: MSG) + add_offense(node) end end end diff --git a/rubocop/cop/sidekiq_redis_call.rb b/rubocop/cop/sidekiq_redis_call.rb index e4ae430f7c7302e84a4aaf1060644ea6a5c78930..1f1ad952a2feb9b98aa60b176189138cd01f475d 100644 --- a/rubocop/cop/sidekiq_redis_call.rb +++ b/rubocop/cop/sidekiq_redis_call.rb @@ -11,7 +11,7 @@ class SidekiqRedisCall < RuboCop::Cop::Base PATTERN def on_send(node) - add_offense(node, message: MSG) if using_sidekiq_redis?(node) + add_offense(node) if using_sidekiq_redis?(node) end end end