From b536ef663364140093a7bedff2ad06973b6c851b Mon Sep 17 00:00:00 2001 From: gdk Date: Thu, 17 Jul 2025 23:32:37 +0000 Subject: [PATCH] Finalize BBM BackfillOrganizationIdOnCiRunnerTaggings This migration was finished at `2025-06-18 08:53:05 UTC`, you can confirm the status using our [batched background migration chatops commands](https://docs.gitlab.com/ee/development/database/batched_background_migrations.html#monitor-the-progress-and-status-of-a-batched-background-migration). To confirm it is finished you can run: ``` /chatops run batched_background_migrations status 2000441 --database ci ``` The last time this background migration was triggered was in [db/post_migrate/20250602183875_queue_backfill_organization_id_on_ci_runner_taggings.rb](https://gitlab.com/gitlab-org/gitlab/-/blob/master/db/post_migrate/20250602183875_queue_backfill_organization_id_on_ci_runner_taggings.rb) You can read more about the process for finalizing batched background migrations in https://docs.gitlab.com/ee/development/database/batched_background_migrations.html . As part of our process we want to ensure all batched background migrations have had at least one [required stop](https://docs.gitlab.com/ee/development/database/required_stops.html) to process the migration. Therefore we can finalize any batched background migration that was added before the last required stop. This change was generated by [gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper) in [CI](https://ops.gitlab.net/gitlab-com/database-team/gitlab-com-database-testing/-/jobs/19363183) using the `Keeps::OverdueFinalizeBackgroundMigration` keep. To provide feedback on your experience with `gitlab-housekeeper` please create an issue with the label ~"GitLab Housekeeper" and consider pinging the author of this keep. Changelog: other --- ..._organization_id_on_ci_runner_taggings.yml | 8 ++++--- ...l_organization_id_on_ci_runner_taggings.rb | 21 +++++++++++++++++++ db/schema_migrations/20250717233215 | 1 + 3 files changed, 27 insertions(+), 3 deletions(-) create mode 100644 db/post_migrate/20250717233215_finalize_hk_backfill_organization_id_on_ci_runner_taggings.rb create mode 100644 db/schema_migrations/20250717233215 diff --git a/db/docs/batched_background_migrations/backfill_organization_id_on_ci_runner_taggings.yml b/db/docs/batched_background_migrations/backfill_organization_id_on_ci_runner_taggings.yml index 7e8b57f01d2115..32233273963437 100644 --- a/db/docs/batched_background_migrations/backfill_organization_id_on_ci_runner_taggings.yml +++ b/db/docs/batched_background_migrations/backfill_organization_id_on_ci_runner_taggings.yml @@ -1,9 +1,11 @@ --- migration_job_name: BackfillOrganizationIdOnCiRunnerTaggings -description: > - Backfill organization_id column in taggings associated with non-instance type runners with default organization id +description: 'Backfill organization_id column in taggings associated with non-instance + type runners with default organization id + + ' feature_category: runner introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/193195 milestone: '18.2' queued_migration_version: 20250602183875 -finalized_by: # version of the migration that finalized this BBM +finalized_by: '20250717233215' diff --git a/db/post_migrate/20250717233215_finalize_hk_backfill_organization_id_on_ci_runner_taggings.rb b/db/post_migrate/20250717233215_finalize_hk_backfill_organization_id_on_ci_runner_taggings.rb new file mode 100644 index 00000000000000..b33fcec7ca299c --- /dev/null +++ b/db/post_migrate/20250717233215_finalize_hk_backfill_organization_id_on_ci_runner_taggings.rb @@ -0,0 +1,21 @@ +# frozen_string_literal: true + +class FinalizeHkBackfillOrganizationIdOnCiRunnerTaggings < Gitlab::Database::Migration[2.3] + milestone '18.3' + + disable_ddl_transaction! + + restrict_gitlab_migration gitlab_schema: :gitlab_ci + + def up + ensure_batched_background_migration_is_finished( + job_class_name: 'BackfillOrganizationIdOnCiRunnerTaggings', + table_name: :ci_runner_taggings, + column_name: :id, + job_arguments: [], + finalize: true + ) + end + + def down; end +end diff --git a/db/schema_migrations/20250717233215 b/db/schema_migrations/20250717233215 new file mode 100644 index 00000000000000..4aaf2ac0109407 --- /dev/null +++ b/db/schema_migrations/20250717233215 @@ -0,0 +1 @@ +ed7ffd7443a68a6ed1acdc7bd12ecc6b2eb566c9a149e22c39e7e27d7138d876 \ No newline at end of file -- GitLab