From 5c3850de8194842baf603757f8d3a34ea93fd346 Mon Sep 17 00:00:00 2001 From: Kerri Miller Date: Sun, 20 Jul 2025 23:04:32 -0400 Subject: [PATCH 1/2] Restore sort_value_stars_asc to options hash A script identified #sort_value_stars_asc as unused, and in digging deeper, it looks an awful lot like this method, which returns a string used as a key in the hash returned by #projects_sort_options_hash, was removed by accident; indeed, there's 2 keys listed for `sort_value_stars_desc`, which would override the initial declaration. --- app/helpers/sorting_helper.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/helpers/sorting_helper.rb b/app/helpers/sorting_helper.rb index c65e5728454fe7..385190b95576fe 100644 --- a/app/helpers/sorting_helper.rb +++ b/app/helpers/sorting_helper.rb @@ -50,7 +50,7 @@ def projects_sort_options_hash sort_value_recently_created => sort_title_created_date, sort_value_name => sort_title_name, sort_value_name_desc => sort_title_name_desc, - sort_value_stars_desc => sort_title_stars, + sort_value_stars_asc => sort_title_stars, sort_value_oldest_activity => sort_title_oldest_activity, sort_value_oldest_created => sort_title_oldest_created, sort_value_recently_created => sort_title_recently_created, -- GitLab From ebe4f0180b5630c380d1a845fc688d6db295246f Mon Sep 17 00:00:00 2001 From: Kerri Miller Date: Sun, 20 Jul 2025 23:09:29 -0400 Subject: [PATCH 2/2] Remove #sort_value_stars_asc from unused method dictionary --- .../lint/unused_helper_methods/potential_methods_to_remove.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.gitlab/lint/unused_helper_methods/potential_methods_to_remove.yml b/.gitlab/lint/unused_helper_methods/potential_methods_to_remove.yml index f1860b838ade77..02371b316024d3 100644 --- a/.gitlab/lint/unused_helper_methods/potential_methods_to_remove.yml +++ b/.gitlab/lint/unused_helper_methods/potential_methods_to_remove.yml @@ -73,8 +73,6 @@ sidebar_tracking_attributes_by_object: file: app/helpers/sidebars_helper.rb scope_avatar_classes: file: app/helpers/sidebars_helper.rb -sort_value_stars_asc: - file: app/helpers/sorting_titles_values_helper.rb group_or_project_milestone_path: file: app/helpers/timeboxes_helper.rb can_admin_project_milestones?: -- GitLab