From a9f9ee47751a70d2358fe4d95b214b07fe406f00 Mon Sep 17 00:00:00 2001 From: michold Date: Fri, 25 Jul 2025 17:32:30 +0200 Subject: [PATCH] Test metrics, not just events --- spec/models/container_registry/event_spec.rb | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/spec/models/container_registry/event_spec.rb b/spec/models/container_registry/event_spec.rb index 07e76078f7a1c5..865fb6a0ec8e3a 100644 --- a/spec/models/container_registry/event_spec.rb +++ b/spec/models/container_registry/event_spec.rb @@ -130,20 +130,28 @@ shared_examples 'tracking a deploy_token internal event' do it 'sends a tracking event' do event_name = "i_container_registry_#{event}_deploy_token" + expected_metric = "redis_hll_counters.user_container_registry.#{event_name}_monthly" + puts expected_metric + expect { subject } .to trigger_internal_events(event_name) .with(additional_properties: { property: originator.id.to_s }) .exactly(count).time + .and increment_usage_metrics(expected_metric).by(1) end end shared_examples 'tracking a user internal event' do it 'sends a tracking event' do event_name = "i_container_registry_#{event}_user" + expected_metric = "redis_hll_counters.user_container_registry.#{event_name}_monthly" + + puts expected_metric expect { subject } .to trigger_internal_events(event_name) .with(user: originator) .exactly(count).time + .and increment_usage_metrics(expected_metric).by(1) end end -- GitLab