From 823a32931945deedc27c9297eebcd1f93d34e1ff Mon Sep 17 00:00:00 2001 From: Auto-quarantining bot Date: Mon, 28 Jul 2025 03:15:37 +0000 Subject: [PATCH] Quarantine a flaky test The `` Authz::UserAdminRole.create_or_update when a user has join record updates the existing record with the new role `` test matches one of the following conditions: 1. has either ~"flakiness::1" or ~"flakiness::2" label set, which means the number of reported failures is at or above 95 percentile, indicating unusually high failure count. 2. has ~"severity::1" label set, which means the number of reported failures [spiked and exceeded its daily threshold](https://gitlab.com/gitlab-org/ruby/gems/gitlab_quality-test_tooling/-/blob/c9bc10536b1f8d2d4a03c3e0b6099a40fe67ad26/lib/gitlab_quality/test_tooling/report/concerns/issue_reports.rb#L51). This MR quarantines the test. This is a discussion starting point to let the responsible group know about the flakiness so that they can take action: - accept the merge request and schedule the associated issue to improve the test - close the merge request in favor of another merge request to delete the test Please follow the [Flaky tests management process](https://handbook.gitlab.com/handbook/engineering/testing/flaky-tests/#flaky-tests-management-process) to help us increase `master` stability. Please let us know your feedback in the [Engineering Productivity issue tracker](https://gitlab.com/gitlab-org/quality/engineering-productivity/team/-/issues). Related to https://gitlab.com/gitlab-org/gitlab/-/issues/537961. This change was generated by [gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper) in [CI](https://gitlab.com/gitlab-org/quality/engineering-productivity/team/-/jobs/10825857213) using the `Keeps::QuarantineFlakyTests` keep. To provide feedback on your experience with `gitlab-housekeeper` please create an issue with the label ~"GitLab Housekeeper" and consider pinging the author of this keep. Changelog: other --- ee/spec/models/authz/user_admin_role_spec.rb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ee/spec/models/authz/user_admin_role_spec.rb b/ee/spec/models/authz/user_admin_role_spec.rb index fb507426cb06c2..e734c0bd6a1bc7 100644 --- a/ee/spec/models/authz/user_admin_role_spec.rb +++ b/ee/spec/models/authz/user_admin_role_spec.rb @@ -47,7 +47,8 @@ context 'when a user has join record' do let!(:join_record) { create(:user_admin_role, user: user, admin_role: admin_role_2) } - it 'updates the existing record with the new role' do + it 'updates the existing record with the new role', + quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/537961' do expect { create_or_update }.to change { described_class.find_by(user: user).admin_role_id }.from(admin_role_2.id).to(admin_role.id) -- GitLab