From cfbb770e67735ff604d194822996e7d3dbd84a5e Mon Sep 17 00:00:00 2001 From: Artur Fedorov Date: Tue, 21 Oct 2025 23:33:39 +0200 Subject: [PATCH] Vue 3 spec fix Use defineComponent --- scripts/frontend/quarantined_vue3_specs.txt | 1 - .../helpers/init_simple_app_helper_spec.js | 20 ++++--------------- 2 files changed, 4 insertions(+), 17 deletions(-) diff --git a/scripts/frontend/quarantined_vue3_specs.txt b/scripts/frontend/quarantined_vue3_specs.txt index f2dee44e5ddc42..bfe854e5c04bfd 100644 --- a/scripts/frontend/quarantined_vue3_specs.txt +++ b/scripts/frontend/quarantined_vue3_specs.txt @@ -7,7 +7,6 @@ spec/frontend/ci/ci_variable_list/components/ci_variable_shared_spec.js spec/frontend/ci/runner/components/registration/runner_instructions/runner_instructions_modal_spec.js spec/frontend/design_management/pages/design/index_spec.js spec/frontend/design_management/pages/index_spec.js -spec/frontend/helpers/init_simple_app_helper_spec.js spec/frontend/lib/utils/confirm_via_gl_modal/confirm_action_spec.js spec/frontend/packages_and_registries/dependency_proxy/app_spec.js spec/frontend/performance_bar/index_spec.js diff --git a/spec/frontend/helpers/init_simple_app_helper_spec.js b/spec/frontend/helpers/init_simple_app_helper_spec.js index f72c18a20275bb..7df0b9322c54ab 100644 --- a/spec/frontend/helpers/init_simple_app_helper_spec.js +++ b/spec/frontend/helpers/init_simple_app_helper_spec.js @@ -1,11 +1,10 @@ import { createWrapper } from '@vue/test-utils'; -import Vue from 'vue'; -import VueApollo from 'vue-apollo'; +import { defineComponent, h } from 'vue'; import { setHTMLFixture, resetHTMLFixture } from 'helpers/fixtures'; import { initSimpleApp } from '~/helpers/init_simple_app_helper'; -import createDefaultClient from '~/lib/graphql'; -const MockComponent = Vue.component('MockComponent', { +const MockComponent = defineComponent({ + name: 'MockComponent', props: { someKey: { type: String, @@ -18,7 +17,7 @@ const MockComponent = Vue.component('MockComponent', { default: 0, }, }, - render: (createElement) => createElement('span'), + render: () => h('span'), }); let wrapper; @@ -87,17 +86,6 @@ describe('helpers/init_simple_app_helper/initSimpleApp', () => { expect(wrapper.vm.$apollo).not.toBeUndefined(); }); }); - - describe('if VueApollo, sets as default provider', () => { - it('uses the provided apolloClient', () => { - Vue.use(VueApollo); - const apolloProvider = new VueApollo({ defaultClient: createDefaultClient() }); - - initMock('
', { withApolloProvider: apolloProvider }); - - expect(wrapper.vm.$apolloProvider).toBe(apolloProvider); - }); - }); }); describe('name', () => { -- GitLab