From 31f3688efd81729db42733dad2d131cb032e16a7 Mon Sep 17 00:00:00 2001
From: Miguel Rincon <mrincon@gitlab.com>
Date: Wed, 22 Oct 2025 16:12:14 +0200
Subject: [PATCH] Use testid instead of class in pipelines table tests

---
 .../pipelines_page/components/pipeline_url.vue   |  2 +-
 .../user_sees_merge_request_pipelines_spec.rb    | 16 ++++++++--------
 .../merge_request/user_sees_pipelines_spec.rb    |  2 +-
 .../projects/pipelines/pipelines_spec.rb         |  4 ++--
 4 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/app/assets/javascripts/ci/pipelines_page/components/pipeline_url.vue b/app/assets/javascripts/ci/pipelines_page/components/pipeline_url.vue
index 35aaedebcefb76..e9e9e52dd1bac3 100644
--- a/app/assets/javascripts/ci/pipelines_page/components/pipeline_url.vue
+++ b/app/assets/javascripts/ci/pipelines_page/components/pipeline_url.vue
@@ -158,7 +158,7 @@ export default {
 };
 </script>
 <template>
-  <div class="pipeline-tags" data-testid="pipeline-url-table-cell">
+  <div data-testid="pipeline-url-table-cell">
     <gl-link
       v-if="pipelineLink"
       v-tooltip-on-truncate
diff --git a/spec/features/merge_request/user_sees_merge_request_pipelines_spec.rb b/spec/features/merge_request/user_sees_merge_request_pipelines_spec.rb
index 52056d627aa197..defb2d6d3c51fd 100644
--- a/spec/features/merge_request/user_sees_merge_request_pipelines_spec.rb
+++ b/spec/features/merge_request/user_sees_merge_request_pipelines_spec.rb
@@ -131,16 +131,16 @@
 
         it 'sees detached tag for detached merge request pipelines' do
           page.within('.ci-table') do
-            expect(all('.pipeline-tags')[0])
+            expect(all('[data-testid="pipeline-url-table-cell"]')[0])
               .to have_content(expected_detached_mr_tag)
 
-            expect(all('.pipeline-tags')[1])
+            expect(all('[data-testid="pipeline-url-table-cell"]')[1])
               .to have_content(expected_detached_mr_tag)
 
-            expect(all('.pipeline-tags')[2])
+            expect(all('[data-testid="pipeline-url-table-cell"]')[2])
               .not_to have_content(expected_detached_mr_tag)
 
-            expect(all('.pipeline-tags')[3])
+            expect(all('[data-testid="pipeline-url-table-cell"]')[3])
               .not_to have_content(expected_detached_mr_tag)
           end
         end
@@ -324,16 +324,16 @@
 
         it 'sees detached tag for detached merge request pipelines' do
           page.within('.ci-table') do
-            expect(all('.pipeline-tags')[0])
+            expect(all('[data-testid="pipeline-url-table-cell"]')[0])
               .to have_content(expected_detached_mr_tag)
 
-            expect(all('.pipeline-tags')[1])
+            expect(all('[data-testid="pipeline-url-table-cell"]')[1])
               .to have_content(expected_detached_mr_tag)
 
-            expect(all('.pipeline-tags')[2])
+            expect(all('[data-testid="pipeline-url-table-cell"]')[2])
               .not_to have_content(expected_detached_mr_tag)
 
-            expect(all('.pipeline-tags')[3])
+            expect(all('[data-testid="pipeline-url-table-cell"]')[3])
               .not_to have_content(expected_detached_mr_tag)
           end
         end
diff --git a/spec/features/merge_request/user_sees_pipelines_spec.rb b/spec/features/merge_request/user_sees_pipelines_spec.rb
index dca0589782cb2f..b3e9d4573e4735 100644
--- a/spec/features/merge_request/user_sees_pipelines_spec.rb
+++ b/spec/features/merge_request/user_sees_pipelines_spec.rb
@@ -214,7 +214,7 @@ def check_pipeline(expected_project:)
           expect(page).to have_selector('[data-testid="pipeline-table-row"]', count: 2)
 
           page.within(first('[data-testid="pipeline-table-row"]')) do
-            page.within('.pipeline-tags') do
+            within_testid('pipeline-url-table-cell') do
               expect(find_by_testid('pipeline-url-link')[:href]).to include(expected_project.full_path)
               expect(page).to have_content('merge request')
             end
diff --git a/spec/features/projects/pipelines/pipelines_spec.rb b/spec/features/projects/pipelines/pipelines_spec.rb
index 6c971f04fd1faf..119436b343e89c 100644
--- a/spec/features/projects/pipelines/pipelines_spec.rb
+++ b/spec/features/projects/pipelines/pipelines_spec.rb
@@ -230,7 +230,7 @@
 
         shared_examples_for 'detached merge request pipeline' do
           it 'shows pipeline information without pipeline ref', :sidekiq_might_not_need_inline do
-            within '.pipeline-tags' do
+            within_testid('pipeline-url-table-cell') do
               expect(page).to have_content(expected_detached_mr_tag)
 
               expect(page).to have_link(merge_request.iid.to_s, href: project_merge_request_path(project, merge_request))
@@ -270,7 +270,7 @@
 
         shared_examples_for 'Correct merge request pipeline information' do
           it 'does not show detached tag for the pipeline, and shows the link of the merge request, and does not show the ref of the pipeline', :sidekiq_might_not_need_inline do
-            within '.pipeline-tags' do
+            within_testid('pipeline-url-table-cell') do
               expect(page).not_to have_content(expected_detached_mr_tag)
 
               expect(page).to have_link(merge_request.iid.to_s, href: project_merge_request_path(project, merge_request))
-- 
GitLab