From d10dcae67da747b1e2a4c571b6cd2425c014475a Mon Sep 17 00:00:00 2001 From: e_forbes Date: Wed, 22 Oct 2025 11:21:17 +0100 Subject: [PATCH] Removes a redundant user_id field from the pipeline chain validate logs --- lib/gitlab/ci/pipeline/chain/validate/external.rb | 2 +- spec/lib/gitlab/ci/pipeline/chain/validate/external_spec.rb | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/gitlab/ci/pipeline/chain/validate/external.rb b/lib/gitlab/ci/pipeline/chain/validate/external.rb index b569e3444a1421..e006bd2ab3fce5 100644 --- a/lib/gitlab/ci/pipeline/chain/validate/external.rb +++ b/lib/gitlab/ci/pipeline/chain/validate/external.rb @@ -18,7 +18,7 @@ def perform! pipeline_authorized = validate_external log_message = pipeline_authorized ? 'authorized' : 'not authorized' - Gitlab::AppLogger.info(message: "Pipeline #{log_message}", project_id: project.id, user_id: current_user.id) + Gitlab::AppLogger.info(message: "Pipeline #{log_message}", project_id: project.id) return if pipeline_authorized diff --git a/spec/lib/gitlab/ci/pipeline/chain/validate/external_spec.rb b/spec/lib/gitlab/ci/pipeline/chain/validate/external_spec.rb index 5f22c342265a30..11ba2d15fec946 100644 --- a/spec/lib/gitlab/ci/pipeline/chain/validate/external_spec.rb +++ b/spec/lib/gitlab/ci/pipeline/chain/validate/external_spec.rb @@ -142,7 +142,7 @@ end it 'logs the authorization' do - expect(Gitlab::AppLogger).to receive(:info).with(message: 'Pipeline authorized', project_id: project.id, user_id: user.id) + expect(Gitlab::AppLogger).to receive(:info).with(message: 'Pipeline authorized', project_id: project.id) perform! end @@ -330,7 +330,7 @@ it 'logs the authorization' do allow(Gitlab::AppLogger).to receive(:info) - expect(Gitlab::AppLogger).to receive(:info).with(message: 'Pipeline not authorized', project_id: project.id, user_id: user.id) + expect(Gitlab::AppLogger).to receive(:info).with(message: 'Pipeline not authorized', project_id: project.id) perform! end @@ -354,7 +354,7 @@ end it 'logs the authorization' do - expect(Gitlab::AppLogger).to receive(:info).with(message: 'Pipeline not authorized', project_id: project.id, user_id: user.id) + expect(Gitlab::AppLogger).to receive(:info).with(message: 'Pipeline not authorized', project_id: project.id) perform! end -- GitLab