From 016624da35c136537fa292720f39ec871cfd842c Mon Sep 17 00:00:00 2001 From: c_fons Date: Wed, 22 Oct 2025 14:04:04 +0200 Subject: [PATCH 1/2] Rename shared examples from issue template EE: true Changelog: changed --- .../issue_templates/Geo Replicate a new Git repository type.md | 2 +- .gitlab/issue_templates/Geo Replicate a new blob type.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.gitlab/issue_templates/Geo Replicate a new Git repository type.md b/.gitlab/issue_templates/Geo Replicate a new Git repository type.md index 29fa092a091686..76e874a7b6f092 100644 --- a/.gitlab/issue_templates/Geo Replicate a new Git repository type.md +++ b/.gitlab/issue_templates/Geo Replicate a new Git repository type.md @@ -308,7 +308,7 @@ That's all of the required database changes. - [ ] Add the following shared examples to `ee/spec/models/ee/cool_widget_spec.rb`: ```ruby - include_examples 'a verifiable model with a separate table for verification state' do + include_examples 'a verifiable model for verification state' do let(:verifiable_model_record) { build(:cool_widget) } # add extra params if needed to make sure the record is in `Geo::ReplicableModel.verifiables` scope let(:unverifiable_model_record) { build(:cool_widget) } # add extra params if needed to make sure the record is NOT included in `Geo::ReplicableModel.verifiables` scope end diff --git a/.gitlab/issue_templates/Geo Replicate a new blob type.md b/.gitlab/issue_templates/Geo Replicate a new blob type.md index c83ef9a4f3ee5a..8815557fb11dae 100644 --- a/.gitlab/issue_templates/Geo Replicate a new blob type.md +++ b/.gitlab/issue_templates/Geo Replicate a new blob type.md @@ -305,7 +305,7 @@ That's all of the required database changes. - [ ] Add the following shared examples to `ee/spec/models/ee/cool_widget_spec.rb`: ```ruby - include_examples 'a verifiable model with a separate table for verification state' do + include_examples 'a verifiable model for verification state' do let(:verifiable_model_record) { build(:cool_widget) } # add extra params if needed to make sure the record is in `Geo::ReplicableModel.verifiables` scope let(:unverifiable_model_record) { build(:cool_widget) } # add extra params if needed to make sure the record is NOT included in `Geo::ReplicableModel.verifiables` scope end -- GitLab From 3ef22e2c2ca1615627c39c1be461968eb3f461a9 Mon Sep 17 00:00:00 2001 From: c_fons Date: Wed, 22 Oct 2025 14:07:34 +0200 Subject: [PATCH 2/2] Remove useless scopes --- ee/app/models/ee/packages/nuget/symbol.rb | 2 -- 1 file changed, 2 deletions(-) diff --git a/ee/app/models/ee/packages/nuget/symbol.rb b/ee/app/models/ee/packages/nuget/symbol.rb index 2f3d98753f2177..7be25eeee18b53 100644 --- a/ee/app/models/ee/packages/nuget/symbol.rb +++ b/ee/app/models/ee/packages/nuget/symbol.rb @@ -19,8 +19,6 @@ module Symbol after_save :save_verification_details - scope :available_replicables, -> { all } - scope :available_verifiables, -> { joins(:packages_nuget_symbol_state) } scope :project_id_in, ->(ids) { where(project_id: ids) } scope :with_verification_state, ->(state) { -- GitLab