From c2a3514b8df0b7072252134232e74c55acbe62a5 Mon Sep 17 00:00:00 2001 From: Tomas Bulva Date: Wed, 22 Oct 2025 16:07:21 +0200 Subject: [PATCH] Fix duo_side_rail feature flag availability and socket cleanup Remove the only: :show restriction on the duo_side_rail feature flag to make it available across all controller actions, not just show actions. Also remove the cleanupSocket() call in beforeDestroy hook which was orphaned. - Remove action restriction from duo_side_rail feature flag - Remove cleanupSocket() call in Tanuki bot beforeDestroy lifecycle hook --- app/controllers/application_controller.rb | 2 +- ee/app/assets/javascripts/ai/tanuki_bot/components/app.vue | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index bb559e12f08736..18767018b525e7 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -45,7 +45,7 @@ class ApplicationController < BaseActionController before_action :set_usage_stats_consent_flag before_action :check_impersonation_availability before_action :increment_http_router_metrics - before_action only: :show do + before_action if: :html_request? do push_frontend_feature_flag(:duo_side_rail, current_user) end diff --git a/ee/app/assets/javascripts/ai/tanuki_bot/components/app.vue b/ee/app/assets/javascripts/ai/tanuki_bot/components/app.vue index 9b099fc412e2c1..0f09dbc43d1dc9 100644 --- a/ee/app/assets/javascripts/ai/tanuki_bot/components/app.vue +++ b/ee/app/assets/javascripts/ai/tanuki_bot/components/app.vue @@ -97,7 +97,6 @@ export default { beforeDestroy() { // Remove the event listener when the component is destroyed window.removeEventListener('resize', this.onWindowResize); - this.cleanupSocket(); }, methods: { setDimensions() { -- GitLab