From e910eb61a7136741c1c7a034cf01166a58b29630 Mon Sep 17 00:00:00 2001 From: treagitlab Date: Wed, 22 Oct 2025 10:50:20 -0700 Subject: [PATCH 1/2] Quarantine group::securityinfrastructure flaky specs --- ee/spec/graphql/types/vulnerability_type_spec.rb | 14 +++++++------- ee/spec/models/vulnerabilities/archive_spec.rb | 8 +++++--- .../vulnerabilities/external_issue_link_spec.rb | 3 ++- .../vulnerabilities/finding/evidence_spec.rb | 3 ++- .../vulnerabilities/finding_remediation_spec.rb | 3 ++- .../vulnerabilities/finding_signature_spec.rb | 3 ++- ee/spec/models/vulnerabilities/finding_spec.rb | 3 ++- .../vulnerabilities/historical_statistic_spec.rb | 3 ++- ee/spec/models/vulnerabilities/issue_link_spec.rb | 3 ++- .../vulnerabilities/merge_request_link_spec.rb | 3 ++- ee/spec/models/vulnerabilities/scanner_spec.rb | 3 ++- .../vulnerabilities/severity_override_spec.rb | 3 ++- ee/spec/models/vulnerability_user_mention_spec.rb | 3 ++- .../api/graphql/project/sbom/dependencies_spec.rb | 6 ++++-- 14 files changed, 38 insertions(+), 23 deletions(-) diff --git a/ee/spec/graphql/types/vulnerability_type_spec.rb b/ee/spec/graphql/types/vulnerability_type_spec.rb index 1b74d3f1015629..1e28512bb751ac 100644 --- a/ee/spec/graphql/types/vulnerability_type_spec.rb +++ b/ee/spec/graphql/types/vulnerability_type_spec.rb @@ -150,7 +150,7 @@ end end - describe 'has_remediations' do + describe 'has_remediations', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/534855' do let(:query_field) { 'hasRemediations' } context 'N+1 queries' do @@ -243,7 +243,7 @@ expect(vulnerabilities.first['primaryIdentifier']['externalId']).to eq(vulnerability.finding.primary_identifier.external_id) end - context "N+1 issues" do + context "N+1 issues", quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/546298' do single_query_count = 11 it_behaves_like "N+1 queries", single_query_count @@ -534,7 +534,7 @@ end end - context 'N+1 queries' do + context 'N+1 queries', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/546294' do single_query_count = 11 it_behaves_like "N+1 queries", single_query_count @@ -550,7 +550,7 @@ expect(vulnerabilities.first.dig('externalIssueLinks', 'edges').first.dig('node', 'id')).to eq(external_issue_link.to_global_id.to_s) end - context 'N+1 queries' do + context 'N+1 queries', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/546300' do single_query_count = 11 it_behaves_like "N+1 queries", single_query_count @@ -566,7 +566,7 @@ expect(vulnerabilities.first['links'].first['name']).to eq(finding_link.name) end - context 'N+1 queries' do + context 'N+1 queries', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/547390' do single_query_count = 11 it_behaves_like "N+1 queries", single_query_count @@ -624,7 +624,7 @@ end end - context 'N+1 queries' do + context 'N+1 queries', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/549933' do single_query_count = 11 it_behaves_like "N+1 queries", single_query_count @@ -653,7 +653,7 @@ end end - context 'N+1 queries' do + context 'N+1 queries', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/550360' do single_query_count = 11 it_behaves_like "N+1 queries", single_query_count diff --git a/ee/spec/models/vulnerabilities/archive_spec.rb b/ee/spec/models/vulnerabilities/archive_spec.rb index cd2be03cda2d3c..2ddfae1d63076f 100644 --- a/ee/spec/models/vulnerabilities/archive_spec.rb +++ b/ee/spec/models/vulnerabilities/archive_spec.rb @@ -5,9 +5,11 @@ RSpec.describe Vulnerabilities::Archive, feature_category: :vulnerability_management do subject(:archive) { build(:vulnerability_archive) } - it_behaves_like 'cleanup by a loose foreign key' do - let_it_be(:parent) { create(:project) } - let_it_be(:model) { create(:vulnerability_archive, project: parent) } + context 'with quarantine', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/527884' do + it_behaves_like 'cleanup by a loose foreign key' do + let_it_be(:parent) { create(:project) } + let_it_be(:model) { create(:vulnerability_archive, project: parent) } + end end it { is_expected.to belong_to(:project).required } diff --git a/ee/spec/models/vulnerabilities/external_issue_link_spec.rb b/ee/spec/models/vulnerabilities/external_issue_link_spec.rb index 84bf6d00f99531..66f2be7e0da2c4 100644 --- a/ee/spec/models/vulnerabilities/external_issue_link_spec.rb +++ b/ee/spec/models/vulnerabilities/external_issue_link_spec.rb @@ -54,7 +54,8 @@ end end - context 'with loose foreign key on vulnerabilities_external_issue_links.project_id' do + context 'with loose foreign key on vulnerabilities_external_issue_links.project_id', + quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/526543' do it_behaves_like 'cleanup by a loose foreign key' do let_it_be(:parent) { create(:project) } let_it_be(:model) { create(:vulnerabilities_external_issue_link, project_id: parent.id) } diff --git a/ee/spec/models/vulnerabilities/finding/evidence_spec.rb b/ee/spec/models/vulnerabilities/finding/evidence_spec.rb index 75d2cd77e68ae1..92f548799b7023 100644 --- a/ee/spec/models/vulnerabilities/finding/evidence_spec.rb +++ b/ee/spec/models/vulnerabilities/finding/evidence_spec.rb @@ -7,7 +7,8 @@ it { is_expected.to validate_length_of(:data).is_at_most(16_000_000) } it { is_expected.to belong_to(:finding).required } - context 'with loose foreign key on vulnerability_finding_evidences.project_id' do + context 'with loose foreign key on vulnerability_finding_evidences.project_id', + quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/531136' do it_behaves_like 'cleanup by a loose foreign key' do let_it_be(:parent) { create(:project) } let_it_be(:model) { create(:vulnerabilties_finding_evidence, project_id: parent.id) } diff --git a/ee/spec/models/vulnerabilities/finding_remediation_spec.rb b/ee/spec/models/vulnerabilities/finding_remediation_spec.rb index e07b39421b852d..7361b343bea7fc 100644 --- a/ee/spec/models/vulnerabilities/finding_remediation_spec.rb +++ b/ee/spec/models/vulnerabilities/finding_remediation_spec.rb @@ -15,7 +15,8 @@ it { is_expected.to eq(remediation.finding_remediations) } end - context 'with loose foreign key on vulnerability_findings_remediations.project_id' do + context 'with loose foreign key on vulnerability_findings_remediations.project_id', + quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/526104' do it_behaves_like 'cleanup by a loose foreign key' do let_it_be(:parent) { create(:project) } let_it_be(:finding_1) { create(:vulnerabilities_finding, project_id: parent.id) } diff --git a/ee/spec/models/vulnerabilities/finding_signature_spec.rb b/ee/spec/models/vulnerabilities/finding_signature_spec.rb index 607583a8717d0d..992ffe92a3ed0b 100644 --- a/ee/spec/models/vulnerabilities/finding_signature_spec.rb +++ b/ee/spec/models/vulnerabilities/finding_signature_spec.rb @@ -86,7 +86,8 @@ end end - context 'with loose foreign key on vulnerability_finding_signatures.project_id' do + context 'with loose foreign key on vulnerability_finding_signatures.project_id', + quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/526187' do it_behaves_like 'cleanup by a loose foreign key' do let_it_be(:parent) { create(:project) } let_it_be(:model) { create(:vulnerabilities_finding_signature, project_id: parent.id) } diff --git a/ee/spec/models/vulnerabilities/finding_spec.rb b/ee/spec/models/vulnerabilities/finding_spec.rb index cc834d51561c2a..3ce50d5d1fe8fd 100644 --- a/ee/spec/models/vulnerabilities/finding_spec.rb +++ b/ee/spec/models/vulnerabilities/finding_spec.rb @@ -1948,7 +1948,8 @@ def create_finding(state) end end - context 'with loose foreign key on vulnerability_occurrences.project_id' do + context 'with loose foreign key on vulnerability_occurrences.project_id', + quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/526594' do it_behaves_like 'cleanup by a loose foreign key' do let_it_be(:parent) { create(:project) } let_it_be(:model) { create(:vulnerabilities_finding, vulnerability_project: parent) } diff --git a/ee/spec/models/vulnerabilities/historical_statistic_spec.rb b/ee/spec/models/vulnerabilities/historical_statistic_spec.rb index fb6975cc4e2f20..323f41ab654466 100644 --- a/ee/spec/models/vulnerabilities/historical_statistic_spec.rb +++ b/ee/spec/models/vulnerabilities/historical_statistic_spec.rb @@ -96,7 +96,8 @@ it { is_expected.to match_array(expected_collection) } end - context 'with loose foreign key on vulnerability_historical_statistics.project_id' do + context 'with loose foreign key on vulnerability_historical_statistics.project_id', + quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/526741' do it_behaves_like 'cleanup by a loose foreign key' do let_it_be(:parent) { create(:project) } let_it_be(:model) { create(:vulnerability_historical_statistic, project: parent) } diff --git a/ee/spec/models/vulnerabilities/issue_link_spec.rb b/ee/spec/models/vulnerabilities/issue_link_spec.rb index bb0dab00adf240..962823b838cd79 100644 --- a/ee/spec/models/vulnerabilities/issue_link_spec.rb +++ b/ee/spec/models/vulnerabilities/issue_link_spec.rb @@ -123,7 +123,8 @@ end end - context 'with loose foreign key on vulnerabilities_issue_link.project_id' do + context 'with loose foreign key on vulnerabilities_issue_link.project_id', + quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/526546' do it_behaves_like 'cleanup by a loose foreign key' do let_it_be(:parent) { create(:project) } let_it_be(:model) { create(:vulnerabilities_issue_link, project_id: parent.id) } diff --git a/ee/spec/models/vulnerabilities/merge_request_link_spec.rb b/ee/spec/models/vulnerabilities/merge_request_link_spec.rb index 75c73b97eef4b1..eba1d82f5faaa9 100644 --- a/ee/spec/models/vulnerabilities/merge_request_link_spec.rb +++ b/ee/spec/models/vulnerabilities/merge_request_link_spec.rb @@ -112,7 +112,8 @@ end end - context 'with loose foreign key on vulnerability_merge_request_links.project_id' do + context 'with loose foreign key on vulnerability_merge_request_links.project_id', + quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/526296' do it_behaves_like 'cleanup by a loose foreign key' do let_it_be(:parent) { create(:project) } let_it_be(:model) { create(:vulnerabilities_merge_request_link, project_id: parent.id) } diff --git a/ee/spec/models/vulnerabilities/scanner_spec.rb b/ee/spec/models/vulnerabilities/scanner_spec.rb index ea5f19c11d0f2f..e016c97626346f 100644 --- a/ee/spec/models/vulnerabilities/scanner_spec.rb +++ b/ee/spec/models/vulnerabilities/scanner_spec.rb @@ -83,7 +83,8 @@ end end - context 'with loose foreign key on vulnerability_scanners.project_id' do + context 'with loose foreign key on vulnerability_scanners.project_id', + quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/526449' do it_behaves_like 'cleanup by a loose foreign key' do let_it_be(:parent) { create(:project) } let_it_be(:model) { create(:vulnerabilities_scanner, project: parent) } diff --git a/ee/spec/models/vulnerabilities/severity_override_spec.rb b/ee/spec/models/vulnerabilities/severity_override_spec.rb index f25a751c99c3c0..af3646b0528ace 100644 --- a/ee/spec/models/vulnerabilities/severity_override_spec.rb +++ b/ee/spec/models/vulnerabilities/severity_override_spec.rb @@ -58,7 +58,8 @@ end end - context 'with loose foreign key on vulnerability_severity_overrides.project_id' do + context 'with loose foreign key on vulnerability_severity_overrides.project_id', + quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/526135' do it_behaves_like 'cleanup by a loose foreign key' do let_it_be(:parent) { create(:project) } let_it_be(:model) { create(:vulnerability_severity_override, project_id: parent.id) } diff --git a/ee/spec/models/vulnerability_user_mention_spec.rb b/ee/spec/models/vulnerability_user_mention_spec.rb index 0eeba3b266beb0..16ba10d117289d 100644 --- a/ee/spec/models/vulnerability_user_mention_spec.rb +++ b/ee/spec/models/vulnerability_user_mention_spec.rb @@ -13,7 +13,8 @@ let_it_be(:mentionable) { create(:vulnerability) } end - context 'with loose foreign key on vulnerability_user_mentions.project_id' do + context 'with loose foreign key on vulnerability_user_mentions.project_id', + quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/526347' do it_behaves_like 'cleanup by a loose foreign key' do let_it_be(:parent) { create(:project) } let_it_be(:model) { create(:vulnerability_user_mention, project_id: parent.id) } diff --git a/ee/spec/requests/api/graphql/project/sbom/dependencies_spec.rb b/ee/spec/requests/api/graphql/project/sbom/dependencies_spec.rb index fbf56659d902a5..aed6c235299fc6 100644 --- a/ee/spec/requests/api/graphql/project/sbom/dependencies_spec.rb +++ b/ee/spec/requests/api/graphql/project/sbom/dependencies_spec.rb @@ -51,7 +51,9 @@ def package_manager_enum(value) subject { post_graphql(query, current_user: current_user, variables: variables) } - it_behaves_like 'sbom dependency node' + context 'with quarantine', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/545088' do + it_behaves_like 'sbom dependency node' + end it 'returns the expected dependency data with all fields' do subject @@ -161,7 +163,7 @@ def package_manager_enum(value) FIELDS end - it 'avoids N+1 database queries' do + it 'avoids N+1 database queries', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/567758' do parent = occurrences.first # create 1 occurrence and 1 graph path -- GitLab From 31e79a3e1b07a388d79c8687e065c57aa25d21ee Mon Sep 17 00:00:00 2001 From: Gregory Havenga <11164960-ghavenga@users.noreply.gitlab.com> Date: Thu, 23 Oct 2025 14:57:44 +0200 Subject: [PATCH 2/2] Remove quarantine from loose foreign key specs that are no longer flaky Based on feedback from @ghavenga, these loose foreign key specs stopped being flaky 6 months ago and are now just slow but stable. Removing quarantine to allow them to run normally. --- ee/spec/models/vulnerabilities/archive_spec.rb | 8 +++----- .../models/vulnerabilities/external_issue_link_spec.rb | 3 +-- ee/spec/models/vulnerabilities/finding/evidence_spec.rb | 3 +-- .../models/vulnerabilities/finding_remediation_spec.rb | 3 +-- ee/spec/models/vulnerabilities/finding_signature_spec.rb | 3 +-- ee/spec/models/vulnerabilities/finding_spec.rb | 3 +-- .../models/vulnerabilities/historical_statistic_spec.rb | 3 +-- ee/spec/models/vulnerabilities/issue_link_spec.rb | 3 +-- ee/spec/models/vulnerabilities/merge_request_link_spec.rb | 3 +-- ee/spec/models/vulnerabilities/scanner_spec.rb | 3 +-- ee/spec/models/vulnerabilities/severity_override_spec.rb | 3 +-- ee/spec/models/vulnerability_user_mention_spec.rb | 3 +-- 12 files changed, 14 insertions(+), 27 deletions(-) diff --git a/ee/spec/models/vulnerabilities/archive_spec.rb b/ee/spec/models/vulnerabilities/archive_spec.rb index 2ddfae1d63076f..cd2be03cda2d3c 100644 --- a/ee/spec/models/vulnerabilities/archive_spec.rb +++ b/ee/spec/models/vulnerabilities/archive_spec.rb @@ -5,11 +5,9 @@ RSpec.describe Vulnerabilities::Archive, feature_category: :vulnerability_management do subject(:archive) { build(:vulnerability_archive) } - context 'with quarantine', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/527884' do - it_behaves_like 'cleanup by a loose foreign key' do - let_it_be(:parent) { create(:project) } - let_it_be(:model) { create(:vulnerability_archive, project: parent) } - end + it_behaves_like 'cleanup by a loose foreign key' do + let_it_be(:parent) { create(:project) } + let_it_be(:model) { create(:vulnerability_archive, project: parent) } end it { is_expected.to belong_to(:project).required } diff --git a/ee/spec/models/vulnerabilities/external_issue_link_spec.rb b/ee/spec/models/vulnerabilities/external_issue_link_spec.rb index 66f2be7e0da2c4..84bf6d00f99531 100644 --- a/ee/spec/models/vulnerabilities/external_issue_link_spec.rb +++ b/ee/spec/models/vulnerabilities/external_issue_link_spec.rb @@ -54,8 +54,7 @@ end end - context 'with loose foreign key on vulnerabilities_external_issue_links.project_id', - quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/526543' do + context 'with loose foreign key on vulnerabilities_external_issue_links.project_id' do it_behaves_like 'cleanup by a loose foreign key' do let_it_be(:parent) { create(:project) } let_it_be(:model) { create(:vulnerabilities_external_issue_link, project_id: parent.id) } diff --git a/ee/spec/models/vulnerabilities/finding/evidence_spec.rb b/ee/spec/models/vulnerabilities/finding/evidence_spec.rb index 92f548799b7023..75d2cd77e68ae1 100644 --- a/ee/spec/models/vulnerabilities/finding/evidence_spec.rb +++ b/ee/spec/models/vulnerabilities/finding/evidence_spec.rb @@ -7,8 +7,7 @@ it { is_expected.to validate_length_of(:data).is_at_most(16_000_000) } it { is_expected.to belong_to(:finding).required } - context 'with loose foreign key on vulnerability_finding_evidences.project_id', - quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/531136' do + context 'with loose foreign key on vulnerability_finding_evidences.project_id' do it_behaves_like 'cleanup by a loose foreign key' do let_it_be(:parent) { create(:project) } let_it_be(:model) { create(:vulnerabilties_finding_evidence, project_id: parent.id) } diff --git a/ee/spec/models/vulnerabilities/finding_remediation_spec.rb b/ee/spec/models/vulnerabilities/finding_remediation_spec.rb index 7361b343bea7fc..e07b39421b852d 100644 --- a/ee/spec/models/vulnerabilities/finding_remediation_spec.rb +++ b/ee/spec/models/vulnerabilities/finding_remediation_spec.rb @@ -15,8 +15,7 @@ it { is_expected.to eq(remediation.finding_remediations) } end - context 'with loose foreign key on vulnerability_findings_remediations.project_id', - quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/526104' do + context 'with loose foreign key on vulnerability_findings_remediations.project_id' do it_behaves_like 'cleanup by a loose foreign key' do let_it_be(:parent) { create(:project) } let_it_be(:finding_1) { create(:vulnerabilities_finding, project_id: parent.id) } diff --git a/ee/spec/models/vulnerabilities/finding_signature_spec.rb b/ee/spec/models/vulnerabilities/finding_signature_spec.rb index 992ffe92a3ed0b..607583a8717d0d 100644 --- a/ee/spec/models/vulnerabilities/finding_signature_spec.rb +++ b/ee/spec/models/vulnerabilities/finding_signature_spec.rb @@ -86,8 +86,7 @@ end end - context 'with loose foreign key on vulnerability_finding_signatures.project_id', - quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/526187' do + context 'with loose foreign key on vulnerability_finding_signatures.project_id' do it_behaves_like 'cleanup by a loose foreign key' do let_it_be(:parent) { create(:project) } let_it_be(:model) { create(:vulnerabilities_finding_signature, project_id: parent.id) } diff --git a/ee/spec/models/vulnerabilities/finding_spec.rb b/ee/spec/models/vulnerabilities/finding_spec.rb index 3ce50d5d1fe8fd..cc834d51561c2a 100644 --- a/ee/spec/models/vulnerabilities/finding_spec.rb +++ b/ee/spec/models/vulnerabilities/finding_spec.rb @@ -1948,8 +1948,7 @@ def create_finding(state) end end - context 'with loose foreign key on vulnerability_occurrences.project_id', - quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/526594' do + context 'with loose foreign key on vulnerability_occurrences.project_id' do it_behaves_like 'cleanup by a loose foreign key' do let_it_be(:parent) { create(:project) } let_it_be(:model) { create(:vulnerabilities_finding, vulnerability_project: parent) } diff --git a/ee/spec/models/vulnerabilities/historical_statistic_spec.rb b/ee/spec/models/vulnerabilities/historical_statistic_spec.rb index 323f41ab654466..fb6975cc4e2f20 100644 --- a/ee/spec/models/vulnerabilities/historical_statistic_spec.rb +++ b/ee/spec/models/vulnerabilities/historical_statistic_spec.rb @@ -96,8 +96,7 @@ it { is_expected.to match_array(expected_collection) } end - context 'with loose foreign key on vulnerability_historical_statistics.project_id', - quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/526741' do + context 'with loose foreign key on vulnerability_historical_statistics.project_id' do it_behaves_like 'cleanup by a loose foreign key' do let_it_be(:parent) { create(:project) } let_it_be(:model) { create(:vulnerability_historical_statistic, project: parent) } diff --git a/ee/spec/models/vulnerabilities/issue_link_spec.rb b/ee/spec/models/vulnerabilities/issue_link_spec.rb index 962823b838cd79..bb0dab00adf240 100644 --- a/ee/spec/models/vulnerabilities/issue_link_spec.rb +++ b/ee/spec/models/vulnerabilities/issue_link_spec.rb @@ -123,8 +123,7 @@ end end - context 'with loose foreign key on vulnerabilities_issue_link.project_id', - quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/526546' do + context 'with loose foreign key on vulnerabilities_issue_link.project_id' do it_behaves_like 'cleanup by a loose foreign key' do let_it_be(:parent) { create(:project) } let_it_be(:model) { create(:vulnerabilities_issue_link, project_id: parent.id) } diff --git a/ee/spec/models/vulnerabilities/merge_request_link_spec.rb b/ee/spec/models/vulnerabilities/merge_request_link_spec.rb index eba1d82f5faaa9..75c73b97eef4b1 100644 --- a/ee/spec/models/vulnerabilities/merge_request_link_spec.rb +++ b/ee/spec/models/vulnerabilities/merge_request_link_spec.rb @@ -112,8 +112,7 @@ end end - context 'with loose foreign key on vulnerability_merge_request_links.project_id', - quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/526296' do + context 'with loose foreign key on vulnerability_merge_request_links.project_id' do it_behaves_like 'cleanup by a loose foreign key' do let_it_be(:parent) { create(:project) } let_it_be(:model) { create(:vulnerabilities_merge_request_link, project_id: parent.id) } diff --git a/ee/spec/models/vulnerabilities/scanner_spec.rb b/ee/spec/models/vulnerabilities/scanner_spec.rb index e016c97626346f..ea5f19c11d0f2f 100644 --- a/ee/spec/models/vulnerabilities/scanner_spec.rb +++ b/ee/spec/models/vulnerabilities/scanner_spec.rb @@ -83,8 +83,7 @@ end end - context 'with loose foreign key on vulnerability_scanners.project_id', - quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/526449' do + context 'with loose foreign key on vulnerability_scanners.project_id' do it_behaves_like 'cleanup by a loose foreign key' do let_it_be(:parent) { create(:project) } let_it_be(:model) { create(:vulnerabilities_scanner, project: parent) } diff --git a/ee/spec/models/vulnerabilities/severity_override_spec.rb b/ee/spec/models/vulnerabilities/severity_override_spec.rb index af3646b0528ace..f25a751c99c3c0 100644 --- a/ee/spec/models/vulnerabilities/severity_override_spec.rb +++ b/ee/spec/models/vulnerabilities/severity_override_spec.rb @@ -58,8 +58,7 @@ end end - context 'with loose foreign key on vulnerability_severity_overrides.project_id', - quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/526135' do + context 'with loose foreign key on vulnerability_severity_overrides.project_id' do it_behaves_like 'cleanup by a loose foreign key' do let_it_be(:parent) { create(:project) } let_it_be(:model) { create(:vulnerability_severity_override, project_id: parent.id) } diff --git a/ee/spec/models/vulnerability_user_mention_spec.rb b/ee/spec/models/vulnerability_user_mention_spec.rb index 16ba10d117289d..0eeba3b266beb0 100644 --- a/ee/spec/models/vulnerability_user_mention_spec.rb +++ b/ee/spec/models/vulnerability_user_mention_spec.rb @@ -13,8 +13,7 @@ let_it_be(:mentionable) { create(:vulnerability) } end - context 'with loose foreign key on vulnerability_user_mentions.project_id', - quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/526347' do + context 'with loose foreign key on vulnerability_user_mentions.project_id' do it_behaves_like 'cleanup by a loose foreign key' do let_it_be(:parent) { create(:project) } let_it_be(:model) { create(:vulnerability_user_mention, project_id: parent.id) } -- GitLab