From 415b2ea71bad48c8e4a19b70929f8195d85d5038 Mon Sep 17 00:00:00 2001 From: ddavison Date: Wed, 19 Feb 2020 07:18:44 -0800 Subject: [PATCH] Consider a Quality reviewer for frontend changes Add expected categories for test --- lib/gitlab/danger/helper.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/gitlab/danger/helper.rb b/lib/gitlab/danger/helper.rb index 3c3f95e5b7877d..38d26b10347698 100644 --- a/lib/gitlab/danger/helper.rb +++ b/lib/gitlab/danger/helper.rb @@ -93,7 +93,7 @@ def label_for_category(category) docs: "~documentation", # Docs are reviewed along DevOps stages, so don't need roulette for now. none: "", qa: "~QA", - test: "~test ~Quality for `spec/features/*`", + test: "~test ~Quality for `spec/features/*` or `spec/frontend/*`", engineering_productivity: '~"Engineering Productivity" for CI, Danger' }.freeze CATEGORIES = { @@ -140,7 +140,7 @@ def label_for_category(category) %r{\A(ee/)?app/(?!assets|views)[^/]+} => :backend, %r{\A(ee/)?(bin|config|generator_templates|lib|rubocop)/} => :backend, - %r{\A(ee/)?spec/features/} => :test, + %r{\A(ee/)?spec/(features|frontend)/} => :test, %r{\A(ee/)?spec/(?!javascripts|frontend)[^/]+} => :backend, %r{\A(ee/)?vendor/(?!assets)[^/]+} => :backend, %r{\A(ee/)?vendor/(languages\.yml|licenses\.csv)\z} => :backend, -- GitLab