From 720703edd4118d5137e987004d0196af32555095 Mon Sep 17 00:00:00 2001
From: Martin Hobert <info@dosh.dk>
Date: Thu, 30 Jan 2020 22:43:47 +0100
Subject: [PATCH 1/4] Added tracking to next discussion buttons

---
 .../javascripts/notes/components/discussion_counter.vue      | 3 +++
 .../notes/components/discussion_jump_to_next_button.vue      | 3 +++
 .../feature-199458-track-jump-to-next-unresolved-thread.yml  | 5 +++++
 3 files changed, 11 insertions(+)
 create mode 100644 changelogs/unreleased/feature-199458-track-jump-to-next-unresolved-thread.yml

diff --git a/app/assets/javascripts/notes/components/discussion_counter.vue b/app/assets/javascripts/notes/components/discussion_counter.vue
index 515d513e3ee855..577612de06a161 100644
--- a/app/assets/javascripts/notes/components/discussion_counter.vue
+++ b/app/assets/javascripts/notes/components/discussion_counter.vue
@@ -77,6 +77,9 @@ export default {
           v-gl-tooltip
           title="Jump to next unresolved thread"
           class="btn btn-default discussion-next-btn"
+          data-track-event="click_button"
+          data-track-label="mr_next_unresolved_thread"
+          data-track-property="click_next_unresolved_thread_top"
           @click="jumpToNextDiscussion"
         >
           <icon name="comment-next" />
diff --git a/app/assets/javascripts/notes/components/discussion_jump_to_next_button.vue b/app/assets/javascripts/notes/components/discussion_jump_to_next_button.vue
index e66abcfddbb5ec..b71ce1b6a0a219 100644
--- a/app/assets/javascripts/notes/components/discussion_jump_to_next_button.vue
+++ b/app/assets/javascripts/notes/components/discussion_jump_to_next_button.vue
@@ -28,6 +28,9 @@ export default {
       v-gl-tooltip
       class="btn btn-default discussion-next-btn"
       :title="s__('MergeRequests|Jump to next unresolved thread')"
+      data-track-event="click_button"
+      data-track-label="mr_next_unresolved_thread"
+      data-track-property="click_next_unresolved_thread"
       @click="jumpToNextRelativeDiscussion(fromDiscussionId)"
     >
       <icon name="comment-next" />
diff --git a/changelogs/unreleased/feature-199458-track-jump-to-next-unresolved-thread.yml b/changelogs/unreleased/feature-199458-track-jump-to-next-unresolved-thread.yml
new file mode 100644
index 00000000000000..5f55dbc4c506aa
--- /dev/null
+++ b/changelogs/unreleased/feature-199458-track-jump-to-next-unresolved-thread.yml
@@ -0,0 +1,5 @@
+---
+title: Added tracking to merge request jump to next thread buttons
+merge_request:
+author: Martin Hobert
+type: added
-- 
GitLab


From 1c900df55e07fdaa1ece43b553c7d996e28b4bff Mon Sep 17 00:00:00 2001
From: Thomas Randolph <trandolph@gitlab.com>
Date: Mon, 2 Mar 2020 16:15:32 -0700
Subject: [PATCH 2/4] Add merge request to the changelog

---
 .../feature-199458-track-jump-to-next-unresolved-thread.yml     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/changelogs/unreleased/feature-199458-track-jump-to-next-unresolved-thread.yml b/changelogs/unreleased/feature-199458-track-jump-to-next-unresolved-thread.yml
index 5f55dbc4c506aa..a34de5df008998 100644
--- a/changelogs/unreleased/feature-199458-track-jump-to-next-unresolved-thread.yml
+++ b/changelogs/unreleased/feature-199458-track-jump-to-next-unresolved-thread.yml
@@ -1,5 +1,5 @@
 ---
 title: Added tracking to merge request jump to next thread buttons
-merge_request:
+merge_request: 26319
 author: Martin Hobert
 type: added
-- 
GitLab


From 8e7dd1793ca7f0b0583145ec99eae25806addb2e Mon Sep 17 00:00:00 2001
From: Thomas Randolph <trandolph@gitlab.com>
Date: Mon, 2 Mar 2020 16:15:53 -0700
Subject: [PATCH 3/4] Update Jest snapshot to include new tracking data
 attributes

---
 .../__snapshots__/discussion_jump_to_next_button_spec.js.snap  | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/spec/frontend/notes/components/__snapshots__/discussion_jump_to_next_button_spec.js.snap b/spec/frontend/notes/components/__snapshots__/discussion_jump_to_next_button_spec.js.snap
index 2f4c114dd3d1b8..b1a718d58b5a1a 100644
--- a/spec/frontend/notes/components/__snapshots__/discussion_jump_to_next_button_spec.js.snap
+++ b/spec/frontend/notes/components/__snapshots__/discussion_jump_to_next_button_spec.js.snap
@@ -7,6 +7,9 @@ exports[`JumpToNextDiscussionButton matches the snapshot 1`] = `
 >
   <button
     class="btn btn-default discussion-next-btn"
+    data-track-event="click_button"
+    data-track-label="mr_next_unresolved_thread"
+    data-track-property="click_next_unresolved_thread"
     title="Jump to next unresolved thread"
   >
     <icon-stub
-- 
GitLab


From ff4ee180ca63fb885bf9ef5466a2c3cede8ce8ef Mon Sep 17 00:00:00 2001
From: Thomas Randolph <trandolph@gitlab.com>
Date: Tue, 3 Mar 2020 11:02:50 -0700
Subject: [PATCH 4/4] Test that snowplow is called with the correct information

---
 .../discussion_jump_to_next_button_spec.js    | 23 +++++++++++++++----
 1 file changed, 19 insertions(+), 4 deletions(-)

diff --git a/spec/frontend/notes/components/discussion_jump_to_next_button_spec.js b/spec/frontend/notes/components/discussion_jump_to_next_button_spec.js
index 2ff9dbc5c1996c..183966cf4357cd 100644
--- a/spec/frontend/notes/components/discussion_jump_to_next_button_spec.js
+++ b/spec/frontend/notes/components/discussion_jump_to_next_button_spec.js
@@ -1,14 +1,21 @@
 import { shallowMount } from '@vue/test-utils';
 import JumpToNextDiscussionButton from '~/notes/components/discussion_jump_to_next_button.vue';
+import { mockTracking } from '../../helpers/tracking_helper';
 
 describe('JumpToNextDiscussionButton', () => {
-  let wrapper;
   const fromDiscussionId = 'abc123';
+  let wrapper;
+  let trackingSpy;
+  let jumpFn;
 
   beforeEach(() => {
+    jumpFn = jest.fn();
     wrapper = shallowMount(JumpToNextDiscussionButton, {
       propsData: { fromDiscussionId },
     });
+    wrapper.setMethods({ jumpToNextRelativeDiscussion: jumpFn });
+
+    trackingSpy = mockTracking('_category_', wrapper.element, jest.spyOn);
   });
 
   afterEach(() => {
@@ -20,9 +27,17 @@ describe('JumpToNextDiscussionButton', () => {
   });
 
   it('calls jumpToNextRelativeDiscussion when clicked', () => {
-    const jumpToNextRelativeDiscussion = jest.fn();
-    wrapper.setMethods({ jumpToNextRelativeDiscussion });
     wrapper.find({ ref: 'button' }).trigger('click');
-    expect(jumpToNextRelativeDiscussion).toHaveBeenCalledWith(fromDiscussionId);
+
+    expect(jumpFn).toHaveBeenCalledWith(fromDiscussionId);
+  });
+
+  it('sends the correct tracking event when clicked', () => {
+    wrapper.find({ ref: 'button' }).trigger('click');
+
+    expect(trackingSpy).toHaveBeenCalledWith('_category_', 'click_button', {
+      label: 'mr_next_unresolved_thread',
+      property: 'click_next_unresolved_thread',
+    });
   });
 });
-- 
GitLab