From 55be60b8f583fccbc2b50b7fd965cf7c01faec0f Mon Sep 17 00:00:00 2001 From: Alexandru Croitor Date: Mon, 29 Jun 2020 14:45:17 +0300 Subject: [PATCH] Test the project import on review app Test project import on review app in order to be able to make some quick changes and see if I can reproduce the user mentions issue --- app/models/concerns/mentionable.rb | 2 -- changelogs/unreleased/review-app-for-master.yml | 5 +++++ .../shared_examples/models/mentionable_shared_examples.rb | 4 ---- 3 files changed, 5 insertions(+), 6 deletions(-) create mode 100644 changelogs/unreleased/review-app-for-master.yml diff --git a/app/models/concerns/mentionable.rb b/app/models/concerns/mentionable.rb index 7b4485376d4ed6..202d13b920c945 100644 --- a/app/models/concerns/mentionable.rb +++ b/app/models/concerns/mentionable.rb @@ -86,8 +86,6 @@ def store_mentions! # successful if mentionable.save is successful. # # This line will get removed when we remove the feature flag. - return true unless store_mentioned_users_to_db_enabled? - refs = all_references(self.author) references = {} diff --git a/changelogs/unreleased/review-app-for-master.yml b/changelogs/unreleased/review-app-for-master.yml new file mode 100644 index 00000000000000..83f8c019d210db --- /dev/null +++ b/changelogs/unreleased/review-app-for-master.yml @@ -0,0 +1,5 @@ +--- +title: testing +merge_request: +author: +type: fixed diff --git a/spec/support/shared_examples/models/mentionable_shared_examples.rb b/spec/support/shared_examples/models/mentionable_shared_examples.rb index dda5fa37b26578..dfd9b438ca933a 100644 --- a/spec/support/shared_examples/models/mentionable_shared_examples.rb +++ b/spec/support/shared_examples/models/mentionable_shared_examples.rb @@ -217,10 +217,6 @@ let(:user) { create(:user) } let(:mentionable) { create(mentionable_type, description: "#{user.to_reference} some description") } - it 'stores no mentions' do - expect(mentionable.user_mentions.count).to eq 0 - end - it 'renders description_html correctly' do expect(mentionable.description_html).to include("