From 9fb3cfa9095690125d1ef125d6ce533e887f5aaf Mon Sep 17 00:00:00 2001 From: Thomas Randolph Date: Mon, 25 Jul 2022 15:50:57 -0600 Subject: [PATCH 1/5] Add the Code Quality widget as a known widget --- .../merge_request_widget_extension_counter.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/gitlab/usage_data_counters/merge_request_widget_extension_counter.rb b/lib/gitlab/usage_data_counters/merge_request_widget_extension_counter.rb index 6a0731ba5ab2bf..e56342039326a3 100644 --- a/lib/gitlab/usage_data_counters/merge_request_widget_extension_counter.rb +++ b/lib/gitlab/usage_data_counters/merge_request_widget_extension_counter.rb @@ -5,7 +5,7 @@ module UsageDataCounters class MergeRequestWidgetExtensionCounter < BaseCounter KNOWN_EVENTS = %w[view full_report_clicked expand expand_success expand_warning expand_failed].freeze PREFIX = 'i_code_review_merge_request_widget' - WIDGETS = %w[accessibility test_summary].freeze + WIDGETS = %w[accessibility code_quality test_summary].freeze class << self private -- GitLab From fa10da99ee3579c26090c947e167af1fafaad7c0 Mon Sep 17 00:00:00 2001 From: Thomas Randolph Date: Tue, 26 Jul 2022 20:02:29 -0600 Subject: [PATCH 2/5] Add metrics for every total/sum (regular) redis counter --- ...request_widget_code_quality_count_view.yml | 24 +++++++++++++++++++ ...code_quality_count_full_report_clicked.yml | 24 +++++++++++++++++++ ...quest_widget_code_quality_count_expand.yml | 24 +++++++++++++++++++ ...dget_code_quality_count_expand_success.yml | 24 +++++++++++++++++++ ...dget_code_quality_count_expand_warning.yml | 24 +++++++++++++++++++ ...idget_code_quality_count_expand_failed.yml | 24 +++++++++++++++++++ 6 files changed, 144 insertions(+) create mode 100644 config/metrics/counts_all/20220727004434_i_code_review_merge_request_widget_code_quality_count_view.yml create mode 100644 config/metrics/counts_all/20220727004440_i_code_review_merge_request_widget_code_quality_count_full_report_clicked.yml create mode 100644 config/metrics/counts_all/20220727004446_i_code_review_merge_request_widget_code_quality_count_expand.yml create mode 100644 config/metrics/counts_all/20220727004451_i_code_review_merge_request_widget_code_quality_count_expand_success.yml create mode 100644 config/metrics/counts_all/20220727004457_i_code_review_merge_request_widget_code_quality_count_expand_warning.yml create mode 100644 config/metrics/counts_all/20220727004502_i_code_review_merge_request_widget_code_quality_count_expand_failed.yml diff --git a/config/metrics/counts_all/20220727004434_i_code_review_merge_request_widget_code_quality_count_view.yml b/config/metrics/counts_all/20220727004434_i_code_review_merge_request_widget_code_quality_count_view.yml new file mode 100644 index 00000000000000..7abca8d9883672 --- /dev/null +++ b/config/metrics/counts_all/20220727004434_i_code_review_merge_request_widget_code_quality_count_view.yml @@ -0,0 +1,24 @@ +--- +key_path: counts.i_code_review_merge_request_widget_code_quality_count_view +description: Total number of times the Code Quality widget extension was viewed (rendered to the screen) +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +time_frame: all +data_source: redis +data_category: optional +options: + events: + - i_code_review_merge_request_widget_code_quality_count_view +distribution: +- ce +- ee +tier: +- free +- premium +- ultimate diff --git a/config/metrics/counts_all/20220727004440_i_code_review_merge_request_widget_code_quality_count_full_report_clicked.yml b/config/metrics/counts_all/20220727004440_i_code_review_merge_request_widget_code_quality_count_full_report_clicked.yml new file mode 100644 index 00000000000000..34868a531d2c15 --- /dev/null +++ b/config/metrics/counts_all/20220727004440_i_code_review_merge_request_widget_code_quality_count_full_report_clicked.yml @@ -0,0 +1,24 @@ +--- +key_path: counts.i_code_review_merge_request_widget_code_quality_count_full_report_clicked +description: Total number of times the Code Quality widget extension Full Report button was clicked +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +time_frame: all +data_source: redis +data_category: optional +options: + events: + - i_code_review_merge_request_widget_code_quality_count_full_report_clicked +distribution: +- ce +- ee +tier: +- free +- premium +- ultimate diff --git a/config/metrics/counts_all/20220727004446_i_code_review_merge_request_widget_code_quality_count_expand.yml b/config/metrics/counts_all/20220727004446_i_code_review_merge_request_widget_code_quality_count_expand.yml new file mode 100644 index 00000000000000..1e3a51efe88369 --- /dev/null +++ b/config/metrics/counts_all/20220727004446_i_code_review_merge_request_widget_code_quality_count_expand.yml @@ -0,0 +1,24 @@ +--- +key_path: counts.i_code_review_merge_request_widget_code_quality_count_expand +description: Total number of times the Code Quality widget extension was expanded (in any state) +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +time_frame: all +data_source: redis +data_category: optional +options: + events: + - i_code_review_merge_request_widget_code_quality_count_expand +distribution: +- ce +- ee +tier: +- free +- premium +- ultimate diff --git a/config/metrics/counts_all/20220727004451_i_code_review_merge_request_widget_code_quality_count_expand_success.yml b/config/metrics/counts_all/20220727004451_i_code_review_merge_request_widget_code_quality_count_expand_success.yml new file mode 100644 index 00000000000000..2c3c1ababa3b5e --- /dev/null +++ b/config/metrics/counts_all/20220727004451_i_code_review_merge_request_widget_code_quality_count_expand_success.yml @@ -0,0 +1,24 @@ +--- +key_path: counts.i_code_review_merge_request_widget_code_quality_count_expand_success +description: Total number of times the Code Quality widget extension was expanded (while in its Success state) +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +time_frame: all +data_source: redis +data_category: optional +options: + events: + - i_code_review_merge_request_widget_code_quality_count_expand_success +distribution: +- ce +- ee +tier: +- free +- premium +- ultimate diff --git a/config/metrics/counts_all/20220727004457_i_code_review_merge_request_widget_code_quality_count_expand_warning.yml b/config/metrics/counts_all/20220727004457_i_code_review_merge_request_widget_code_quality_count_expand_warning.yml new file mode 100644 index 00000000000000..756dbfbb0c9830 --- /dev/null +++ b/config/metrics/counts_all/20220727004457_i_code_review_merge_request_widget_code_quality_count_expand_warning.yml @@ -0,0 +1,24 @@ +--- +key_path: counts.i_code_review_merge_request_widget_code_quality_count_expand_warning +description: Total number of times the Code Quality widget extension was expanded (while in its Warning state) +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +time_frame: all +data_source: redis +data_category: optional +options: + events: + - i_code_review_merge_request_widget_code_quality_count_expand_warning +distribution: +- ce +- ee +tier: +- free +- premium +- ultimate diff --git a/config/metrics/counts_all/20220727004502_i_code_review_merge_request_widget_code_quality_count_expand_failed.yml b/config/metrics/counts_all/20220727004502_i_code_review_merge_request_widget_code_quality_count_expand_failed.yml new file mode 100644 index 00000000000000..ba40ef8924dbb3 --- /dev/null +++ b/config/metrics/counts_all/20220727004502_i_code_review_merge_request_widget_code_quality_count_expand_failed.yml @@ -0,0 +1,24 @@ +--- +key_path: counts.i_code_review_merge_request_widget_code_quality_count_expand_failed +description: Total number of times the Code Quality widget extension was expanded (while in its Failed state) +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +time_frame: all +data_source: redis +data_category: optional +options: + events: + - i_code_review_merge_request_widget_code_quality_count_expand_failed +distribution: +- ce +- ee +tier: +- free +- premium +- ultimate -- GitLab From a148151ecd4d39719b383e8024fdfa7ef91481d5 Mon Sep 17 00:00:00 2001 From: Thomas Randolph Date: Tue, 26 Jul 2022 20:17:07 -0600 Subject: [PATCH 3/5] Add metrics for every unique user (hll) redis counter --- ...quest_widget_code_quality_view_monthly.yml | 25 +++++++++++++++++++ ...de_quality_full_report_clicked_monthly.yml | 25 +++++++++++++++++++ ...est_widget_code_quality_expand_monthly.yml | 25 +++++++++++++++++++ ...et_code_quality_expand_success_monthly.yml | 25 +++++++++++++++++++ ...et_code_quality_expand_warning_monthly.yml | 25 +++++++++++++++++++ ...get_code_quality_expand_failed_monthly.yml | 25 +++++++++++++++++++ ...equest_widget_code_quality_view_weekly.yml | 25 +++++++++++++++++++ ...ode_quality_full_report_clicked_weekly.yml | 25 +++++++++++++++++++ ...uest_widget_code_quality_expand_weekly.yml | 25 +++++++++++++++++++ ...get_code_quality_expand_success_weekly.yml | 25 +++++++++++++++++++ ...get_code_quality_expand_warning_weekly.yml | 25 +++++++++++++++++++ ...dget_code_quality_expand_failed_weekly.yml | 25 +++++++++++++++++++ 12 files changed, 300 insertions(+) create mode 100644 config/metrics/counts_28d/20220727020440_i_code_review_merge_request_widget_code_quality_view_monthly.yml create mode 100644 config/metrics/counts_28d/20220727020446_i_code_review_merge_request_widget_code_quality_full_report_clicked_monthly.yml create mode 100644 config/metrics/counts_28d/20220727020452_i_code_review_merge_request_widget_code_quality_expand_monthly.yml create mode 100644 config/metrics/counts_28d/20220727020457_i_code_review_merge_request_widget_code_quality_expand_success_monthly.yml create mode 100644 config/metrics/counts_28d/20220727020503_i_code_review_merge_request_widget_code_quality_expand_warning_monthly.yml create mode 100644 config/metrics/counts_28d/20220727020509_i_code_review_merge_request_widget_code_quality_expand_failed_monthly.yml create mode 100644 config/metrics/counts_7d/20220727020407_i_code_review_merge_request_widget_code_quality_view_weekly.yml create mode 100644 config/metrics/counts_7d/20220727020413_i_code_review_merge_request_widget_code_quality_full_report_clicked_weekly.yml create mode 100644 config/metrics/counts_7d/20220727020419_i_code_review_merge_request_widget_code_quality_expand_weekly.yml create mode 100644 config/metrics/counts_7d/20220727020424_i_code_review_merge_request_widget_code_quality_expand_success_weekly.yml create mode 100644 config/metrics/counts_7d/20220727020429_i_code_review_merge_request_widget_code_quality_expand_warning_weekly.yml create mode 100644 config/metrics/counts_7d/20220727020435_i_code_review_merge_request_widget_code_quality_expand_failed_weekly.yml diff --git a/config/metrics/counts_28d/20220727020440_i_code_review_merge_request_widget_code_quality_view_monthly.yml b/config/metrics/counts_28d/20220727020440_i_code_review_merge_request_widget_code_quality_view_monthly.yml new file mode 100644 index 00000000000000..fdc4b9d09e5ad9 --- /dev/null +++ b/config/metrics/counts_28d/20220727020440_i_code_review_merge_request_widget_code_quality_view_monthly.yml @@ -0,0 +1,25 @@ +--- +key_path: redis_hll_counters.code_review.i_code_review_merge_request_widget_code_quality_view_monthly +description: The count of unique users (monthly) who were able to see the Code Quality widget extension +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +time_frame: 28d +data_source: redis_hll +data_category: optional +instrumentation_class: RedisHLLMetric +options: + events: + - i_code_review_merge_request_widget_code_quality_view +distribution: +- ce +- ee +tier: +- free +- premium +- ultimate diff --git a/config/metrics/counts_28d/20220727020446_i_code_review_merge_request_widget_code_quality_full_report_clicked_monthly.yml b/config/metrics/counts_28d/20220727020446_i_code_review_merge_request_widget_code_quality_full_report_clicked_monthly.yml new file mode 100644 index 00000000000000..ab310fbe7ac460 --- /dev/null +++ b/config/metrics/counts_28d/20220727020446_i_code_review_merge_request_widget_code_quality_full_report_clicked_monthly.yml @@ -0,0 +1,25 @@ +--- +key_path: redis_hll_counters.code_review.i_code_review_merge_request_widget_code_quality_full_report_clicked_monthly +description: The count of unique users (monthly) who clicked the Full Report button on the Code Quality widget extension +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +time_frame: 28d +data_source: redis_hll +data_category: optional +instrumentation_class: RedisHLLMetric +options: + events: + - i_code_review_merge_request_widget_code_quality_full_report_clicked +distribution: +- ce +- ee +tier: +- free +- premium +- ultimate diff --git a/config/metrics/counts_28d/20220727020452_i_code_review_merge_request_widget_code_quality_expand_monthly.yml b/config/metrics/counts_28d/20220727020452_i_code_review_merge_request_widget_code_quality_expand_monthly.yml new file mode 100644 index 00000000000000..898b8811a99af3 --- /dev/null +++ b/config/metrics/counts_28d/20220727020452_i_code_review_merge_request_widget_code_quality_expand_monthly.yml @@ -0,0 +1,25 @@ +--- +key_path: redis_hll_counters.code_review.i_code_review_merge_request_widget_code_quality_expand_monthly +description: The count of unique users (monthly) who expanded the Code Quality widget extension +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +time_frame: 28d +data_source: redis_hll +data_category: optional +instrumentation_class: RedisHLLMetric +options: + events: + - i_code_review_merge_request_widget_code_quality_expand +distribution: +- ce +- ee +tier: +- free +- premium +- ultimate diff --git a/config/metrics/counts_28d/20220727020457_i_code_review_merge_request_widget_code_quality_expand_success_monthly.yml b/config/metrics/counts_28d/20220727020457_i_code_review_merge_request_widget_code_quality_expand_success_monthly.yml new file mode 100644 index 00000000000000..20f876b465db2d --- /dev/null +++ b/config/metrics/counts_28d/20220727020457_i_code_review_merge_request_widget_code_quality_expand_success_monthly.yml @@ -0,0 +1,25 @@ +--- +key_path: redis_hll_counters.code_review.i_code_review_merge_request_widget_code_quality_expand_success_monthly +description: The count of unique users (monthly) who expanded the Code Quality widget extension while it is in its Success state +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +time_frame: 28d +data_source: redis_hll +data_category: optional +instrumentation_class: RedisHLLMetric +options: + events: + - i_code_review_merge_request_widget_code_quality_expand_success +distribution: +- ce +- ee +tier: +- free +- premium +- ultimate diff --git a/config/metrics/counts_28d/20220727020503_i_code_review_merge_request_widget_code_quality_expand_warning_monthly.yml b/config/metrics/counts_28d/20220727020503_i_code_review_merge_request_widget_code_quality_expand_warning_monthly.yml new file mode 100644 index 00000000000000..79a80b21bcc29b --- /dev/null +++ b/config/metrics/counts_28d/20220727020503_i_code_review_merge_request_widget_code_quality_expand_warning_monthly.yml @@ -0,0 +1,25 @@ +--- +key_path: redis_hll_counters.code_review.i_code_review_merge_request_widget_code_quality_expand_warning_monthly +description: The count of unique users (monthly) who expanded the Code Quality widget extension while it is in its Warning state +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +time_frame: 28d +data_source: redis_hll +data_category: optional +instrumentation_class: RedisHLLMetric +options: + events: + - i_code_review_merge_request_widget_code_quality_expand_warning +distribution: +- ce +- ee +tier: +- free +- premium +- ultimate diff --git a/config/metrics/counts_28d/20220727020509_i_code_review_merge_request_widget_code_quality_expand_failed_monthly.yml b/config/metrics/counts_28d/20220727020509_i_code_review_merge_request_widget_code_quality_expand_failed_monthly.yml new file mode 100644 index 00000000000000..60b8e4ff2f0eb1 --- /dev/null +++ b/config/metrics/counts_28d/20220727020509_i_code_review_merge_request_widget_code_quality_expand_failed_monthly.yml @@ -0,0 +1,25 @@ +--- +key_path: redis_hll_counters.code_review.i_code_review_merge_request_widget_code_quality_expand_failed_monthly +description: The count of unique users (monthly) who expanded the Code Quality widget extension while it is in its Failed state +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +time_frame: 28d +data_source: redis_hll +data_category: optional +instrumentation_class: RedisHLLMetric +options: + events: + - i_code_review_merge_request_widget_code_quality_expand_failed +distribution: +- ce +- ee +tier: +- free +- premium +- ultimate diff --git a/config/metrics/counts_7d/20220727020407_i_code_review_merge_request_widget_code_quality_view_weekly.yml b/config/metrics/counts_7d/20220727020407_i_code_review_merge_request_widget_code_quality_view_weekly.yml new file mode 100644 index 00000000000000..ac5a9609b556cf --- /dev/null +++ b/config/metrics/counts_7d/20220727020407_i_code_review_merge_request_widget_code_quality_view_weekly.yml @@ -0,0 +1,25 @@ +--- +key_path: redis_hll_counters.code_review.i_code_review_merge_request_widget_code_quality_view_weekly +description: The count of unique users (weekly) who were able to see the Code Quality widget extension +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +time_frame: 7d +data_source: redis_hll +data_category: optional +instrumentation_class: RedisHLLMetric +options: + events: + - i_code_review_merge_request_widget_code_quality_view +distribution: +- ce +- ee +tier: +- free +- premium +- ultimate diff --git a/config/metrics/counts_7d/20220727020413_i_code_review_merge_request_widget_code_quality_full_report_clicked_weekly.yml b/config/metrics/counts_7d/20220727020413_i_code_review_merge_request_widget_code_quality_full_report_clicked_weekly.yml new file mode 100644 index 00000000000000..678f4431525fd5 --- /dev/null +++ b/config/metrics/counts_7d/20220727020413_i_code_review_merge_request_widget_code_quality_full_report_clicked_weekly.yml @@ -0,0 +1,25 @@ +--- +key_path: redis_hll_counters.code_review.i_code_review_merge_request_widget_code_quality_full_report_clicked_weekly +description: The count of unique users (weekly) who clicked the Full Report button on the Code Quality widget extension +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +time_frame: 7d +data_source: redis_hll +data_category: optional +instrumentation_class: RedisHLLMetric +options: + events: + - i_code_review_merge_request_widget_code_quality_full_report_clicked +distribution: +- ce +- ee +tier: +- free +- premium +- ultimate diff --git a/config/metrics/counts_7d/20220727020419_i_code_review_merge_request_widget_code_quality_expand_weekly.yml b/config/metrics/counts_7d/20220727020419_i_code_review_merge_request_widget_code_quality_expand_weekly.yml new file mode 100644 index 00000000000000..6fb5921593b42d --- /dev/null +++ b/config/metrics/counts_7d/20220727020419_i_code_review_merge_request_widget_code_quality_expand_weekly.yml @@ -0,0 +1,25 @@ +--- +key_path: redis_hll_counters.code_review.i_code_review_merge_request_widget_code_quality_expand_weekly +description: The count of unique users (weekly) who expanded the Code Quality widget extension +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +time_frame: 7d +data_source: redis_hll +data_category: optional +instrumentation_class: RedisHLLMetric +options: + events: + - i_code_review_merge_request_widget_code_quality_expand +distribution: +- ce +- ee +tier: +- free +- premium +- ultimate diff --git a/config/metrics/counts_7d/20220727020424_i_code_review_merge_request_widget_code_quality_expand_success_weekly.yml b/config/metrics/counts_7d/20220727020424_i_code_review_merge_request_widget_code_quality_expand_success_weekly.yml new file mode 100644 index 00000000000000..f406850391670a --- /dev/null +++ b/config/metrics/counts_7d/20220727020424_i_code_review_merge_request_widget_code_quality_expand_success_weekly.yml @@ -0,0 +1,25 @@ +--- +key_path: redis_hll_counters.code_review.i_code_review_merge_request_widget_code_quality_expand_success_weekly +description: The count of unique users (weekly) who expanded the Code Quality widget extension while it is in its Success state +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +time_frame: 7d +data_source: redis_hll +data_category: optional +instrumentation_class: RedisHLLMetric +options: + events: + - i_code_review_merge_request_widget_code_quality_expand_success +distribution: +- ce +- ee +tier: +- free +- premium +- ultimate diff --git a/config/metrics/counts_7d/20220727020429_i_code_review_merge_request_widget_code_quality_expand_warning_weekly.yml b/config/metrics/counts_7d/20220727020429_i_code_review_merge_request_widget_code_quality_expand_warning_weekly.yml new file mode 100644 index 00000000000000..ded66f3531feaf --- /dev/null +++ b/config/metrics/counts_7d/20220727020429_i_code_review_merge_request_widget_code_quality_expand_warning_weekly.yml @@ -0,0 +1,25 @@ +--- +key_path: redis_hll_counters.code_review.i_code_review_merge_request_widget_code_quality_expand_warning_weekly +description: The count of unique users (weekly) who expanded the Code Quality widget extension while it is in its Warning state +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +time_frame: 7d +data_source: redis_hll +data_category: optional +instrumentation_class: RedisHLLMetric +options: + events: + - i_code_review_merge_request_widget_code_quality_expand_warning +distribution: +- ce +- ee +tier: +- free +- premium +- ultimate diff --git a/config/metrics/counts_7d/20220727020435_i_code_review_merge_request_widget_code_quality_expand_failed_weekly.yml b/config/metrics/counts_7d/20220727020435_i_code_review_merge_request_widget_code_quality_expand_failed_weekly.yml new file mode 100644 index 00000000000000..c5b6bb6829e9b8 --- /dev/null +++ b/config/metrics/counts_7d/20220727020435_i_code_review_merge_request_widget_code_quality_expand_failed_weekly.yml @@ -0,0 +1,25 @@ +--- +key_path: redis_hll_counters.code_review.i_code_review_merge_request_widget_code_quality_expand_failed_weekly +description: The count of unique users (weekly) who expanded the Code Quality widget extension while it is in its Failed state +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +time_frame: 7d +data_source: redis_hll +data_category: optional +instrumentation_class: RedisHLLMetric +options: + events: + - i_code_review_merge_request_widget_code_quality_expand_failed +distribution: +- ce +- ee +tier: +- free +- premium +- ultimate -- GitLab From cce9b1250ab2d6ff25980da4517b724cce6ae0bf Mon Sep 17 00:00:00 2001 From: Thomas Randolph Date: Tue, 26 Jul 2022 20:20:14 -0600 Subject: [PATCH 4/5] Add the reported events to metrics yml files --- config/metrics/aggregates/code_review.yml | 12 +++++++++ .../known_events/code_review_events.yml | 25 +++++++++++++++++++ 2 files changed, 37 insertions(+) diff --git a/config/metrics/aggregates/code_review.yml b/config/metrics/aggregates/code_review.yml index 64f7825dce07fb..15ef2c06a01e70 100644 --- a/config/metrics/aggregates/code_review.yml +++ b/config/metrics/aggregates/code_review.yml @@ -92,6 +92,12 @@ - 'i_code_review_merge_request_widget_accessibility_expand_success' - 'i_code_review_merge_request_widget_accessibility_expand_warning' - 'i_code_review_merge_request_widget_accessibility_expand_failed' + - 'i_code_review_merge_request_widget_code_quality_view' + - 'i_code_review_merge_request_widget_code_quality_full_report_clicked' + - 'i_code_review_merge_request_widget_code_quality_expand' + - 'i_code_review_merge_request_widget_code_quality_expand_success' + - 'i_code_review_merge_request_widget_code_quality_expand_warning' + - 'i_code_review_merge_request_widget_code_quality_expand_failed' - name: code_review_category_monthly_active_users operator: OR source: redis @@ -172,6 +178,12 @@ - 'i_code_review_merge_request_widget_accessibility_expand_success' - 'i_code_review_merge_request_widget_accessibility_expand_warning' - 'i_code_review_merge_request_widget_accessibility_expand_failed' + - 'i_code_review_merge_request_widget_code_quality_view' + - 'i_code_review_merge_request_widget_code_quality_full_report_clicked' + - 'i_code_review_merge_request_widget_code_quality_expand' + - 'i_code_review_merge_request_widget_code_quality_expand_success' + - 'i_code_review_merge_request_widget_code_quality_expand_warning' + - 'i_code_review_merge_request_widget_code_quality_expand_failed' - name: code_review_extension_category_monthly_active_users operator: OR source: redis diff --git a/lib/gitlab/usage_data_counters/known_events/code_review_events.yml b/lib/gitlab/usage_data_counters/known_events/code_review_events.yml index d97d22ef8d3608..7adb45bc9fa66f 100644 --- a/lib/gitlab/usage_data_counters/known_events/code_review_events.yml +++ b/lib/gitlab/usage_data_counters/known_events/code_review_events.yml @@ -350,3 +350,28 @@ redis_slot: code_review category: code_review aggregation: weekly +## Code Quality +- name: i_code_review_merge_request_widget_code_quality_view + redis_slot: code_review + category: code_review + aggregation: weekly +- name: i_code_review_merge_request_widget_code_quality_full_report_clicked + redis_slot: code_review + category: code_review + aggregation: weekly +- name: i_code_review_merge_request_widget_code_quality_expand + redis_slot: code_review + category: code_review + aggregation: weekly +- name: i_code_review_merge_request_widget_code_quality_expand_success + redis_slot: code_review + category: code_review + aggregation: weekly +- name: i_code_review_merge_request_widget_code_quality_expand_warning + redis_slot: code_review + category: code_review + aggregation: weekly +- name: i_code_review_merge_request_widget_code_quality_expand_failed + redis_slot: code_review + category: code_review + aggregation: weekly -- GitLab From 13ab8a4447f7060cf2977915f2f145e37f443018 Mon Sep 17 00:00:00 2001 From: Thomas Randolph Date: Tue, 26 Jul 2022 20:34:59 -0600 Subject: [PATCH 5/5] Update the MR id now that it exists --- ...de_review_merge_request_widget_code_quality_view_monthly.yml | 2 +- ..._request_widget_code_quality_full_report_clicked_monthly.yml | 2 +- ..._review_merge_request_widget_code_quality_expand_monthly.yml | 2 +- ...merge_request_widget_code_quality_expand_success_monthly.yml | 2 +- ...merge_request_widget_code_quality_expand_warning_monthly.yml | 2 +- ..._merge_request_widget_code_quality_expand_failed_monthly.yml | 2 +- ...ode_review_merge_request_widget_code_quality_view_weekly.yml | 2 +- ...e_request_widget_code_quality_full_report_clicked_weekly.yml | 2 +- ...e_review_merge_request_widget_code_quality_expand_weekly.yml | 2 +- ..._merge_request_widget_code_quality_expand_success_weekly.yml | 2 +- ..._merge_request_widget_code_quality_expand_warning_weekly.yml | 2 +- ...w_merge_request_widget_code_quality_expand_failed_weekly.yml | 2 +- ...code_review_merge_request_widget_code_quality_count_view.yml | 2 +- ...ge_request_widget_code_quality_count_full_report_clicked.yml | 2 +- ...de_review_merge_request_widget_code_quality_count_expand.yml | 2 +- ...w_merge_request_widget_code_quality_count_expand_success.yml | 2 +- ...w_merge_request_widget_code_quality_count_expand_warning.yml | 2 +- ...ew_merge_request_widget_code_quality_count_expand_failed.yml | 2 +- 18 files changed, 18 insertions(+), 18 deletions(-) diff --git a/config/metrics/counts_28d/20220727020440_i_code_review_merge_request_widget_code_quality_view_monthly.yml b/config/metrics/counts_28d/20220727020440_i_code_review_merge_request_widget_code_quality_view_monthly.yml index fdc4b9d09e5ad9..a73f6a919eae2b 100644 --- a/config/metrics/counts_28d/20220727020440_i_code_review_merge_request_widget_code_quality_view_monthly.yml +++ b/config/metrics/counts_28d/20220727020440_i_code_review_merge_request_widget_code_quality_view_monthly.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/93333" time_frame: 28d data_source: redis_hll data_category: optional diff --git a/config/metrics/counts_28d/20220727020446_i_code_review_merge_request_widget_code_quality_full_report_clicked_monthly.yml b/config/metrics/counts_28d/20220727020446_i_code_review_merge_request_widget_code_quality_full_report_clicked_monthly.yml index ab310fbe7ac460..3fbd759deabe43 100644 --- a/config/metrics/counts_28d/20220727020446_i_code_review_merge_request_widget_code_quality_full_report_clicked_monthly.yml +++ b/config/metrics/counts_28d/20220727020446_i_code_review_merge_request_widget_code_quality_full_report_clicked_monthly.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/93333" time_frame: 28d data_source: redis_hll data_category: optional diff --git a/config/metrics/counts_28d/20220727020452_i_code_review_merge_request_widget_code_quality_expand_monthly.yml b/config/metrics/counts_28d/20220727020452_i_code_review_merge_request_widget_code_quality_expand_monthly.yml index 898b8811a99af3..3b4686c28cc7c3 100644 --- a/config/metrics/counts_28d/20220727020452_i_code_review_merge_request_widget_code_quality_expand_monthly.yml +++ b/config/metrics/counts_28d/20220727020452_i_code_review_merge_request_widget_code_quality_expand_monthly.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/93333" time_frame: 28d data_source: redis_hll data_category: optional diff --git a/config/metrics/counts_28d/20220727020457_i_code_review_merge_request_widget_code_quality_expand_success_monthly.yml b/config/metrics/counts_28d/20220727020457_i_code_review_merge_request_widget_code_quality_expand_success_monthly.yml index 20f876b465db2d..e36a74550d4e41 100644 --- a/config/metrics/counts_28d/20220727020457_i_code_review_merge_request_widget_code_quality_expand_success_monthly.yml +++ b/config/metrics/counts_28d/20220727020457_i_code_review_merge_request_widget_code_quality_expand_success_monthly.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/93333" time_frame: 28d data_source: redis_hll data_category: optional diff --git a/config/metrics/counts_28d/20220727020503_i_code_review_merge_request_widget_code_quality_expand_warning_monthly.yml b/config/metrics/counts_28d/20220727020503_i_code_review_merge_request_widget_code_quality_expand_warning_monthly.yml index 79a80b21bcc29b..181c06ec06f2e1 100644 --- a/config/metrics/counts_28d/20220727020503_i_code_review_merge_request_widget_code_quality_expand_warning_monthly.yml +++ b/config/metrics/counts_28d/20220727020503_i_code_review_merge_request_widget_code_quality_expand_warning_monthly.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/93333" time_frame: 28d data_source: redis_hll data_category: optional diff --git a/config/metrics/counts_28d/20220727020509_i_code_review_merge_request_widget_code_quality_expand_failed_monthly.yml b/config/metrics/counts_28d/20220727020509_i_code_review_merge_request_widget_code_quality_expand_failed_monthly.yml index 60b8e4ff2f0eb1..5e4e6221142e24 100644 --- a/config/metrics/counts_28d/20220727020509_i_code_review_merge_request_widget_code_quality_expand_failed_monthly.yml +++ b/config/metrics/counts_28d/20220727020509_i_code_review_merge_request_widget_code_quality_expand_failed_monthly.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/93333" time_frame: 28d data_source: redis_hll data_category: optional diff --git a/config/metrics/counts_7d/20220727020407_i_code_review_merge_request_widget_code_quality_view_weekly.yml b/config/metrics/counts_7d/20220727020407_i_code_review_merge_request_widget_code_quality_view_weekly.yml index ac5a9609b556cf..029103609cddd6 100644 --- a/config/metrics/counts_7d/20220727020407_i_code_review_merge_request_widget_code_quality_view_weekly.yml +++ b/config/metrics/counts_7d/20220727020407_i_code_review_merge_request_widget_code_quality_view_weekly.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/93333" time_frame: 7d data_source: redis_hll data_category: optional diff --git a/config/metrics/counts_7d/20220727020413_i_code_review_merge_request_widget_code_quality_full_report_clicked_weekly.yml b/config/metrics/counts_7d/20220727020413_i_code_review_merge_request_widget_code_quality_full_report_clicked_weekly.yml index 678f4431525fd5..d6e9d88d395d15 100644 --- a/config/metrics/counts_7d/20220727020413_i_code_review_merge_request_widget_code_quality_full_report_clicked_weekly.yml +++ b/config/metrics/counts_7d/20220727020413_i_code_review_merge_request_widget_code_quality_full_report_clicked_weekly.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/93333" time_frame: 7d data_source: redis_hll data_category: optional diff --git a/config/metrics/counts_7d/20220727020419_i_code_review_merge_request_widget_code_quality_expand_weekly.yml b/config/metrics/counts_7d/20220727020419_i_code_review_merge_request_widget_code_quality_expand_weekly.yml index 6fb5921593b42d..7d35f90ff4d231 100644 --- a/config/metrics/counts_7d/20220727020419_i_code_review_merge_request_widget_code_quality_expand_weekly.yml +++ b/config/metrics/counts_7d/20220727020419_i_code_review_merge_request_widget_code_quality_expand_weekly.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/93333" time_frame: 7d data_source: redis_hll data_category: optional diff --git a/config/metrics/counts_7d/20220727020424_i_code_review_merge_request_widget_code_quality_expand_success_weekly.yml b/config/metrics/counts_7d/20220727020424_i_code_review_merge_request_widget_code_quality_expand_success_weekly.yml index f406850391670a..a0c94702a5ff7d 100644 --- a/config/metrics/counts_7d/20220727020424_i_code_review_merge_request_widget_code_quality_expand_success_weekly.yml +++ b/config/metrics/counts_7d/20220727020424_i_code_review_merge_request_widget_code_quality_expand_success_weekly.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/93333" time_frame: 7d data_source: redis_hll data_category: optional diff --git a/config/metrics/counts_7d/20220727020429_i_code_review_merge_request_widget_code_quality_expand_warning_weekly.yml b/config/metrics/counts_7d/20220727020429_i_code_review_merge_request_widget_code_quality_expand_warning_weekly.yml index ded66f3531feaf..c88c435eaf202f 100644 --- a/config/metrics/counts_7d/20220727020429_i_code_review_merge_request_widget_code_quality_expand_warning_weekly.yml +++ b/config/metrics/counts_7d/20220727020429_i_code_review_merge_request_widget_code_quality_expand_warning_weekly.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/93333" time_frame: 7d data_source: redis_hll data_category: optional diff --git a/config/metrics/counts_7d/20220727020435_i_code_review_merge_request_widget_code_quality_expand_failed_weekly.yml b/config/metrics/counts_7d/20220727020435_i_code_review_merge_request_widget_code_quality_expand_failed_weekly.yml index c5b6bb6829e9b8..4ef43c77c5dd2e 100644 --- a/config/metrics/counts_7d/20220727020435_i_code_review_merge_request_widget_code_quality_expand_failed_weekly.yml +++ b/config/metrics/counts_7d/20220727020435_i_code_review_merge_request_widget_code_quality_expand_failed_weekly.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/93333" time_frame: 7d data_source: redis_hll data_category: optional diff --git a/config/metrics/counts_all/20220727004434_i_code_review_merge_request_widget_code_quality_count_view.yml b/config/metrics/counts_all/20220727004434_i_code_review_merge_request_widget_code_quality_count_view.yml index 7abca8d9883672..1687d346e34344 100644 --- a/config/metrics/counts_all/20220727004434_i_code_review_merge_request_widget_code_quality_count_view.yml +++ b/config/metrics/counts_all/20220727004434_i_code_review_merge_request_widget_code_quality_count_view.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/93333" time_frame: all data_source: redis data_category: optional diff --git a/config/metrics/counts_all/20220727004440_i_code_review_merge_request_widget_code_quality_count_full_report_clicked.yml b/config/metrics/counts_all/20220727004440_i_code_review_merge_request_widget_code_quality_count_full_report_clicked.yml index 34868a531d2c15..21ff87b8e39fb3 100644 --- a/config/metrics/counts_all/20220727004440_i_code_review_merge_request_widget_code_quality_count_full_report_clicked.yml +++ b/config/metrics/counts_all/20220727004440_i_code_review_merge_request_widget_code_quality_count_full_report_clicked.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/93333" time_frame: all data_source: redis data_category: optional diff --git a/config/metrics/counts_all/20220727004446_i_code_review_merge_request_widget_code_quality_count_expand.yml b/config/metrics/counts_all/20220727004446_i_code_review_merge_request_widget_code_quality_count_expand.yml index 1e3a51efe88369..49123b462d9a9c 100644 --- a/config/metrics/counts_all/20220727004446_i_code_review_merge_request_widget_code_quality_count_expand.yml +++ b/config/metrics/counts_all/20220727004446_i_code_review_merge_request_widget_code_quality_count_expand.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/93333" time_frame: all data_source: redis data_category: optional diff --git a/config/metrics/counts_all/20220727004451_i_code_review_merge_request_widget_code_quality_count_expand_success.yml b/config/metrics/counts_all/20220727004451_i_code_review_merge_request_widget_code_quality_count_expand_success.yml index 2c3c1ababa3b5e..8b349e04d2120c 100644 --- a/config/metrics/counts_all/20220727004451_i_code_review_merge_request_widget_code_quality_count_expand_success.yml +++ b/config/metrics/counts_all/20220727004451_i_code_review_merge_request_widget_code_quality_count_expand_success.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/93333" time_frame: all data_source: redis data_category: optional diff --git a/config/metrics/counts_all/20220727004457_i_code_review_merge_request_widget_code_quality_count_expand_warning.yml b/config/metrics/counts_all/20220727004457_i_code_review_merge_request_widget_code_quality_count_expand_warning.yml index 756dbfbb0c9830..e94c699971196a 100644 --- a/config/metrics/counts_all/20220727004457_i_code_review_merge_request_widget_code_quality_count_expand_warning.yml +++ b/config/metrics/counts_all/20220727004457_i_code_review_merge_request_widget_code_quality_count_expand_warning.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/93333" time_frame: all data_source: redis data_category: optional diff --git a/config/metrics/counts_all/20220727004502_i_code_review_merge_request_widget_code_quality_count_expand_failed.yml b/config/metrics/counts_all/20220727004502_i_code_review_merge_request_widget_code_quality_count_expand_failed.yml index ba40ef8924dbb3..5e49393afff75a 100644 --- a/config/metrics/counts_all/20220727004502_i_code_review_merge_request_widget_code_quality_count_expand_failed.yml +++ b/config/metrics/counts_all/20220727004502_i_code_review_merge_request_widget_code_quality_count_expand_failed.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/93333" time_frame: all data_source: redis data_category: optional -- GitLab