From 57688a2c8b28ea6718e700e97fa47ed49327227e Mon Sep 17 00:00:00 2001 From: Thomas Randolph Date: Tue, 26 Jul 2022 22:33:19 -0600 Subject: [PATCH 1/5] Add the Terraform widget as a known widget --- .../merge_request_widget_extension_counter.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/gitlab/usage_data_counters/merge_request_widget_extension_counter.rb b/lib/gitlab/usage_data_counters/merge_request_widget_extension_counter.rb index e56342039326a3..0d7dd1ab085cec 100644 --- a/lib/gitlab/usage_data_counters/merge_request_widget_extension_counter.rb +++ b/lib/gitlab/usage_data_counters/merge_request_widget_extension_counter.rb @@ -5,7 +5,7 @@ module UsageDataCounters class MergeRequestWidgetExtensionCounter < BaseCounter KNOWN_EVENTS = %w[view full_report_clicked expand expand_success expand_warning expand_failed].freeze PREFIX = 'i_code_review_merge_request_widget' - WIDGETS = %w[accessibility code_quality test_summary].freeze + WIDGETS = %w[accessibility code_quality terraform test_summary].freeze class << self private -- GitLab From 90c784d3b1fa68fc1765d95f5c4920dc5167ba45 Mon Sep 17 00:00:00 2001 From: Thomas Randolph Date: Tue, 26 Jul 2022 22:50:35 -0600 Subject: [PATCH 2/5] Add metrics for every total/sum (regular) redis counter --- ...ge_request_widget_terraform_count_view.yml | 24 +++++++++++++++++++ ...et_terraform_count_full_report_clicked.yml | 24 +++++++++++++++++++ ..._request_widget_terraform_count_expand.yml | 24 +++++++++++++++++++ ..._widget_terraform_count_expand_success.yml | 24 +++++++++++++++++++ ..._widget_terraform_count_expand_warning.yml | 24 +++++++++++++++++++ ...t_widget_terraform_count_expand_failed.yml | 24 +++++++++++++++++++ 6 files changed, 144 insertions(+) create mode 100644 config/metrics/counts_all/20220727044257_i_code_review_merge_request_widget_terraform_count_view.yml create mode 100644 config/metrics/counts_all/20220727044304_i_code_review_merge_request_widget_terraform_count_full_report_clicked.yml create mode 100644 config/metrics/counts_all/20220727044310_i_code_review_merge_request_widget_terraform_count_expand.yml create mode 100644 config/metrics/counts_all/20220727044316_i_code_review_merge_request_widget_terraform_count_expand_success.yml create mode 100644 config/metrics/counts_all/20220727044322_i_code_review_merge_request_widget_terraform_count_expand_warning.yml create mode 100644 config/metrics/counts_all/20220727044329_i_code_review_merge_request_widget_terraform_count_expand_failed.yml diff --git a/config/metrics/counts_all/20220727044257_i_code_review_merge_request_widget_terraform_count_view.yml b/config/metrics/counts_all/20220727044257_i_code_review_merge_request_widget_terraform_count_view.yml new file mode 100644 index 00000000000000..e40d28b587c635 --- /dev/null +++ b/config/metrics/counts_all/20220727044257_i_code_review_merge_request_widget_terraform_count_view.yml @@ -0,0 +1,24 @@ +--- +key_path: counts.i_code_review_merge_request_widget_terraform_count_view +description: Total number of times the Terraform widget extension was viewed (rendered to the screen) +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +time_frame: all +data_source: redis +data_category: optional +options: + events: + - i_code_review_merge_request_widget_terraform_count_view +distribution: +- ce +- ee +tier: +- free +- premium +- ultimate diff --git a/config/metrics/counts_all/20220727044304_i_code_review_merge_request_widget_terraform_count_full_report_clicked.yml b/config/metrics/counts_all/20220727044304_i_code_review_merge_request_widget_terraform_count_full_report_clicked.yml new file mode 100644 index 00000000000000..8e13a697c6d49c --- /dev/null +++ b/config/metrics/counts_all/20220727044304_i_code_review_merge_request_widget_terraform_count_full_report_clicked.yml @@ -0,0 +1,24 @@ +--- +key_path: counts.i_code_review_merge_request_widget_terraform_count_full_report_clicked +description: Total number of times the Terraform widget extension Full Report button was clicked +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +time_frame: all +data_source: redis +data_category: optional +options: + events: + - i_code_review_merge_request_widget_terraform_count_full_report_clicked +distribution: +- ce +- ee +tier: +- free +- premium +- ultimate diff --git a/config/metrics/counts_all/20220727044310_i_code_review_merge_request_widget_terraform_count_expand.yml b/config/metrics/counts_all/20220727044310_i_code_review_merge_request_widget_terraform_count_expand.yml new file mode 100644 index 00000000000000..9b66bab509cc94 --- /dev/null +++ b/config/metrics/counts_all/20220727044310_i_code_review_merge_request_widget_terraform_count_expand.yml @@ -0,0 +1,24 @@ +--- +key_path: counts.i_code_review_merge_request_widget_terraform_count_expand +description: Total number of times the Terraform widget extension was expanded (in any state) +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +time_frame: all +data_source: redis +data_category: optional +options: + events: + - i_code_review_merge_request_widget_terraform_count_expand +distribution: +- ce +- ee +tier: +- free +- premium +- ultimate diff --git a/config/metrics/counts_all/20220727044316_i_code_review_merge_request_widget_terraform_count_expand_success.yml b/config/metrics/counts_all/20220727044316_i_code_review_merge_request_widget_terraform_count_expand_success.yml new file mode 100644 index 00000000000000..9f32d74af0609f --- /dev/null +++ b/config/metrics/counts_all/20220727044316_i_code_review_merge_request_widget_terraform_count_expand_success.yml @@ -0,0 +1,24 @@ +--- +key_path: counts.i_code_review_merge_request_widget_terraform_count_expand_success +description: Total number of times the Terraform widget extension was expanded (while in its Success state) +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +time_frame: all +data_source: redis +data_category: optional +options: + events: + - i_code_review_merge_request_widget_terraform_count_expand_success +distribution: +- ce +- ee +tier: +- free +- premium +- ultimate diff --git a/config/metrics/counts_all/20220727044322_i_code_review_merge_request_widget_terraform_count_expand_warning.yml b/config/metrics/counts_all/20220727044322_i_code_review_merge_request_widget_terraform_count_expand_warning.yml new file mode 100644 index 00000000000000..015822c8f33b70 --- /dev/null +++ b/config/metrics/counts_all/20220727044322_i_code_review_merge_request_widget_terraform_count_expand_warning.yml @@ -0,0 +1,24 @@ +--- +key_path: counts.i_code_review_merge_request_widget_terraform_count_expand_warning +description: Total number of times the Terraform widget extension was expanded (while in its Warning state) +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +time_frame: all +data_source: redis +data_category: optional +options: + events: + - i_code_review_merge_request_widget_terraform_count_expand_warning +distribution: +- ce +- ee +tier: +- free +- premium +- ultimate diff --git a/config/metrics/counts_all/20220727044329_i_code_review_merge_request_widget_terraform_count_expand_failed.yml b/config/metrics/counts_all/20220727044329_i_code_review_merge_request_widget_terraform_count_expand_failed.yml new file mode 100644 index 00000000000000..c4f0c67560cbb0 --- /dev/null +++ b/config/metrics/counts_all/20220727044329_i_code_review_merge_request_widget_terraform_count_expand_failed.yml @@ -0,0 +1,24 @@ +--- +key_path: counts.i_code_review_merge_request_widget_terraform_count_expand_failed +description: Total number of times the Terraform widget extension was expanded (while in its Failed state) +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +time_frame: all +data_source: redis +data_category: optional +options: + events: + - i_code_review_merge_request_widget_terraform_count_expand_failed +distribution: +- ce +- ee +tier: +- free +- premium +- ultimate -- GitLab From bbfd88b504fc421863a68d91d55012284101c1c3 Mon Sep 17 00:00:00 2001 From: Thomas Randolph Date: Tue, 26 Jul 2022 23:02:10 -0600 Subject: [PATCH 3/5] Add metrics for every unique user (hll) redis counter --- ..._request_widget_terraform_view_monthly.yml | 25 +++++++++++++++++++ ..._terraform_full_report_clicked_monthly.yml | 25 +++++++++++++++++++ ...equest_widget_terraform_expand_monthly.yml | 25 +++++++++++++++++++ ...idget_terraform_expand_success_monthly.yml | 25 +++++++++++++++++++ ...idget_terraform_expand_warning_monthly.yml | 25 +++++++++++++++++++ ...widget_terraform_expand_failed_monthly.yml | 25 +++++++++++++++++++ ...e_request_widget_terraform_view_weekly.yml | 25 +++++++++++++++++++ ...t_terraform_full_report_clicked_weekly.yml | 25 +++++++++++++++++++ ...request_widget_terraform_expand_weekly.yml | 25 +++++++++++++++++++ ...widget_terraform_expand_success_weekly.yml | 25 +++++++++++++++++++ ...widget_terraform_expand_warning_weekly.yml | 25 +++++++++++++++++++ ..._widget_terraform_expand_failed_weekly.yml | 25 +++++++++++++++++++ 12 files changed, 300 insertions(+) create mode 100644 config/metrics/counts_28d/20220727045317_i_code_review_merge_request_widget_terraform_view_monthly.yml create mode 100644 config/metrics/counts_28d/20220727045323_i_code_review_merge_request_widget_terraform_full_report_clicked_monthly.yml create mode 100644 config/metrics/counts_28d/20220727045330_i_code_review_merge_request_widget_terraform_expand_monthly.yml create mode 100644 config/metrics/counts_28d/20220727045336_i_code_review_merge_request_widget_terraform_expand_success_monthly.yml create mode 100644 config/metrics/counts_28d/20220727045342_i_code_review_merge_request_widget_terraform_expand_warning_monthly.yml create mode 100644 config/metrics/counts_28d/20220727045349_i_code_review_merge_request_widget_terraform_expand_failed_monthly.yml create mode 100644 config/metrics/counts_7d/20220727045240_i_code_review_merge_request_widget_terraform_view_weekly.yml create mode 100644 config/metrics/counts_7d/20220727045246_i_code_review_merge_request_widget_terraform_full_report_clicked_weekly.yml create mode 100644 config/metrics/counts_7d/20220727045252_i_code_review_merge_request_widget_terraform_expand_weekly.yml create mode 100644 config/metrics/counts_7d/20220727045258_i_code_review_merge_request_widget_terraform_expand_success_weekly.yml create mode 100644 config/metrics/counts_7d/20220727045304_i_code_review_merge_request_widget_terraform_expand_warning_weekly.yml create mode 100644 config/metrics/counts_7d/20220727045311_i_code_review_merge_request_widget_terraform_expand_failed_weekly.yml diff --git a/config/metrics/counts_28d/20220727045317_i_code_review_merge_request_widget_terraform_view_monthly.yml b/config/metrics/counts_28d/20220727045317_i_code_review_merge_request_widget_terraform_view_monthly.yml new file mode 100644 index 00000000000000..85f0847d91f4c8 --- /dev/null +++ b/config/metrics/counts_28d/20220727045317_i_code_review_merge_request_widget_terraform_view_monthly.yml @@ -0,0 +1,25 @@ +--- +key_path: redis_hll_counters.code_review.i_code_review_merge_request_widget_terraform_view_monthly +description: The count of unique users (monthly) who were able to see the Terraform widget extension +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +time_frame: 28d +data_source: redis_hll +data_category: optional +instrumentation_class: RedisHLLMetric +options: + events: + - i_code_review_merge_request_widget_terraform_view +distribution: +- ce +- ee +tier: +- free +- premium +- ultimate diff --git a/config/metrics/counts_28d/20220727045323_i_code_review_merge_request_widget_terraform_full_report_clicked_monthly.yml b/config/metrics/counts_28d/20220727045323_i_code_review_merge_request_widget_terraform_full_report_clicked_monthly.yml new file mode 100644 index 00000000000000..bc2181043d4bc8 --- /dev/null +++ b/config/metrics/counts_28d/20220727045323_i_code_review_merge_request_widget_terraform_full_report_clicked_monthly.yml @@ -0,0 +1,25 @@ +--- +key_path: redis_hll_counters.code_review.i_code_review_merge_request_widget_terraform_full_report_clicked_monthly +description: The count of unique users (monthly) who clicked the Full Report button on the Terraform widget extension +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +time_frame: 28d +data_source: redis_hll +data_category: optional +instrumentation_class: RedisHLLMetric +options: + events: + - i_code_review_merge_request_widget_terraform_full_report_clicked +distribution: +- ce +- ee +tier: +- free +- premium +- ultimate diff --git a/config/metrics/counts_28d/20220727045330_i_code_review_merge_request_widget_terraform_expand_monthly.yml b/config/metrics/counts_28d/20220727045330_i_code_review_merge_request_widget_terraform_expand_monthly.yml new file mode 100644 index 00000000000000..3e24b0c42e7bf9 --- /dev/null +++ b/config/metrics/counts_28d/20220727045330_i_code_review_merge_request_widget_terraform_expand_monthly.yml @@ -0,0 +1,25 @@ +--- +key_path: redis_hll_counters.code_review.i_code_review_merge_request_widget_terraform_expand_monthly +description: The count of unique users (monthly) who expanded the Terraform widget extension +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +time_frame: 28d +data_source: redis_hll +data_category: optional +instrumentation_class: RedisHLLMetric +options: + events: + - i_code_review_merge_request_widget_terraform_expand +distribution: +- ce +- ee +tier: +- free +- premium +- ultimate diff --git a/config/metrics/counts_28d/20220727045336_i_code_review_merge_request_widget_terraform_expand_success_monthly.yml b/config/metrics/counts_28d/20220727045336_i_code_review_merge_request_widget_terraform_expand_success_monthly.yml new file mode 100644 index 00000000000000..be95a8118d6b8a --- /dev/null +++ b/config/metrics/counts_28d/20220727045336_i_code_review_merge_request_widget_terraform_expand_success_monthly.yml @@ -0,0 +1,25 @@ +--- +key_path: redis_hll_counters.code_review.i_code_review_merge_request_widget_terraform_expand_success_monthly +description: The count of unique users (monthly) who expanded the Terraform widget extension while it is in its Success state +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +time_frame: 28d +data_source: redis_hll +data_category: optional +instrumentation_class: RedisHLLMetric +options: + events: + - i_code_review_merge_request_widget_terraform_expand_success +distribution: +- ce +- ee +tier: +- free +- premium +- ultimate diff --git a/config/metrics/counts_28d/20220727045342_i_code_review_merge_request_widget_terraform_expand_warning_monthly.yml b/config/metrics/counts_28d/20220727045342_i_code_review_merge_request_widget_terraform_expand_warning_monthly.yml new file mode 100644 index 00000000000000..e18a87b03d4636 --- /dev/null +++ b/config/metrics/counts_28d/20220727045342_i_code_review_merge_request_widget_terraform_expand_warning_monthly.yml @@ -0,0 +1,25 @@ +--- +key_path: redis_hll_counters.code_review.i_code_review_merge_request_widget_terraform_expand_warning_monthly +description: The count of unique users (monthly) who expanded the Terraform widget extension while it is in its Warning state +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +time_frame: 28d +data_source: redis_hll +data_category: optional +instrumentation_class: RedisHLLMetric +options: + events: + - i_code_review_merge_request_widget_terraform_expand_warning +distribution: +- ce +- ee +tier: +- free +- premium +- ultimate diff --git a/config/metrics/counts_28d/20220727045349_i_code_review_merge_request_widget_terraform_expand_failed_monthly.yml b/config/metrics/counts_28d/20220727045349_i_code_review_merge_request_widget_terraform_expand_failed_monthly.yml new file mode 100644 index 00000000000000..8091f254e23d42 --- /dev/null +++ b/config/metrics/counts_28d/20220727045349_i_code_review_merge_request_widget_terraform_expand_failed_monthly.yml @@ -0,0 +1,25 @@ +--- +key_path: redis_hll_counters.code_review.i_code_review_merge_request_widget_terraform_expand_failed_monthly +description: The count of unique users (monthly) who expanded the Terraform widget extension while it is in its Failed state +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +time_frame: 28d +data_source: redis_hll +data_category: optional +instrumentation_class: RedisHLLMetric +options: + events: + - i_code_review_merge_request_widget_terraform_expand_failed +distribution: +- ce +- ee +tier: +- free +- premium +- ultimate diff --git a/config/metrics/counts_7d/20220727045240_i_code_review_merge_request_widget_terraform_view_weekly.yml b/config/metrics/counts_7d/20220727045240_i_code_review_merge_request_widget_terraform_view_weekly.yml new file mode 100644 index 00000000000000..fb2067e4be0008 --- /dev/null +++ b/config/metrics/counts_7d/20220727045240_i_code_review_merge_request_widget_terraform_view_weekly.yml @@ -0,0 +1,25 @@ +--- +key_path: redis_hll_counters.code_review.i_code_review_merge_request_widget_terraform_view_weekly +description: The count of unique users (weekly) who were able to see the Terraform widget extension +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +time_frame: 7d +data_source: redis_hll +data_category: optional +instrumentation_class: RedisHLLMetric +options: + events: + - i_code_review_merge_request_widget_terraform_view +distribution: +- ce +- ee +tier: +- free +- premium +- ultimate diff --git a/config/metrics/counts_7d/20220727045246_i_code_review_merge_request_widget_terraform_full_report_clicked_weekly.yml b/config/metrics/counts_7d/20220727045246_i_code_review_merge_request_widget_terraform_full_report_clicked_weekly.yml new file mode 100644 index 00000000000000..6a42cd3d59d5c9 --- /dev/null +++ b/config/metrics/counts_7d/20220727045246_i_code_review_merge_request_widget_terraform_full_report_clicked_weekly.yml @@ -0,0 +1,25 @@ +--- +key_path: redis_hll_counters.code_review.i_code_review_merge_request_widget_terraform_full_report_clicked_weekly +description: The count of unique users (weekly) who clicked the Full Report button on the Terraform widget extension +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +time_frame: 7d +data_source: redis_hll +data_category: optional +instrumentation_class: RedisHLLMetric +options: + events: + - i_code_review_merge_request_widget_terraform_full_report_clicked +distribution: +- ce +- ee +tier: +- free +- premium +- ultimate diff --git a/config/metrics/counts_7d/20220727045252_i_code_review_merge_request_widget_terraform_expand_weekly.yml b/config/metrics/counts_7d/20220727045252_i_code_review_merge_request_widget_terraform_expand_weekly.yml new file mode 100644 index 00000000000000..6e24f674a9c5fb --- /dev/null +++ b/config/metrics/counts_7d/20220727045252_i_code_review_merge_request_widget_terraform_expand_weekly.yml @@ -0,0 +1,25 @@ +--- +key_path: redis_hll_counters.code_review.i_code_review_merge_request_widget_terraform_expand_weekly +description: The count of unique users (weekly) who expanded the Terraform widget extension +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +time_frame: 7d +data_source: redis_hll +data_category: optional +instrumentation_class: RedisHLLMetric +options: + events: + - i_code_review_merge_request_widget_terraform_expand +distribution: +- ce +- ee +tier: +- free +- premium +- ultimate diff --git a/config/metrics/counts_7d/20220727045258_i_code_review_merge_request_widget_terraform_expand_success_weekly.yml b/config/metrics/counts_7d/20220727045258_i_code_review_merge_request_widget_terraform_expand_success_weekly.yml new file mode 100644 index 00000000000000..f0a5b4031f8736 --- /dev/null +++ b/config/metrics/counts_7d/20220727045258_i_code_review_merge_request_widget_terraform_expand_success_weekly.yml @@ -0,0 +1,25 @@ +--- +key_path: redis_hll_counters.code_review.i_code_review_merge_request_widget_terraform_expand_success_weekly +description: The count of unique users (weekly) who expanded the Terraform widget extension while it is in its Success state +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +time_frame: 7d +data_source: redis_hll +data_category: optional +instrumentation_class: RedisHLLMetric +options: + events: + - i_code_review_merge_request_widget_terraform_expand_success +distribution: +- ce +- ee +tier: +- free +- premium +- ultimate diff --git a/config/metrics/counts_7d/20220727045304_i_code_review_merge_request_widget_terraform_expand_warning_weekly.yml b/config/metrics/counts_7d/20220727045304_i_code_review_merge_request_widget_terraform_expand_warning_weekly.yml new file mode 100644 index 00000000000000..4512b23da10202 --- /dev/null +++ b/config/metrics/counts_7d/20220727045304_i_code_review_merge_request_widget_terraform_expand_warning_weekly.yml @@ -0,0 +1,25 @@ +--- +key_path: redis_hll_counters.code_review.i_code_review_merge_request_widget_terraform_expand_warning_weekly +description: The count of unique users (weekly) who expanded the Terraform widget extension while it is in its Warning state +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +time_frame: 7d +data_source: redis_hll +data_category: optional +instrumentation_class: RedisHLLMetric +options: + events: + - i_code_review_merge_request_widget_terraform_expand_warning +distribution: +- ce +- ee +tier: +- free +- premium +- ultimate diff --git a/config/metrics/counts_7d/20220727045311_i_code_review_merge_request_widget_terraform_expand_failed_weekly.yml b/config/metrics/counts_7d/20220727045311_i_code_review_merge_request_widget_terraform_expand_failed_weekly.yml new file mode 100644 index 00000000000000..029ebaf8b62f3f --- /dev/null +++ b/config/metrics/counts_7d/20220727045311_i_code_review_merge_request_widget_terraform_expand_failed_weekly.yml @@ -0,0 +1,25 @@ +--- +key_path: redis_hll_counters.code_review.i_code_review_merge_request_widget_terraform_expand_failed_weekly +description: The count of unique users (weekly) who expanded the Terraform widget extension while it is in its Failed state +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +time_frame: 7d +data_source: redis_hll +data_category: optional +instrumentation_class: RedisHLLMetric +options: + events: + - i_code_review_merge_request_widget_terraform_expand_failed +distribution: +- ce +- ee +tier: +- free +- premium +- ultimate -- GitLab From 80814a63734bea9e7b64833b76d36945cf737c86 Mon Sep 17 00:00:00 2001 From: Thomas Randolph Date: Tue, 26 Jul 2022 23:03:47 -0600 Subject: [PATCH 4/5] Add the reported events to metrics yml files --- config/metrics/aggregates/code_review.yml | 12 +++++++++ .../known_events/code_review_events.yml | 25 +++++++++++++++++++ 2 files changed, 37 insertions(+) diff --git a/config/metrics/aggregates/code_review.yml b/config/metrics/aggregates/code_review.yml index 15ef2c06a01e70..2159f1fa0b4843 100644 --- a/config/metrics/aggregates/code_review.yml +++ b/config/metrics/aggregates/code_review.yml @@ -98,6 +98,12 @@ - 'i_code_review_merge_request_widget_code_quality_expand_success' - 'i_code_review_merge_request_widget_code_quality_expand_warning' - 'i_code_review_merge_request_widget_code_quality_expand_failed' + - 'i_code_review_merge_request_widget_terraform_view' + - 'i_code_review_merge_request_widget_terraform_full_report_clicked' + - 'i_code_review_merge_request_widget_terraform_expand' + - 'i_code_review_merge_request_widget_terraform_expand_success' + - 'i_code_review_merge_request_widget_terraform_expand_warning' + - 'i_code_review_merge_request_widget_terraform_expand_failed' - name: code_review_category_monthly_active_users operator: OR source: redis @@ -184,6 +190,12 @@ - 'i_code_review_merge_request_widget_code_quality_expand_success' - 'i_code_review_merge_request_widget_code_quality_expand_warning' - 'i_code_review_merge_request_widget_code_quality_expand_failed' + - 'i_code_review_merge_request_widget_terraform_view' + - 'i_code_review_merge_request_widget_terraform_full_report_clicked' + - 'i_code_review_merge_request_widget_terraform_expand' + - 'i_code_review_merge_request_widget_terraform_expand_success' + - 'i_code_review_merge_request_widget_terraform_expand_warning' + - 'i_code_review_merge_request_widget_terraform_expand_failed' - name: code_review_extension_category_monthly_active_users operator: OR source: redis diff --git a/lib/gitlab/usage_data_counters/known_events/code_review_events.yml b/lib/gitlab/usage_data_counters/known_events/code_review_events.yml index 7adb45bc9fa66f..bdf6b48357f2a8 100644 --- a/lib/gitlab/usage_data_counters/known_events/code_review_events.yml +++ b/lib/gitlab/usage_data_counters/known_events/code_review_events.yml @@ -375,3 +375,28 @@ redis_slot: code_review category: code_review aggregation: weekly +## Terraform +- name: i_code_review_merge_request_widget_terraform_view + redis_slot: code_review + category: code_review + aggregation: weekly +- name: i_code_review_merge_request_widget_terraform_full_report_clicked + redis_slot: code_review + category: code_review + aggregation: weekly +- name: i_code_review_merge_request_widget_terraform_expand + redis_slot: code_review + category: code_review + aggregation: weekly +- name: i_code_review_merge_request_widget_terraform_expand_success + redis_slot: code_review + category: code_review + aggregation: weekly +- name: i_code_review_merge_request_widget_terraform_expand_warning + redis_slot: code_review + category: code_review + aggregation: weekly +- name: i_code_review_merge_request_widget_terraform_expand_failed + redis_slot: code_review + category: code_review + aggregation: weekly -- GitLab From 80d066fc6decb194a4b2da468e6dddacb0984889 Mon Sep 17 00:00:00 2001 From: Thomas Randolph Date: Tue, 26 Jul 2022 23:08:40 -0600 Subject: [PATCH 5/5] Update the MR id now that it exists --- ..._code_review_merge_request_widget_terraform_view_monthly.yml | 2 +- ...rge_request_widget_terraform_full_report_clicked_monthly.yml | 2 +- ...ode_review_merge_request_widget_terraform_expand_monthly.yml | 2 +- ...ew_merge_request_widget_terraform_expand_success_monthly.yml | 2 +- ...ew_merge_request_widget_terraform_expand_warning_monthly.yml | 2 +- ...iew_merge_request_widget_terraform_expand_failed_monthly.yml | 2 +- ...i_code_review_merge_request_widget_terraform_view_weekly.yml | 2 +- ...erge_request_widget_terraform_full_report_clicked_weekly.yml | 2 +- ...code_review_merge_request_widget_terraform_expand_weekly.yml | 2 +- ...iew_merge_request_widget_terraform_expand_success_weekly.yml | 2 +- ...iew_merge_request_widget_terraform_expand_warning_weekly.yml | 2 +- ...view_merge_request_widget_terraform_expand_failed_weekly.yml | 2 +- ..._i_code_review_merge_request_widget_terraform_count_view.yml | 2 +- ...merge_request_widget_terraform_count_full_report_clicked.yml | 2 +- ..._code_review_merge_request_widget_terraform_count_expand.yml | 2 +- ...view_merge_request_widget_terraform_count_expand_success.yml | 2 +- ...view_merge_request_widget_terraform_count_expand_warning.yml | 2 +- ...eview_merge_request_widget_terraform_count_expand_failed.yml | 2 +- 18 files changed, 18 insertions(+), 18 deletions(-) diff --git a/config/metrics/counts_28d/20220727045317_i_code_review_merge_request_widget_terraform_view_monthly.yml b/config/metrics/counts_28d/20220727045317_i_code_review_merge_request_widget_terraform_view_monthly.yml index 85f0847d91f4c8..c18e947f722b48 100644 --- a/config/metrics/counts_28d/20220727045317_i_code_review_merge_request_widget_terraform_view_monthly.yml +++ b/config/metrics/counts_28d/20220727045317_i_code_review_merge_request_widget_terraform_view_monthly.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/93340" time_frame: 28d data_source: redis_hll data_category: optional diff --git a/config/metrics/counts_28d/20220727045323_i_code_review_merge_request_widget_terraform_full_report_clicked_monthly.yml b/config/metrics/counts_28d/20220727045323_i_code_review_merge_request_widget_terraform_full_report_clicked_monthly.yml index bc2181043d4bc8..1791ba6d4cf7e4 100644 --- a/config/metrics/counts_28d/20220727045323_i_code_review_merge_request_widget_terraform_full_report_clicked_monthly.yml +++ b/config/metrics/counts_28d/20220727045323_i_code_review_merge_request_widget_terraform_full_report_clicked_monthly.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/93340" time_frame: 28d data_source: redis_hll data_category: optional diff --git a/config/metrics/counts_28d/20220727045330_i_code_review_merge_request_widget_terraform_expand_monthly.yml b/config/metrics/counts_28d/20220727045330_i_code_review_merge_request_widget_terraform_expand_monthly.yml index 3e24b0c42e7bf9..67f73ee4122fdd 100644 --- a/config/metrics/counts_28d/20220727045330_i_code_review_merge_request_widget_terraform_expand_monthly.yml +++ b/config/metrics/counts_28d/20220727045330_i_code_review_merge_request_widget_terraform_expand_monthly.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/93340" time_frame: 28d data_source: redis_hll data_category: optional diff --git a/config/metrics/counts_28d/20220727045336_i_code_review_merge_request_widget_terraform_expand_success_monthly.yml b/config/metrics/counts_28d/20220727045336_i_code_review_merge_request_widget_terraform_expand_success_monthly.yml index be95a8118d6b8a..a374ed99263d2c 100644 --- a/config/metrics/counts_28d/20220727045336_i_code_review_merge_request_widget_terraform_expand_success_monthly.yml +++ b/config/metrics/counts_28d/20220727045336_i_code_review_merge_request_widget_terraform_expand_success_monthly.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/93340" time_frame: 28d data_source: redis_hll data_category: optional diff --git a/config/metrics/counts_28d/20220727045342_i_code_review_merge_request_widget_terraform_expand_warning_monthly.yml b/config/metrics/counts_28d/20220727045342_i_code_review_merge_request_widget_terraform_expand_warning_monthly.yml index e18a87b03d4636..909211e2a355af 100644 --- a/config/metrics/counts_28d/20220727045342_i_code_review_merge_request_widget_terraform_expand_warning_monthly.yml +++ b/config/metrics/counts_28d/20220727045342_i_code_review_merge_request_widget_terraform_expand_warning_monthly.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/93340" time_frame: 28d data_source: redis_hll data_category: optional diff --git a/config/metrics/counts_28d/20220727045349_i_code_review_merge_request_widget_terraform_expand_failed_monthly.yml b/config/metrics/counts_28d/20220727045349_i_code_review_merge_request_widget_terraform_expand_failed_monthly.yml index 8091f254e23d42..a1d247d405f4cf 100644 --- a/config/metrics/counts_28d/20220727045349_i_code_review_merge_request_widget_terraform_expand_failed_monthly.yml +++ b/config/metrics/counts_28d/20220727045349_i_code_review_merge_request_widget_terraform_expand_failed_monthly.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/93340" time_frame: 28d data_source: redis_hll data_category: optional diff --git a/config/metrics/counts_7d/20220727045240_i_code_review_merge_request_widget_terraform_view_weekly.yml b/config/metrics/counts_7d/20220727045240_i_code_review_merge_request_widget_terraform_view_weekly.yml index fb2067e4be0008..26d4709a35b09f 100644 --- a/config/metrics/counts_7d/20220727045240_i_code_review_merge_request_widget_terraform_view_weekly.yml +++ b/config/metrics/counts_7d/20220727045240_i_code_review_merge_request_widget_terraform_view_weekly.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/93340" time_frame: 7d data_source: redis_hll data_category: optional diff --git a/config/metrics/counts_7d/20220727045246_i_code_review_merge_request_widget_terraform_full_report_clicked_weekly.yml b/config/metrics/counts_7d/20220727045246_i_code_review_merge_request_widget_terraform_full_report_clicked_weekly.yml index 6a42cd3d59d5c9..85017ed6ae4a4d 100644 --- a/config/metrics/counts_7d/20220727045246_i_code_review_merge_request_widget_terraform_full_report_clicked_weekly.yml +++ b/config/metrics/counts_7d/20220727045246_i_code_review_merge_request_widget_terraform_full_report_clicked_weekly.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/93340" time_frame: 7d data_source: redis_hll data_category: optional diff --git a/config/metrics/counts_7d/20220727045252_i_code_review_merge_request_widget_terraform_expand_weekly.yml b/config/metrics/counts_7d/20220727045252_i_code_review_merge_request_widget_terraform_expand_weekly.yml index 6e24f674a9c5fb..7a73af7a042783 100644 --- a/config/metrics/counts_7d/20220727045252_i_code_review_merge_request_widget_terraform_expand_weekly.yml +++ b/config/metrics/counts_7d/20220727045252_i_code_review_merge_request_widget_terraform_expand_weekly.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/93340" time_frame: 7d data_source: redis_hll data_category: optional diff --git a/config/metrics/counts_7d/20220727045258_i_code_review_merge_request_widget_terraform_expand_success_weekly.yml b/config/metrics/counts_7d/20220727045258_i_code_review_merge_request_widget_terraform_expand_success_weekly.yml index f0a5b4031f8736..b9c2593f3ccfd2 100644 --- a/config/metrics/counts_7d/20220727045258_i_code_review_merge_request_widget_terraform_expand_success_weekly.yml +++ b/config/metrics/counts_7d/20220727045258_i_code_review_merge_request_widget_terraform_expand_success_weekly.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/93340" time_frame: 7d data_source: redis_hll data_category: optional diff --git a/config/metrics/counts_7d/20220727045304_i_code_review_merge_request_widget_terraform_expand_warning_weekly.yml b/config/metrics/counts_7d/20220727045304_i_code_review_merge_request_widget_terraform_expand_warning_weekly.yml index 4512b23da10202..8eaff0bd1eac2d 100644 --- a/config/metrics/counts_7d/20220727045304_i_code_review_merge_request_widget_terraform_expand_warning_weekly.yml +++ b/config/metrics/counts_7d/20220727045304_i_code_review_merge_request_widget_terraform_expand_warning_weekly.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/93340" time_frame: 7d data_source: redis_hll data_category: optional diff --git a/config/metrics/counts_7d/20220727045311_i_code_review_merge_request_widget_terraform_expand_failed_weekly.yml b/config/metrics/counts_7d/20220727045311_i_code_review_merge_request_widget_terraform_expand_failed_weekly.yml index 029ebaf8b62f3f..55de00b858cd92 100644 --- a/config/metrics/counts_7d/20220727045311_i_code_review_merge_request_widget_terraform_expand_failed_weekly.yml +++ b/config/metrics/counts_7d/20220727045311_i_code_review_merge_request_widget_terraform_expand_failed_weekly.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/93340" time_frame: 7d data_source: redis_hll data_category: optional diff --git a/config/metrics/counts_all/20220727044257_i_code_review_merge_request_widget_terraform_count_view.yml b/config/metrics/counts_all/20220727044257_i_code_review_merge_request_widget_terraform_count_view.yml index e40d28b587c635..f523b91b5d9fce 100644 --- a/config/metrics/counts_all/20220727044257_i_code_review_merge_request_widget_terraform_count_view.yml +++ b/config/metrics/counts_all/20220727044257_i_code_review_merge_request_widget_terraform_count_view.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/93340" time_frame: all data_source: redis data_category: optional diff --git a/config/metrics/counts_all/20220727044304_i_code_review_merge_request_widget_terraform_count_full_report_clicked.yml b/config/metrics/counts_all/20220727044304_i_code_review_merge_request_widget_terraform_count_full_report_clicked.yml index 8e13a697c6d49c..53eb5770ed5883 100644 --- a/config/metrics/counts_all/20220727044304_i_code_review_merge_request_widget_terraform_count_full_report_clicked.yml +++ b/config/metrics/counts_all/20220727044304_i_code_review_merge_request_widget_terraform_count_full_report_clicked.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/93340" time_frame: all data_source: redis data_category: optional diff --git a/config/metrics/counts_all/20220727044310_i_code_review_merge_request_widget_terraform_count_expand.yml b/config/metrics/counts_all/20220727044310_i_code_review_merge_request_widget_terraform_count_expand.yml index 9b66bab509cc94..0406b84d4572e3 100644 --- a/config/metrics/counts_all/20220727044310_i_code_review_merge_request_widget_terraform_count_expand.yml +++ b/config/metrics/counts_all/20220727044310_i_code_review_merge_request_widget_terraform_count_expand.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/93340" time_frame: all data_source: redis data_category: optional diff --git a/config/metrics/counts_all/20220727044316_i_code_review_merge_request_widget_terraform_count_expand_success.yml b/config/metrics/counts_all/20220727044316_i_code_review_merge_request_widget_terraform_count_expand_success.yml index 9f32d74af0609f..c497758b543cbd 100644 --- a/config/metrics/counts_all/20220727044316_i_code_review_merge_request_widget_terraform_count_expand_success.yml +++ b/config/metrics/counts_all/20220727044316_i_code_review_merge_request_widget_terraform_count_expand_success.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/93340" time_frame: all data_source: redis data_category: optional diff --git a/config/metrics/counts_all/20220727044322_i_code_review_merge_request_widget_terraform_count_expand_warning.yml b/config/metrics/counts_all/20220727044322_i_code_review_merge_request_widget_terraform_count_expand_warning.yml index 015822c8f33b70..1a0a112dc89c5c 100644 --- a/config/metrics/counts_all/20220727044322_i_code_review_merge_request_widget_terraform_count_expand_warning.yml +++ b/config/metrics/counts_all/20220727044322_i_code_review_merge_request_widget_terraform_count_expand_warning.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/93340" time_frame: all data_source: redis data_category: optional diff --git a/config/metrics/counts_all/20220727044329_i_code_review_merge_request_widget_terraform_count_expand_failed.yml b/config/metrics/counts_all/20220727044329_i_code_review_merge_request_widget_terraform_count_expand_failed.yml index c4f0c67560cbb0..3e1ac7db1d5fa0 100644 --- a/config/metrics/counts_all/20220727044329_i_code_review_merge_request_widget_terraform_count_expand_failed.yml +++ b/config/metrics/counts_all/20220727044329_i_code_review_merge_request_widget_terraform_count_expand_failed.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/xxxxx" +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/93340" time_frame: all data_source: redis data_category: optional -- GitLab