From fd9e27775213742851bce30737aad32c433aaa03 Mon Sep 17 00:00:00 2001 From: mfluharty Date: Mon, 8 Aug 2022 15:17:11 +0100 Subject: [PATCH 1/5] Add metrics widget telemetry events Add events to track views, clicks, and expansions of the metrics widget --- config/metrics/aggregates/code_review.yml | 12 ++++++++++ ...ge_request_widget_metrics_view_monthly.yml | 23 +++++++++++++++++++ ...et_metrics_full_report_clicked_monthly.yml | 23 +++++++++++++++++++ ..._request_widget_metrics_expand_monthly.yml | 23 +++++++++++++++++++ ..._widget_metrics_expand_success_monthly.yml | 23 +++++++++++++++++++ ..._widget_metrics_expand_warning_monthly.yml | 23 +++++++++++++++++++ ...t_widget_metrics_expand_failed_monthly.yml | 23 +++++++++++++++++++ ...rge_request_widget_metrics_view_weekly.yml | 23 +++++++++++++++++++ ...get_metrics_full_report_clicked_weekly.yml | 23 +++++++++++++++++++ ...e_request_widget_metrics_expand_weekly.yml | 23 +++++++++++++++++++ ...t_widget_metrics_expand_success_weekly.yml | 23 +++++++++++++++++++ ...t_widget_metrics_expand_warning_weekly.yml | 23 +++++++++++++++++++ ...st_widget_metrics_expand_failed_weekly.yml | 23 +++++++++++++++++++ ...erge_request_widget_metrics_count_view.yml | 22 ++++++++++++++++++ ...dget_metrics_count_full_report_clicked.yml | 23 +++++++++++++++++++ ...ge_request_widget_metrics_count_expand.yml | 22 ++++++++++++++++++ ...st_widget_metrics_count_expand_success.yml | 22 ++++++++++++++++++ ...st_widget_metrics_count_expand_warning.yml | 22 ++++++++++++++++++ ...est_widget_metrics_count_expand_failed.yml | 22 ++++++++++++++++++ 19 files changed, 421 insertions(+) create mode 100644 ee/config/metrics/counts_28d/20220808135945_i_code_review_merge_request_widget_metrics_view_monthly.yml create mode 100644 ee/config/metrics/counts_28d/20220808135952_i_code_review_merge_request_widget_metrics_full_report_clicked_monthly.yml create mode 100644 ee/config/metrics/counts_28d/20220808135959_i_code_review_merge_request_widget_metrics_expand_monthly.yml create mode 100644 ee/config/metrics/counts_28d/20220808140006_i_code_review_merge_request_widget_metrics_expand_success_monthly.yml create mode 100644 ee/config/metrics/counts_28d/20220808140013_i_code_review_merge_request_widget_metrics_expand_warning_monthly.yml create mode 100644 ee/config/metrics/counts_28d/20220808140021_i_code_review_merge_request_widget_metrics_expand_failed_monthly.yml create mode 100644 ee/config/metrics/counts_7d/20220808135857_i_code_review_merge_request_widget_metrics_view_weekly.yml create mode 100644 ee/config/metrics/counts_7d/20220808135908_i_code_review_merge_request_widget_metrics_full_report_clicked_weekly.yml create mode 100644 ee/config/metrics/counts_7d/20220808135916_i_code_review_merge_request_widget_metrics_expand_weekly.yml create mode 100644 ee/config/metrics/counts_7d/20220808135923_i_code_review_merge_request_widget_metrics_expand_success_weekly.yml create mode 100644 ee/config/metrics/counts_7d/20220808135930_i_code_review_merge_request_widget_metrics_expand_warning_weekly.yml create mode 100644 ee/config/metrics/counts_7d/20220808135937_i_code_review_merge_request_widget_metrics_expand_failed_weekly.yml create mode 100644 ee/config/metrics/counts_all/20220808134458_i_code_review_merge_request_widget_metrics_count_view.yml create mode 100644 ee/config/metrics/counts_all/20220808134506_i_code_review_merge_request_widget_metrics_count_full_report_clicked.yml create mode 100644 ee/config/metrics/counts_all/20220808134513_i_code_review_merge_request_widget_metrics_count_expand.yml create mode 100644 ee/config/metrics/counts_all/20220808134520_i_code_review_merge_request_widget_metrics_count_expand_success.yml create mode 100644 ee/config/metrics/counts_all/20220808134526_i_code_review_merge_request_widget_metrics_count_expand_warning.yml create mode 100644 ee/config/metrics/counts_all/20220808134533_i_code_review_merge_request_widget_metrics_count_expand_failed.yml diff --git a/config/metrics/aggregates/code_review.yml b/config/metrics/aggregates/code_review.yml index 2159f1fa0b4843..a9be0680bfb71d 100644 --- a/config/metrics/aggregates/code_review.yml +++ b/config/metrics/aggregates/code_review.yml @@ -104,6 +104,12 @@ - 'i_code_review_merge_request_widget_terraform_expand_success' - 'i_code_review_merge_request_widget_terraform_expand_warning' - 'i_code_review_merge_request_widget_terraform_expand_failed' + - 'i_code_review_merge_request_widget_metrics_view' + - 'i_code_review_merge_request_widget_metrics_full_report_clicked' + - 'i_code_review_merge_request_widget_metrics_expand' + - 'i_code_review_merge_request_widget_metrics_expand_success' + - 'i_code_review_merge_request_widget_metrics_expand_warning' + - 'i_code_review_merge_request_widget_metrics_expand_failed' - name: code_review_category_monthly_active_users operator: OR source: redis @@ -196,6 +202,12 @@ - 'i_code_review_merge_request_widget_terraform_expand_success' - 'i_code_review_merge_request_widget_terraform_expand_warning' - 'i_code_review_merge_request_widget_terraform_expand_failed' + - 'i_code_review_merge_request_widget_metrics_view' + - 'i_code_review_merge_request_widget_metrics_full_report_clicked' + - 'i_code_review_merge_request_widget_metrics_expand' + - 'i_code_review_merge_request_widget_metrics_expand_success' + - 'i_code_review_merge_request_widget_metrics_expand_warning' + - 'i_code_review_merge_request_widget_metrics_expand_failed' - name: code_review_extension_category_monthly_active_users operator: OR source: redis diff --git a/ee/config/metrics/counts_28d/20220808135945_i_code_review_merge_request_widget_metrics_view_monthly.yml b/ee/config/metrics/counts_28d/20220808135945_i_code_review_merge_request_widget_metrics_view_monthly.yml new file mode 100644 index 00000000000000..197584ac7274fc --- /dev/null +++ b/ee/config/metrics/counts_28d/20220808135945_i_code_review_merge_request_widget_metrics_view_monthly.yml @@ -0,0 +1,23 @@ +--- +key_path: redis_hll_counters.code_review.i_code_review_merge_request_widget_metrics_view_monthly +description: The count of unique users (monthly) who were able to see the Metrics widget extension +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: +time_frame: 28d +data_source: redis_hll +data_category: optional +instrumentation_class: RedisHLLMetric +options: + events: + - i_code_review_merge_request_widget_metrics_view +distribution: +- ee +tier: +- premium +- ultimate diff --git a/ee/config/metrics/counts_28d/20220808135952_i_code_review_merge_request_widget_metrics_full_report_clicked_monthly.yml b/ee/config/metrics/counts_28d/20220808135952_i_code_review_merge_request_widget_metrics_full_report_clicked_monthly.yml new file mode 100644 index 00000000000000..790986e2df5a31 --- /dev/null +++ b/ee/config/metrics/counts_28d/20220808135952_i_code_review_merge_request_widget_metrics_full_report_clicked_monthly.yml @@ -0,0 +1,23 @@ +--- +key_path: redis_hll_counters.code_review.i_code_review_merge_request_widget_metrics_clicked_monthly +description: The count of unique users (monthly) who clicked the Full Report button on the Metrics widget extension +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: +time_frame: 28d +data_source: redis_hll +data_category: optional +instrumentation_class: RedisHLLMetric +options: + events: + - i_code_review_merge_request_widget_metrics_clicked +distribution: +- ee +tier: +- premium +- ultimate diff --git a/ee/config/metrics/counts_28d/20220808135959_i_code_review_merge_request_widget_metrics_expand_monthly.yml b/ee/config/metrics/counts_28d/20220808135959_i_code_review_merge_request_widget_metrics_expand_monthly.yml new file mode 100644 index 00000000000000..d908e729e0d3b0 --- /dev/null +++ b/ee/config/metrics/counts_28d/20220808135959_i_code_review_merge_request_widget_metrics_expand_monthly.yml @@ -0,0 +1,23 @@ +--- +key_path: redis_hll_counters.code_review.i_code_review_merge_request_widget_metrics_expand_monthly +description: The count of unique users (monthly) who expanded the Metrics widget extension +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: +time_frame: 28d +data_source: redis_hll +data_category: optional +instrumentation_class: RedisHLLMetric +options: + events: + - i_code_review_merge_request_widget_metrics_expand +distribution: +- ee +tier: +- premium +- ultimate diff --git a/ee/config/metrics/counts_28d/20220808140006_i_code_review_merge_request_widget_metrics_expand_success_monthly.yml b/ee/config/metrics/counts_28d/20220808140006_i_code_review_merge_request_widget_metrics_expand_success_monthly.yml new file mode 100644 index 00000000000000..918c507e69d6a9 --- /dev/null +++ b/ee/config/metrics/counts_28d/20220808140006_i_code_review_merge_request_widget_metrics_expand_success_monthly.yml @@ -0,0 +1,23 @@ +--- +key_path: redis_hll_counters.code_review.i_code_review_merge_request_widget_metrics_expand_success_monthly +description: The count of unique users (monthly) who expanded the Metrics widget extension while it is in its Success state +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: +time_frame: 28d +data_source: redis_hll +data_category: optional +instrumentation_class: RedisHLLMetric +options: + events: + - i_code_review_merge_request_widget_metrics_expand_success +distribution: +- ee +tier: +- premium +- ultimate diff --git a/ee/config/metrics/counts_28d/20220808140013_i_code_review_merge_request_widget_metrics_expand_warning_monthly.yml b/ee/config/metrics/counts_28d/20220808140013_i_code_review_merge_request_widget_metrics_expand_warning_monthly.yml new file mode 100644 index 00000000000000..51484c302e94a3 --- /dev/null +++ b/ee/config/metrics/counts_28d/20220808140013_i_code_review_merge_request_widget_metrics_expand_warning_monthly.yml @@ -0,0 +1,23 @@ +--- +key_path: redis_hll_counters.code_review.i_code_review_merge_request_widget_metrics_expand_warning_monthly +description: The count of unique users (monthly) who expanded the Metrics widget extension while it is in its Warning state +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: +time_frame: 28d +data_source: redis_hll +data_category: optional +instrumentation_class: RedisHLLMetric +options: + events: + - i_code_review_merge_request_widget_metrics_expand_warning +distribution: +- ee +tier: +- premium +- ultimate diff --git a/ee/config/metrics/counts_28d/20220808140021_i_code_review_merge_request_widget_metrics_expand_failed_monthly.yml b/ee/config/metrics/counts_28d/20220808140021_i_code_review_merge_request_widget_metrics_expand_failed_monthly.yml new file mode 100644 index 00000000000000..b2cc4d56495f37 --- /dev/null +++ b/ee/config/metrics/counts_28d/20220808140021_i_code_review_merge_request_widget_metrics_expand_failed_monthly.yml @@ -0,0 +1,23 @@ +--- +key_path: redis_hll_counters.code_review.i_code_review_merge_request_widget_metrics_expand_failed_monthly +description: The count of unique users (monthly) who expanded the Metrics widget extension while it is in its Failed state +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: +time_frame: 28d +data_source: redis_hll +data_category: optional +instrumentation_class: RedisHLLMetric +options: + events: + - i_code_review_merge_request_widget_metrics_expand_failed +distribution: +- ee +tier: +- premium +- ultimate diff --git a/ee/config/metrics/counts_7d/20220808135857_i_code_review_merge_request_widget_metrics_view_weekly.yml b/ee/config/metrics/counts_7d/20220808135857_i_code_review_merge_request_widget_metrics_view_weekly.yml new file mode 100644 index 00000000000000..2221189e1b19bf --- /dev/null +++ b/ee/config/metrics/counts_7d/20220808135857_i_code_review_merge_request_widget_metrics_view_weekly.yml @@ -0,0 +1,23 @@ +--- +key_path: redis_hll_counters.code_review.i_code_review_merge_request_widget_metrics_view_weekly +description: The count of unique users (weekly) who were able to see the Metrics widget extension +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: +time_frame: 7d +data_source: redis_hll +data_category: optional +instrumentation_class: RedisHLLMetric +options: + events: + - i_code_review_merge_request_widget_metrics_view +distribution: +- ee +tier: +- premium +- ultimate diff --git a/ee/config/metrics/counts_7d/20220808135908_i_code_review_merge_request_widget_metrics_full_report_clicked_weekly.yml b/ee/config/metrics/counts_7d/20220808135908_i_code_review_merge_request_widget_metrics_full_report_clicked_weekly.yml new file mode 100644 index 00000000000000..515bc5f1a97d3c --- /dev/null +++ b/ee/config/metrics/counts_7d/20220808135908_i_code_review_merge_request_widget_metrics_full_report_clicked_weekly.yml @@ -0,0 +1,23 @@ +--- +key_path: redis_hll_counters.code_review.i_code_review_merge_request_widget_metrics_clicked_weekly +description: The count of unique users (weekly) who clicked the Full Report button on the Metrics widget extension +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: +time_frame: 7d +data_source: redis_hll +data_category: optional +instrumentation_class: RedisHLLMetric +options: + events: + - i_code_review_merge_request_widget_metrics_clicked +distribution: +- ee +tier: +- premium +- ultimate diff --git a/ee/config/metrics/counts_7d/20220808135916_i_code_review_merge_request_widget_metrics_expand_weekly.yml b/ee/config/metrics/counts_7d/20220808135916_i_code_review_merge_request_widget_metrics_expand_weekly.yml new file mode 100644 index 00000000000000..7b3190ab2631a6 --- /dev/null +++ b/ee/config/metrics/counts_7d/20220808135916_i_code_review_merge_request_widget_metrics_expand_weekly.yml @@ -0,0 +1,23 @@ +--- +key_path: redis_hll_counters.code_review.i_code_review_merge_request_widget_metrics_expand_weekly +description: The count of unique users (weekly) who expanded the Metrics widget extension +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: +time_frame: 7d +data_source: redis_hll +data_category: optional +instrumentation_class: RedisHLLMetric +options: + events: + - i_code_review_merge_request_widget_metrics_expand +distribution: +- ee +tier: +- premium +- ultimate diff --git a/ee/config/metrics/counts_7d/20220808135923_i_code_review_merge_request_widget_metrics_expand_success_weekly.yml b/ee/config/metrics/counts_7d/20220808135923_i_code_review_merge_request_widget_metrics_expand_success_weekly.yml new file mode 100644 index 00000000000000..7ca24cc1756efb --- /dev/null +++ b/ee/config/metrics/counts_7d/20220808135923_i_code_review_merge_request_widget_metrics_expand_success_weekly.yml @@ -0,0 +1,23 @@ +--- +key_path: redis_hll_counters.code_review.i_code_review_merge_request_widget_metrics_expand_success_weekly +description: The count of unique users (weekly) who expanded the Metrics widget extension while it is in its Success state +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: +time_frame: 7d +data_source: redis_hll +data_category: optional +instrumentation_class: RedisHLLMetric +options: + events: + - i_code_review_merge_request_widget_metrics_expand_success +distribution: +- ee +tier: +- premium +- ultimate diff --git a/ee/config/metrics/counts_7d/20220808135930_i_code_review_merge_request_widget_metrics_expand_warning_weekly.yml b/ee/config/metrics/counts_7d/20220808135930_i_code_review_merge_request_widget_metrics_expand_warning_weekly.yml new file mode 100644 index 00000000000000..fb20c68f637495 --- /dev/null +++ b/ee/config/metrics/counts_7d/20220808135930_i_code_review_merge_request_widget_metrics_expand_warning_weekly.yml @@ -0,0 +1,23 @@ +--- +key_path: redis_hll_counters.code_review.i_code_review_merge_request_widget_metrics_expand_warning_weekly +description: The count of unique users (weekly) who expanded the Metrics widget extension while it is in its Warning state +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: +time_frame: 7d +data_source: redis_hll +data_category: optional +instrumentation_class: RedisHLLMetric +options: + events: + - i_code_review_merge_request_widget_metrics_expand_warning +distribution: +- ee +tier: +- premium +- ultimate diff --git a/ee/config/metrics/counts_7d/20220808135937_i_code_review_merge_request_widget_metrics_expand_failed_weekly.yml b/ee/config/metrics/counts_7d/20220808135937_i_code_review_merge_request_widget_metrics_expand_failed_weekly.yml new file mode 100644 index 00000000000000..82cdfb1c77ee99 --- /dev/null +++ b/ee/config/metrics/counts_7d/20220808135937_i_code_review_merge_request_widget_metrics_expand_failed_weekly.yml @@ -0,0 +1,23 @@ +--- +key_path: redis_hll_counters.code_review.i_code_review_merge_request_widget_metrics_expand_failed_weekly +description: The count of unique users (weekly) who expanded the Metrics widget extension while it is in its Failed state +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: +time_frame: 7d +data_source: redis_hll +data_category: optional +instrumentation_class: RedisHLLMetric +options: + events: + - i_code_review_merge_request_widget_metrics_expand_failed +distribution: +- ee +tier: +- premium +- ultimate diff --git a/ee/config/metrics/counts_all/20220808134458_i_code_review_merge_request_widget_metrics_count_view.yml b/ee/config/metrics/counts_all/20220808134458_i_code_review_merge_request_widget_metrics_count_view.yml new file mode 100644 index 00000000000000..09e45a208bd642 --- /dev/null +++ b/ee/config/metrics/counts_all/20220808134458_i_code_review_merge_request_widget_metrics_count_view.yml @@ -0,0 +1,22 @@ +--- +key_path: counts.i_code_review_merge_request_widget_metrics_count_view +description: Total number of times the Metrics widget extension was viewed (rendered to the screen) +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: +time_frame: all +data_source: redis +data_category: optional +options: + events: + - i_code_review_merge_request_widget_metrics_count_view +distribution: +- ee +tier: +- premium +- ultimate diff --git a/ee/config/metrics/counts_all/20220808134506_i_code_review_merge_request_widget_metrics_count_full_report_clicked.yml b/ee/config/metrics/counts_all/20220808134506_i_code_review_merge_request_widget_metrics_count_full_report_clicked.yml new file mode 100644 index 00000000000000..b71b22d4cb6df7 --- /dev/null +++ b/ee/config/metrics/counts_all/20220808134506_i_code_review_merge_request_widget_metrics_count_full_report_clicked.yml @@ -0,0 +1,23 @@ +--- +key_path: counts.i_code_review_merge_request_widget_metrics_count_full_report_clicked +description: Total number of times the Metrics widget extension Full Report button was clicked +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: +time_frame: all +data_source: redis +data_category: optional +options: + events: + - i_code_review_merge_request_widget_metrics_count_full_report_clicked +distribution: +- ee +tier: +- premium +- ultimate + diff --git a/ee/config/metrics/counts_all/20220808134513_i_code_review_merge_request_widget_metrics_count_expand.yml b/ee/config/metrics/counts_all/20220808134513_i_code_review_merge_request_widget_metrics_count_expand.yml new file mode 100644 index 00000000000000..38293ade63a3ca --- /dev/null +++ b/ee/config/metrics/counts_all/20220808134513_i_code_review_merge_request_widget_metrics_count_expand.yml @@ -0,0 +1,22 @@ +--- +key_path: counts.i_code_review_merge_request_widget_metrics_count_expand +description: Total number of times the Metrics widget extension was expanded (in any state) +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: +time_frame: all +data_source: redis +data_category: optional +options: + events: + - i_code_review_merge_request_widget_metrics_count_expand +distribution: +- ee +tier: +- premium +- ultimate diff --git a/ee/config/metrics/counts_all/20220808134520_i_code_review_merge_request_widget_metrics_count_expand_success.yml b/ee/config/metrics/counts_all/20220808134520_i_code_review_merge_request_widget_metrics_count_expand_success.yml new file mode 100644 index 00000000000000..7c8de118edfdb9 --- /dev/null +++ b/ee/config/metrics/counts_all/20220808134520_i_code_review_merge_request_widget_metrics_count_expand_success.yml @@ -0,0 +1,22 @@ +--- +key_path: counts.i_code_review_merge_request_widget_metrics_count_expand_success +description: Total number of times the Metrics widget extension was expanded (while in its Success state) +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: +time_frame: all +data_source: redis +data_category: optional +options: + events: + - i_code_review_merge_request_widget_metrics_count_expand_success +distribution: +- ee +tier: +- premium +- ultimate diff --git a/ee/config/metrics/counts_all/20220808134526_i_code_review_merge_request_widget_metrics_count_expand_warning.yml b/ee/config/metrics/counts_all/20220808134526_i_code_review_merge_request_widget_metrics_count_expand_warning.yml new file mode 100644 index 00000000000000..1e33e8c526fcb3 --- /dev/null +++ b/ee/config/metrics/counts_all/20220808134526_i_code_review_merge_request_widget_metrics_count_expand_warning.yml @@ -0,0 +1,22 @@ +--- +key_path: counts.i_code_review_merge_request_widget_metrics_count_warning +description: Total number of times the Metrics widget extension was expanded (while in its Warning state) +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: +time_frame: all +data_source: redis +data_category: optional +options: + events: + - i_code_review_merge_request_widget_metrics_count_expand +distribution: +- ee +tier: +- premium +- ultimate diff --git a/ee/config/metrics/counts_all/20220808134533_i_code_review_merge_request_widget_metrics_count_expand_failed.yml b/ee/config/metrics/counts_all/20220808134533_i_code_review_merge_request_widget_metrics_count_expand_failed.yml new file mode 100644 index 00000000000000..8456d0af0fd635 --- /dev/null +++ b/ee/config/metrics/counts_all/20220808134533_i_code_review_merge_request_widget_metrics_count_expand_failed.yml @@ -0,0 +1,22 @@ +--- +key_path: counts.i_code_review_merge_request_widget_metrics_count_expand_failed +description: Total number of times the Metrics widget extension was expanded (while in its Failed state) +product_section: dev +product_stage: create +product_group: code_review +product_category: code_review +value_type: number +status: active +milestone: "15.3" +introduced_by_url: +time_frame: all +data_source: redis +data_category: optional +options: + events: + - i_code_review_merge_request_widget_metrics_count_expand_failed +distribution: +- ee +tier: +- premium +- ultimate -- GitLab From 2870910773f2cc469314a4d88dfa228033ac5d64 Mon Sep 17 00:00:00 2001 From: mfluharty Date: Mon, 8 Aug 2022 15:23:49 +0100 Subject: [PATCH 2/5] Add introduced by URL to ymls Now that the MR exists --- ..._i_code_review_merge_request_widget_metrics_view_monthly.yml | 2 +- ...merge_request_widget_metrics_full_report_clicked_monthly.yml | 2 +- ..._code_review_merge_request_widget_metrics_expand_monthly.yml | 2 +- ...view_merge_request_widget_metrics_expand_success_monthly.yml | 2 +- ...view_merge_request_widget_metrics_expand_warning_monthly.yml | 2 +- ...eview_merge_request_widget_metrics_expand_failed_monthly.yml | 2 +- ...7_i_code_review_merge_request_widget_metrics_view_weekly.yml | 2 +- ..._merge_request_widget_metrics_full_report_clicked_weekly.yml | 2 +- ...i_code_review_merge_request_widget_metrics_expand_weekly.yml | 2 +- ...eview_merge_request_widget_metrics_expand_success_weekly.yml | 2 +- ...eview_merge_request_widget_metrics_expand_warning_weekly.yml | 2 +- ...review_merge_request_widget_metrics_expand_failed_weekly.yml | 2 +- ...58_i_code_review_merge_request_widget_metrics_count_view.yml | 2 +- ...w_merge_request_widget_metrics_count_full_report_clicked.yml | 2 +- ..._i_code_review_merge_request_widget_metrics_count_expand.yml | 2 +- ...review_merge_request_widget_metrics_count_expand_success.yml | 2 +- ...review_merge_request_widget_metrics_count_expand_warning.yml | 2 +- ..._review_merge_request_widget_metrics_count_expand_failed.yml | 2 +- 18 files changed, 18 insertions(+), 18 deletions(-) diff --git a/ee/config/metrics/counts_28d/20220808135945_i_code_review_merge_request_widget_metrics_view_monthly.yml b/ee/config/metrics/counts_28d/20220808135945_i_code_review_merge_request_widget_metrics_view_monthly.yml index 197584ac7274fc..3d53c78f17518a 100644 --- a/ee/config/metrics/counts_28d/20220808135945_i_code_review_merge_request_widget_metrics_view_monthly.yml +++ b/ee/config/metrics/counts_28d/20220808135945_i_code_review_merge_request_widget_metrics_view_monthly.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/94807" time_frame: 28d data_source: redis_hll data_category: optional diff --git a/ee/config/metrics/counts_28d/20220808135952_i_code_review_merge_request_widget_metrics_full_report_clicked_monthly.yml b/ee/config/metrics/counts_28d/20220808135952_i_code_review_merge_request_widget_metrics_full_report_clicked_monthly.yml index 790986e2df5a31..f06848ba4f9d6f 100644 --- a/ee/config/metrics/counts_28d/20220808135952_i_code_review_merge_request_widget_metrics_full_report_clicked_monthly.yml +++ b/ee/config/metrics/counts_28d/20220808135952_i_code_review_merge_request_widget_metrics_full_report_clicked_monthly.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/94807" time_frame: 28d data_source: redis_hll data_category: optional diff --git a/ee/config/metrics/counts_28d/20220808135959_i_code_review_merge_request_widget_metrics_expand_monthly.yml b/ee/config/metrics/counts_28d/20220808135959_i_code_review_merge_request_widget_metrics_expand_monthly.yml index d908e729e0d3b0..17008c2653410b 100644 --- a/ee/config/metrics/counts_28d/20220808135959_i_code_review_merge_request_widget_metrics_expand_monthly.yml +++ b/ee/config/metrics/counts_28d/20220808135959_i_code_review_merge_request_widget_metrics_expand_monthly.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/94807" time_frame: 28d data_source: redis_hll data_category: optional diff --git a/ee/config/metrics/counts_28d/20220808140006_i_code_review_merge_request_widget_metrics_expand_success_monthly.yml b/ee/config/metrics/counts_28d/20220808140006_i_code_review_merge_request_widget_metrics_expand_success_monthly.yml index 918c507e69d6a9..c5b3ae0504f00c 100644 --- a/ee/config/metrics/counts_28d/20220808140006_i_code_review_merge_request_widget_metrics_expand_success_monthly.yml +++ b/ee/config/metrics/counts_28d/20220808140006_i_code_review_merge_request_widget_metrics_expand_success_monthly.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/94807" time_frame: 28d data_source: redis_hll data_category: optional diff --git a/ee/config/metrics/counts_28d/20220808140013_i_code_review_merge_request_widget_metrics_expand_warning_monthly.yml b/ee/config/metrics/counts_28d/20220808140013_i_code_review_merge_request_widget_metrics_expand_warning_monthly.yml index 51484c302e94a3..d7cd8e95263ad9 100644 --- a/ee/config/metrics/counts_28d/20220808140013_i_code_review_merge_request_widget_metrics_expand_warning_monthly.yml +++ b/ee/config/metrics/counts_28d/20220808140013_i_code_review_merge_request_widget_metrics_expand_warning_monthly.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/94807" time_frame: 28d data_source: redis_hll data_category: optional diff --git a/ee/config/metrics/counts_28d/20220808140021_i_code_review_merge_request_widget_metrics_expand_failed_monthly.yml b/ee/config/metrics/counts_28d/20220808140021_i_code_review_merge_request_widget_metrics_expand_failed_monthly.yml index b2cc4d56495f37..0f5011f759c57e 100644 --- a/ee/config/metrics/counts_28d/20220808140021_i_code_review_merge_request_widget_metrics_expand_failed_monthly.yml +++ b/ee/config/metrics/counts_28d/20220808140021_i_code_review_merge_request_widget_metrics_expand_failed_monthly.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/94807" time_frame: 28d data_source: redis_hll data_category: optional diff --git a/ee/config/metrics/counts_7d/20220808135857_i_code_review_merge_request_widget_metrics_view_weekly.yml b/ee/config/metrics/counts_7d/20220808135857_i_code_review_merge_request_widget_metrics_view_weekly.yml index 2221189e1b19bf..1d49a594dc52e9 100644 --- a/ee/config/metrics/counts_7d/20220808135857_i_code_review_merge_request_widget_metrics_view_weekly.yml +++ b/ee/config/metrics/counts_7d/20220808135857_i_code_review_merge_request_widget_metrics_view_weekly.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/94807" time_frame: 7d data_source: redis_hll data_category: optional diff --git a/ee/config/metrics/counts_7d/20220808135908_i_code_review_merge_request_widget_metrics_full_report_clicked_weekly.yml b/ee/config/metrics/counts_7d/20220808135908_i_code_review_merge_request_widget_metrics_full_report_clicked_weekly.yml index 515bc5f1a97d3c..bd6f3fb8b74024 100644 --- a/ee/config/metrics/counts_7d/20220808135908_i_code_review_merge_request_widget_metrics_full_report_clicked_weekly.yml +++ b/ee/config/metrics/counts_7d/20220808135908_i_code_review_merge_request_widget_metrics_full_report_clicked_weekly.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/94807" time_frame: 7d data_source: redis_hll data_category: optional diff --git a/ee/config/metrics/counts_7d/20220808135916_i_code_review_merge_request_widget_metrics_expand_weekly.yml b/ee/config/metrics/counts_7d/20220808135916_i_code_review_merge_request_widget_metrics_expand_weekly.yml index 7b3190ab2631a6..b570956c2b58a7 100644 --- a/ee/config/metrics/counts_7d/20220808135916_i_code_review_merge_request_widget_metrics_expand_weekly.yml +++ b/ee/config/metrics/counts_7d/20220808135916_i_code_review_merge_request_widget_metrics_expand_weekly.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/94807" time_frame: 7d data_source: redis_hll data_category: optional diff --git a/ee/config/metrics/counts_7d/20220808135923_i_code_review_merge_request_widget_metrics_expand_success_weekly.yml b/ee/config/metrics/counts_7d/20220808135923_i_code_review_merge_request_widget_metrics_expand_success_weekly.yml index 7ca24cc1756efb..b43c38093ba537 100644 --- a/ee/config/metrics/counts_7d/20220808135923_i_code_review_merge_request_widget_metrics_expand_success_weekly.yml +++ b/ee/config/metrics/counts_7d/20220808135923_i_code_review_merge_request_widget_metrics_expand_success_weekly.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/94807" time_frame: 7d data_source: redis_hll data_category: optional diff --git a/ee/config/metrics/counts_7d/20220808135930_i_code_review_merge_request_widget_metrics_expand_warning_weekly.yml b/ee/config/metrics/counts_7d/20220808135930_i_code_review_merge_request_widget_metrics_expand_warning_weekly.yml index fb20c68f637495..567be12a9f592e 100644 --- a/ee/config/metrics/counts_7d/20220808135930_i_code_review_merge_request_widget_metrics_expand_warning_weekly.yml +++ b/ee/config/metrics/counts_7d/20220808135930_i_code_review_merge_request_widget_metrics_expand_warning_weekly.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/94807" time_frame: 7d data_source: redis_hll data_category: optional diff --git a/ee/config/metrics/counts_7d/20220808135937_i_code_review_merge_request_widget_metrics_expand_failed_weekly.yml b/ee/config/metrics/counts_7d/20220808135937_i_code_review_merge_request_widget_metrics_expand_failed_weekly.yml index 82cdfb1c77ee99..56178d03bc7579 100644 --- a/ee/config/metrics/counts_7d/20220808135937_i_code_review_merge_request_widget_metrics_expand_failed_weekly.yml +++ b/ee/config/metrics/counts_7d/20220808135937_i_code_review_merge_request_widget_metrics_expand_failed_weekly.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/94807" time_frame: 7d data_source: redis_hll data_category: optional diff --git a/ee/config/metrics/counts_all/20220808134458_i_code_review_merge_request_widget_metrics_count_view.yml b/ee/config/metrics/counts_all/20220808134458_i_code_review_merge_request_widget_metrics_count_view.yml index 09e45a208bd642..c9ec92a7b7a622 100644 --- a/ee/config/metrics/counts_all/20220808134458_i_code_review_merge_request_widget_metrics_count_view.yml +++ b/ee/config/metrics/counts_all/20220808134458_i_code_review_merge_request_widget_metrics_count_view.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/94807" time_frame: all data_source: redis data_category: optional diff --git a/ee/config/metrics/counts_all/20220808134506_i_code_review_merge_request_widget_metrics_count_full_report_clicked.yml b/ee/config/metrics/counts_all/20220808134506_i_code_review_merge_request_widget_metrics_count_full_report_clicked.yml index b71b22d4cb6df7..3e7270bfff7456 100644 --- a/ee/config/metrics/counts_all/20220808134506_i_code_review_merge_request_widget_metrics_count_full_report_clicked.yml +++ b/ee/config/metrics/counts_all/20220808134506_i_code_review_merge_request_widget_metrics_count_full_report_clicked.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/94807" time_frame: all data_source: redis data_category: optional diff --git a/ee/config/metrics/counts_all/20220808134513_i_code_review_merge_request_widget_metrics_count_expand.yml b/ee/config/metrics/counts_all/20220808134513_i_code_review_merge_request_widget_metrics_count_expand.yml index 38293ade63a3ca..3fb89aab95371a 100644 --- a/ee/config/metrics/counts_all/20220808134513_i_code_review_merge_request_widget_metrics_count_expand.yml +++ b/ee/config/metrics/counts_all/20220808134513_i_code_review_merge_request_widget_metrics_count_expand.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/94807" time_frame: all data_source: redis data_category: optional diff --git a/ee/config/metrics/counts_all/20220808134520_i_code_review_merge_request_widget_metrics_count_expand_success.yml b/ee/config/metrics/counts_all/20220808134520_i_code_review_merge_request_widget_metrics_count_expand_success.yml index 7c8de118edfdb9..94657e0728799c 100644 --- a/ee/config/metrics/counts_all/20220808134520_i_code_review_merge_request_widget_metrics_count_expand_success.yml +++ b/ee/config/metrics/counts_all/20220808134520_i_code_review_merge_request_widget_metrics_count_expand_success.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/94807" time_frame: all data_source: redis data_category: optional diff --git a/ee/config/metrics/counts_all/20220808134526_i_code_review_merge_request_widget_metrics_count_expand_warning.yml b/ee/config/metrics/counts_all/20220808134526_i_code_review_merge_request_widget_metrics_count_expand_warning.yml index 1e33e8c526fcb3..e3db032959e18e 100644 --- a/ee/config/metrics/counts_all/20220808134526_i_code_review_merge_request_widget_metrics_count_expand_warning.yml +++ b/ee/config/metrics/counts_all/20220808134526_i_code_review_merge_request_widget_metrics_count_expand_warning.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/94807" time_frame: all data_source: redis data_category: optional diff --git a/ee/config/metrics/counts_all/20220808134533_i_code_review_merge_request_widget_metrics_count_expand_failed.yml b/ee/config/metrics/counts_all/20220808134533_i_code_review_merge_request_widget_metrics_count_expand_failed.yml index 8456d0af0fd635..f7228adf9a50cf 100644 --- a/ee/config/metrics/counts_all/20220808134533_i_code_review_merge_request_widget_metrics_count_expand_failed.yml +++ b/ee/config/metrics/counts_all/20220808134533_i_code_review_merge_request_widget_metrics_count_expand_failed.yml @@ -8,7 +8,7 @@ product_category: code_review value_type: number status: active milestone: "15.3" -introduced_by_url: +introduced_by_url: "https://gitlab.com/gitlab-org/gitlab/-/merge_requests/94807" time_frame: all data_source: redis data_category: optional -- GitLab From 491dbdb8808565cd97c0c0ddf1bd2176d214fc57 Mon Sep 17 00:00:00 2001 From: mfluharty Date: Mon, 8 Aug 2022 18:44:06 +0100 Subject: [PATCH 3/5] Add widget to base counter, events to known events --- .../known_events/code_review_events.yml | 25 +++++++++++++++++++ .../merge_request_widget_extension_counter.rb | 2 +- 2 files changed, 26 insertions(+), 1 deletion(-) diff --git a/lib/gitlab/usage_data_counters/known_events/code_review_events.yml b/lib/gitlab/usage_data_counters/known_events/code_review_events.yml index bdf6b48357f2a8..d4e4e3d2482ee1 100644 --- a/lib/gitlab/usage_data_counters/known_events/code_review_events.yml +++ b/lib/gitlab/usage_data_counters/known_events/code_review_events.yml @@ -400,3 +400,28 @@ redis_slot: code_review category: code_review aggregation: weekly +## Metrics +- name: i_code_review_merge_request_widget_metrics_view + redis_slot: code_review + category: code_review + aggregation: weekly +- name: i_code_review_merge_request_widget_metrics_full_report_clicked + redis_slot: code_review + category: code_review + aggregation: weekly +- name: i_code_review_merge_request_widget_metrics_expand + redis_slot: code_review + category: code_review + aggregation: weekly +- name: i_code_review_merge_request_widget_metrics_expand_success + redis_slot: code_review + category: code_review + aggregation: weekly +- name: i_code_review_merge_request_widget_metrics_expand_warning + redis_slot: code_review + category: code_review + aggregation: weekly +- name: i_code_review_merge_request_widget_metrics_expand_failed + redis_slot: code_review + category: code_review + aggregation: weekly diff --git a/lib/gitlab/usage_data_counters/merge_request_widget_extension_counter.rb b/lib/gitlab/usage_data_counters/merge_request_widget_extension_counter.rb index 0d7dd1ab085cec..5eb48864cfe852 100644 --- a/lib/gitlab/usage_data_counters/merge_request_widget_extension_counter.rb +++ b/lib/gitlab/usage_data_counters/merge_request_widget_extension_counter.rb @@ -5,7 +5,7 @@ module UsageDataCounters class MergeRequestWidgetExtensionCounter < BaseCounter KNOWN_EVENTS = %w[view full_report_clicked expand expand_success expand_warning expand_failed].freeze PREFIX = 'i_code_review_merge_request_widget' - WIDGETS = %w[accessibility code_quality terraform test_summary].freeze + WIDGETS = %w[accessibility code_quality terraform test_summary metrics].freeze class << self private -- GitLab From ca876e1c160c348a8ae7adf6a792fdef088d2df3 Mon Sep 17 00:00:00 2001 From: mfluharty Date: Mon, 8 Aug 2022 19:24:06 +0100 Subject: [PATCH 4/5] Fix expand warning name mismatch --- ...view_merge_request_widget_metrics_count_expand_warning.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ee/config/metrics/counts_all/20220808134526_i_code_review_merge_request_widget_metrics_count_expand_warning.yml b/ee/config/metrics/counts_all/20220808134526_i_code_review_merge_request_widget_metrics_count_expand_warning.yml index e3db032959e18e..50b7e7fbfb482b 100644 --- a/ee/config/metrics/counts_all/20220808134526_i_code_review_merge_request_widget_metrics_count_expand_warning.yml +++ b/ee/config/metrics/counts_all/20220808134526_i_code_review_merge_request_widget_metrics_count_expand_warning.yml @@ -1,5 +1,5 @@ --- -key_path: counts.i_code_review_merge_request_widget_metrics_count_warning +key_path: counts.i_code_review_merge_request_widget_metrics_count_expand_warning description: Total number of times the Metrics widget extension was expanded (while in its Warning state) product_section: dev product_stage: create @@ -14,7 +14,7 @@ data_source: redis data_category: optional options: events: - - i_code_review_merge_request_widget_metrics_count_expand + - i_code_review_merge_request_widget_metrics_count_expand_warning distribution: - ee tier: -- GitLab From 96162b65765e39848b64076e72acf8cc63bffd57 Mon Sep 17 00:00:00 2001 From: mfluharty Date: Mon, 8 Aug 2022 22:08:12 +0100 Subject: [PATCH 5/5] Fix full report click event names --- ...rge_request_widget_metrics_full_report_clicked_monthly.yml | 4 ++-- ...erge_request_widget_metrics_full_report_clicked_weekly.yml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/ee/config/metrics/counts_28d/20220808135952_i_code_review_merge_request_widget_metrics_full_report_clicked_monthly.yml b/ee/config/metrics/counts_28d/20220808135952_i_code_review_merge_request_widget_metrics_full_report_clicked_monthly.yml index f06848ba4f9d6f..3e3b3520106726 100644 --- a/ee/config/metrics/counts_28d/20220808135952_i_code_review_merge_request_widget_metrics_full_report_clicked_monthly.yml +++ b/ee/config/metrics/counts_28d/20220808135952_i_code_review_merge_request_widget_metrics_full_report_clicked_monthly.yml @@ -1,5 +1,5 @@ --- -key_path: redis_hll_counters.code_review.i_code_review_merge_request_widget_metrics_clicked_monthly +key_path: redis_hll_counters.code_review.i_code_review_merge_request_widget_metrics_full_report_clicked_monthly description: The count of unique users (monthly) who clicked the Full Report button on the Metrics widget extension product_section: dev product_stage: create @@ -15,7 +15,7 @@ data_category: optional instrumentation_class: RedisHLLMetric options: events: - - i_code_review_merge_request_widget_metrics_clicked + - i_code_review_merge_request_widget_metrics_full_report_clicked distribution: - ee tier: diff --git a/ee/config/metrics/counts_7d/20220808135908_i_code_review_merge_request_widget_metrics_full_report_clicked_weekly.yml b/ee/config/metrics/counts_7d/20220808135908_i_code_review_merge_request_widget_metrics_full_report_clicked_weekly.yml index bd6f3fb8b74024..fd52e69f5c5e37 100644 --- a/ee/config/metrics/counts_7d/20220808135908_i_code_review_merge_request_widget_metrics_full_report_clicked_weekly.yml +++ b/ee/config/metrics/counts_7d/20220808135908_i_code_review_merge_request_widget_metrics_full_report_clicked_weekly.yml @@ -1,5 +1,5 @@ --- -key_path: redis_hll_counters.code_review.i_code_review_merge_request_widget_metrics_clicked_weekly +key_path: redis_hll_counters.code_review.i_code_review_merge_request_widget_metrics_full_report_clicked_weekly description: The count of unique users (weekly) who clicked the Full Report button on the Metrics widget extension product_section: dev product_stage: create @@ -15,7 +15,7 @@ data_category: optional instrumentation_class: RedisHLLMetric options: events: - - i_code_review_merge_request_widget_metrics_clicked + - i_code_review_merge_request_widget_metrics_full_report_clicked distribution: - ee tier: -- GitLab