Merge pull request #1226 from uli-f/doublebondstereochemistry-create-alignment-fix
Merge branch 'main' into doublebondstereochemistry-create-alignment-fix
Add JDK-25 to CI
Show how to use the SmirksTransform.
Update the documentation to make it clearer how to use the API
Merge pull request #3 from cdk/doublebondstereochemistry-create-alignment-fix
Some additional null checks and fix the test assertion now the order is corrected.
introduce processCarriers hook in AbstractStereo to allow subclasses to process carriers; move carrier swap logic from DoubleBondStereochemistry::create to overridden DoubleBondStereochemistry::processCarriers method
fix carrier consistency in DoubleBondStereochemistry::create; add tests for strict carrier swap behavior in DoubleBondStereochemistry::create; change DoubleBondStereochemistry::testMap_Map_Map to reflect changes in DoubleBondStereochemistry::create
Avoid regex DoS.
Move the InChI Readers to cdk-inchi module.
Merge pull request #1234 from JonasSchaub/descriptor-parallelisation
a bit of refactoring and linting in the ALogPDescriptor class
a bit of refactoring in the ALogPDescriptor class
a bit of code formatting and refactoring
makes SmallRingDescriptor threadsafe
makes ALogPDescriptor threadsafe
makes Wiener numbers descriptor threadsafe
Fix the terse SGroup test
Fix tests and cleanup CXSMILES output.
Allow terse SRU sgroups
Some extra test cases
Make sure when xbonds are specified they get added to the Sgroup
Fix an issue in SvgDrawVisitor which caused brackets not be drawn.
Fix a failing test, the force field configurator needs ring flags clearing.
Handle Link Nodes in CXSMILES
Simplify the SybylAtomTypeMatcherTest.
Move around some XML config files.
Remove XYZ reader from this test, we don't need to the full mol to isolate what is actually being asserted on.
Move the atom type aware saturation check to cdk-legacy, this is replaced by Kekulisation which is (a) the
Move the CDK AtomType Repos File test and fix the PDB one and the PubChem ASN reader.
Replace import of CMLReader with direct molecule creation. Bug 1014344 (https://sourceforge.net/p/cdk/bugs/231/) is testing CML round tripping so I've moved it there and switch it so CML depends on SMILES (test) rather than the other way around.
Avoid depending on the HinReader and create the molecule directly.
Merge pull request #1225 from JonasSchaub/sugar-detection-utility
adds the Sugar Detection Utility and fixes a few things in the Sugar Removal Utility
Do not sett rootAttachmentPoints if null.
Do not explicitly store the attachment atoms, instead we infer this from the explicit attachment points (wiggly crossed line).
When reading/writing RGroup queries we add on/trim explicit attachment points (wavy line across bond).
Add a utility method to AtomPlace which allows us to place a single atom which is sprouted off the structure.
Add a new utility to get the median bond length and fallback to a provided default if needed.
Move the AtomPlace to cdk-standard, we are going to need this. This does split the "layout" package but in future (CDK v3) they will all be collapsed together.
In CXSMILES we use an SGroup to store the attachment order. Rather than store a map in the 'RGroup' we can reuse this SGroup and get nicer rendering.
Improved stereochemistry invalidation when modifying molecules (Fixes #1221).
Grr DebugBong issues.
A constructor argument is also useful for refactoring code.
More replacements of IBond.Stereo with IBond.Display
A new addBond which accepts a display property as well so we can cleanup more usages of IBond.Stereo
Don't store crossed bonds as wavy.
Replace calls to IBond.getStereo() with IBond.getDisplay().
Replace usages of setStereo with setDisplay. We also add some alias names Up/Down for convenience.
Step 1 in cleaning up IBond.Stereo vs IBond.Display conflation. We deprecate IBond.Stereo get/set and implement them in terms of Display.
Allow hollowwedge display style.
Fix a corner case with titles for reactions not being set if no CXSMILES layers were present.
Merge pull request #1218 from JonasSchaub/LargestPiSystemDescriptor-visited-fix
makes LargestPiSystemDescriptor use an internal visited array instead of IChemObject flag VISITED for safe parallelisation
Improver generated SVG when we have an alpha colour or NULL background.
Some additional documentation.
Correct reaction background box dimensions. I had used the wrong Dimensions here, we want to paint the box to be the size of the whole canvas.
Remove stray print to stderr.
Now the DepictionGenerator is the normal way of rendering, align the default values of these parameters.
Provide a function to bulk apply parameters.
Allow parameters to be explicitly set null, currently if you set it to null it reverts to default. Now it starts as default but can be set to null (or back to default if desired).
Merge pull request #1214 from uli-f/depiction-empty-annotation
replace System.getProperty("line.separator") with System.lineSeparator in DepictionTest; simplify stream operations in DepictionTest; remove unused imports and redundant whitespace in StandardGenerator; minor code cleanup in StandardGenerator
add test for handling empty atom property annotation labels in DepictionTest; update StandardGenerator to skip empty annotation labels
InchIToStructure and AuxInfoToStructure now both in same class;
Add missing copyrights, javadocs;
Remove doNotAddH option; implicit hydrogens set to null if information is missing;
Add InChI AuxInfo to structure functionality;
Allow annotation of bond numbers, this was useful for debugging the atropisomer logic.
For these tests we really want to assert these are not tetrahedral.
Additional check needed
Some tweaks to 2D atropisomer perception to ensure the Wikipedia tautomer of Sotorasib is accepted.
Test cases for atropisomers
Parse wedges up/down from CXSMILES.
Merge pull request #1211 from JonasSchaub/ConjugatedPiSystemsDetector-fix
fixes issue with path-dependent conjugated system detection if allenes are involved
Merge pull request #1207 from cdk/nwocdk/moreTesting6
Fixes two more warnings
Silence a warning
Moved two more classes: BsptTest and PointTest
Moved ProblemMarkerTest from test-standard to standard
downgrade mockito dependencies to version 4.11.0 in pom.xml to stay compatible with Java 8
update maven-compiler-plugin configuration to use <release> instead of <source> and <target>; bump junit, assertj, and mockito dependencies versions
Merge pull request #1204 from cdk/deps/updates-20250725
Various Maven plugin updates
Updated dependencies: CMLXOM 4.13, Log4j 2.25.1, and JUnit 5.13.3
update maven-compiler-plugin configuration to use <release> instead of <source> and <target>
Merge pull request #1203 from uli-f/depict-gen-atom-property-cleanup-fix
update DepictionGenerator to remove atom value annotations; add test for atom property annotation label cleanup
This doesn't need to be central-snapshots, it was the <repositories> which was wrong and not <distributionManagement>.
Update to BEAM 1.3.10. This adds support for lone-pairs on extended tetrahedral atoms (e.g. CN=[C@AL1]=NC).
Stabilise the comparator ordering of transformation op-codes. DeleteAtom MUST appear after DeleteBond of the bond it's involved in. This might defeat some optimisations (where we try to move ops and replace them with larger concepts - i.e. ReplaceAtom) but testing shows it to be acceptable.
Fix some issues highlighted by SonarCloud
Fix the build, the snapshots repo needs a distinct name.
Build plugin updates: PMD, compiler, and some harmonization
New deploy plugin and config for Sonatype
README updated for the latest stable release
Allow the ExtendedFingerprinter to setHashExplicitHydrogens
Remove some redundant exceptions.