itracker-commits Mailing List for itracker (Page 8)

SourceForge Headquarters 1320 Columbia Street Suite 310 San Diego, CA 92101 +1 (858) 422-6466

Revision: 2153
          http://itracker.svn.sourceforge.net/itracker/?rev=2153&view=rev
Author:   ranks
Date:     2009-01-26 11:33:37 +0000 (Mon, 26 Jan 2009)

Log Message:
-----------
fixed logging

Modified Paths:
--------------
    itracker/trunk/src/main/java/org/itracker/services/authentication/AbstractPluggableAuthenticator.java
    itracker/trunk/src/main/java/org/itracker/services/authentication/DefaultAuthenticator.java
    itracker/trunk/src/main/java/org/itracker/services/authentication/adsson/WindowsSSONAuthenticator.java
    itracker/trunk/src/main/java/org/itracker/services/authentication/adsson/WindowsSSONAuthenticatorADInfo.java

Modified: itracker/trunk/src/main/java/org/itracker/services/authentication/AbstractPluggableAuthenticator.java
===================================================================

--- itracker/trunk/src/main/java/org/itracker/services/authentication/AbstractPluggableAuthenticator.java	2009-01-26 08:39:40 UTC (rev 2152)
+++ itracker/trunk/src/main/java/org/itracker/services/authentication/AbstractPluggableAuthenticator.java	2009-01-26 11:33:37 UTC (rev 2153)
@@ -20,7 +20,6 @@
 
 import java.util.Map;
 
-import org.apache.log4j.Logger;
 import org.itracker.services.ConfigurationService;
 import org.itracker.services.UserService;
 import org.itracker.services.exceptions.AuthenticatorException;
@@ -36,13 +35,10 @@
 public abstract class AbstractPluggableAuthenticator 
         implements PluggableAuthenticator, AuthenticationConstants {
     
-    protected final Logger logger;
+//    private final Logger logger;
     private UserService userService = null;
     private ConfigurationService configurationService = null;
 
-    public AbstractPluggableAuthenticator() {
-        this.logger = Logger.getLogger(getClass());
-    }
 
     /**
       * This method is called after creating a new instance of the Authenticator.  It supplies

Modified: itracker/trunk/src/main/java/org/itracker/services/authentication/DefaultAuthenticator.java
===================================================================
--- itracker/trunk/src/main/java/org/itracker/services/authentication/DefaultAuthenticator.java	2009-01-26 08:39:40 UTC (rev 2152)
+++ itracker/trunk/src/main/java/org/itracker/services/authentication/DefaultAuthenticator.java	2009-01-26 11:33:37 UTC (rev 2153)
@@ -23,6 +23,7 @@
 import java.util.List;
 import java.util.Map;
 
+import org.apache.log4j.Logger;
 import org.itracker.model.Permission;
 import org.itracker.model.User;
 import org.itracker.services.exceptions.AuthenticatorException;
@@ -40,6 +41,8 @@
  */
 public class DefaultAuthenticator extends AbstractPluggableAuthenticator {
 
+	private static final Logger logger = Logger.getLogger(DefaultAuthenticator.class);
+	
     /**
      * Checks the login of a user against the user profile provided in ITracker.  This is
      * the default authentication scheme provided by ITracker.
@@ -111,7 +114,7 @@
                         throw new AuthenticatorException(AuthenticatorException.INVALID_PASSWORD);
                     }
                 } else {
-                	Log.info("checkLogin: invalid authenticator type: " + authType);
+                	logger.info("checkLogin: invalid authenticator type: " + authType);
                     throw new AuthenticatorException(AuthenticatorException.INVALID_AUTHENTICATION_TYPE);
                 }
             } catch (ClassCastException cce) {
@@ -119,6 +122,11 @@
                 throw new AuthenticatorException(AuthenticatorException.SYSTEM_ERROR);
             } catch (PasswordException pe) {
                 throw new AuthenticatorException(AuthenticatorException.SYSTEM_ERROR);
+            } catch (AuthenticatorException ae) {
+            	if (logger.isDebugEnabled()) {
+            		logger.debug("checkLogin: failed to authenticate " + login, ae);
+            	}
+            	throw ae;
             }
 
             return user;

Modified: itracker/trunk/src/main/java/org/itracker/services/authentication/adsson/WindowsSSONAuthenticator.java
===================================================================
--- itracker/trunk/src/main/java/org/itracker/services/authentication/adsson/WindowsSSONAuthenticator.java	2009-01-26 08:39:40 UTC (rev 2152)
+++ itracker/trunk/src/main/java/org/itracker/services/authentication/adsson/WindowsSSONAuthenticator.java	2009-01-26 11:33:37 UTC (rev 2153)
@@ -8,6 +8,7 @@
 
 import javax.servlet.http.HttpServletRequest;
 
+import org.apache.log4j.Logger;
 import org.itracker.model.User;
 import org.itracker.model.UserPreferences;
 import org.itracker.services.UserService;
@@ -27,6 +28,8 @@
  */
 public abstract class WindowsSSONAuthenticator extends DefaultAuthenticator {
 
+	private static final Logger logger = Logger.getLogger(WindowsSSONAuthenticator.class);
+	
     private static String TEMPLATE_USER = "TemplateUser";
 
     /**

Modified: itracker/trunk/src/main/java/org/itracker/services/authentication/adsson/WindowsSSONAuthenticatorADInfo.java
===================================================================
--- itracker/trunk/src/main/java/org/itracker/services/authentication/adsson/WindowsSSONAuthenticatorADInfo.java	2009-01-26 08:39:40 UTC (rev 2152)
+++ itracker/trunk/src/main/java/org/itracker/services/authentication/adsson/WindowsSSONAuthenticatorADInfo.java	2009-01-26 11:33:37 UTC (rev 2153)
@@ -7,6 +7,7 @@
 
 import javax.security.auth.login.LoginException;
 
+import org.apache.log4j.Logger;
 import org.itracker.model.User;
 import org.itracker.services.exceptions.AuthenticatorException;
 
@@ -17,7 +18,7 @@
  * @author ricardo
  */
 public class WindowsSSONAuthenticatorADInfo extends WindowsSSONAuthenticator {
-    
+    private static final Logger logger = Logger.getLogger(WindowsSSONAuthenticatorADInfo.class);
     /**
      *
      * @see com.emation.itracker.authentication.WindowsSSONAuthenticator#getExternalUserInfo(java.lang.String)
@@ -31,9 +32,8 @@
             User userModel = (User)ad.getUserInfo( login );
             return userModel;
         } catch (LoginException e) {
-            logger.error("ErrodeautenticaonoA.D.: " + e.getMessage() + AuthenticatorException.SYSTEM_ERROR );
-            logger.error( "Confirme as suas credenciais de autentica��o no A.D. " );
-            throw new AuthenticatorException( "Erro de autentica��o no A.D. : " + e.getMessage(), AuthenticatorException.SYSTEM_ERROR);
+            logger.error("getExternalUserInfo: " + e.getMessage() + AuthenticatorException.SYSTEM_ERROR );
+            throw new AuthenticatorException( "Error accessing Active Directory: " + e.getMessage(), AuthenticatorException.SYSTEM_ERROR, e);
         } catch (IOException e) {
             logger.error( e.getMessage() );
             throw new AuthenticatorException( e.getMessage(), AuthenticatorException.SYSTEM_ERROR);


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.




2005	Jan	Feb	Mar	Apr	May	Jun	Jul	Aug	Sep	Oct (217)	Nov (180)	Dec (71)
2006	Jan (58)	Feb (370)	Mar (105)	Apr (165)	May (93)	Jun (37)	Jul	Aug (21)	Sep (131)	Oct (40)	Nov (113)	Dec (401)
2007	Jan (180)	Feb (4)	Mar	Apr	May	Jun	Jul	Aug	Sep	Oct	Nov	Dec (3)
2008	Jan (163)	Feb (78)	Mar	Apr (4)	May (28)	Jun (2)	Jul	Aug	Sep (96)	Oct (189)	Nov (413)	Dec (121)
2009	Jan (34)	Feb (18)	Mar (24)	Apr (16)	May (3)	Jun	Jul (1)	Aug	Sep	Oct	Nov	Dec (13)
2010	Jan	Feb	Mar	Apr	May	Jun (1)	Jul	Aug	Sep	Oct	Nov	Dec
2011	Jan	Feb	Mar	Apr	May	Jun	Jul	Aug (1)	Sep (3)	Oct (16)	Nov	Dec
2012	Jan	Feb	Mar	Apr (5)	May (35)	Jun	Jul (17)	Aug (7)	Sep	Oct (9)	Nov	Dec

itracker-commits Mailing List for itracker (Page 8)

open source issue tracking system

itracker-commits — itracker CVS commits are distributed through this mailinglist. Join to develop.