[go: up one dir, main page]
Skip to content

fix: cancelling cr/dr notes should update the linked Invoice status by ruthra-kumar [frappe] PR#39783

Bot Dokosrequested to merge
ft-pr-39783 into develop

From: https://github.com/frappe/erpnext/pull/39783
Date: 2024-02-07 19:59:33+05:30

  • refactor(test): Forex Credit Note cancellation against Invoice
  • refactor(test): assert Invoice status as well
  • test: Invoice status on Cr/Dr note cancellation
  • refactor: cancel Cr/Dr JE's on Sales/Purchase return cancel


Diagnostics

pre-commit failed for source commit: 31a8c3bdc45f0e32a51e43260db8484e5f17aa75
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

erpnext/accounts/doctype/payment_reconciliation/test_payment_reconciliation.py:172:39: B008 Do not perform function calls in argument defaults.  The call is performed only once at function definition time. All calls to your function will reuse the result of that definition-time function call.  If this is intended, assign the function call to a module-level variable and use that variable as a default value.
erpnext/accounts/doctype/payment_reconciliation/test_payment_reconciliation.py:201:39: B008 Do not perform function calls in argument defaults.  The call is performed only once at function definition time. All calls to your function will reuse the result of that definition-time function call.  If this is intended, assign the function call to a module-level variable and use that variable as a default value.


pre-commit failed for source commit: 33efe0d12d85484e551dc9ebebf8840d427ecc67
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

erpnext/accounts/doctype/payment_reconciliation/test_payment_reconciliation.py:172:39: B008 Do not perform function calls in argument defaults.  The call is performed only once at function definition time. All calls to your function will reuse the result of that definition-time function call.  If this is intended, assign the function call to a module-level variable and use that variable as a default value.
erpnext/accounts/doctype/payment_reconciliation/test_payment_reconciliation.py:201:39: B008 Do not perform function calls in argument defaults.  The call is performed only once at function definition time. All calls to your function will reuse the result of that definition-time function call.  If this is intended, assign the function call to a module-level variable and use that variable as a default value.


pre-commit failed for source commit: 2f676ced5c712823c5737f40230ec8b1994cd2dd
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

erpnext/controllers/tests/test_accounts_controller.py:8:1: F401 'frappe.utils.flt' imported but unused


Checkout instructions 
# Checkout locally
git fetch upstream
git switch ft-pr-39783

# Make changes then rebase
git rebase -i upstream/develop --reapply-cherry-picks

# Fix or ignore conflicts
git checkout --theirs .
git rebase --continue

# Force-push changes
git push --force-with-lease

Merge request reports