fix: ensure minio works properly over HTTP
-
Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA. As a benefit of being a GitLab Community Contributor, you receive complimentary access to GitLab Duo.
What does this MR do?
Fix a problem where Minio over HTTP was not working.
More specifically, when using HTTP, s3cmd need the setting use_https set to False. Otherwise, connection attempts fails.
Additionally, if the global.hosts.minio.https is set to false but global.hosts.https to true, attempts to connect to Minio were done using HTTPS, for example when creating a backup.
Required
For anything in this list which will not be completed, please provide a reason in the MR discussion.
-
Merge Request Title and Description are up to date, accurate, and descriptive. -
MR targeting the appropriate branch. -
MR has a green pipeline. -
Documentation created/updated. -
Tests added/updated, and test plan for scenarios not covered by automated tests. -
Equivalent MR/issue for omnibus-gitlab opened.
Reviewers checklist
-
MR has a green pipeline on https://gitlab.com/gitlab-org/charts/gitlab. -
Consider downstream impact to the Operator, as per evaluating impact from changes to GitLab Chart.
Edited by Hossein Pursultani