[go: up one dir, main page]

Skip to content

Add path in session cookie when namespace is provided in path

What does this MR do?

Related to: GitLab Pages without DNS wildcard - MVC (gitlab#17584 - closed)
More context: gitlab#211677 (comment 1646965167)

Add path in session cookie when namespace is provided in path. This will prevent cookie sharing when the namespace is provided in the path.
We are setting the path variable at the cookie level so that the browser only sends the specific cookie assigned to that namespace.

Cookie path documentation: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie#pathpath-value

This will work in conjunction with: Add namespace_in_path parameter in GitLab.rb fo... (omnibus-gitlab!7250 - merged)

Changelog: added

TODO

Edited by Naman Jagdish Gala

Merge request reports

Loading