[go: up one dir, main page]
Skip to content

Prioritize reviews in the MR Overview tab

Thomas Randolphrequested to merge
tor/feature/overview-primary-add-to-review into master

What does this MR do and why?

For #479269 (closed)

Please review the above issue for all the nuances of the changes.

Short summary:

This MR makes "Reviews" more visible on the MR Overview tab.

  • If you've already started a review, the primary action when writing a comment is to add that comment to the review.
  • If you haven't started a review, the comment form suggests starting one (as the secondary action).

In addition, comments added as part of a review are always threads (essentially: resolvable), which differs from non-review comments, and matches discussion replies and comments in the Changes tab.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

- Before After
No review started image image
Review started image image
Internal, no review started image image
Internal, review started image image

How to set up and validate locally

  1. Create an MR
  2. 👀 at the comment field on the main ("Overview") tab of the MR.
Old description before issue rework

This does what the title says, but there are some implications of that:

  • There's no ability to "create a thread"
  • ...which means there's no split/dropdown comment button
  • The "Add comment now" button always shows, since we don't specifically check for the existence of drafts any more

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
No Content before_none_public after_none_public
w/ Note before_some_public after_some_public
No Content (internal) before_none_private after_none_private
w/ Note (internal) before_some_private after_some_private

Additionally, because there was a strange test failure with the "r" (reply) keyboard shortcut, here is the "r" keyboard shortcut working identically to how it works on master.

Screencast_from_2024-10-23_14-37-08

How to set up and validate locally

  1. Create an MR
  2. 👀 at the comment field on the main ("Overview") tab of the MR.
Edited by Thomas Randolph

Merge request reports