[go: up one dir, main page]

Skip to content

Allow all reviewers to be visible in sidebar "Reviewers" edit dropdown

What does this MR do and why?

For #501135 (closed)
Makes every selected reviewer a visible reviewer when rendering the high-level "edit" reviewer dropdown from the merge request sidebar.

This does not affect the approval rule drawer reviewer dropdowns.

References

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
Screenshot_from_2024-10-29_10-16-50 Screenshot_from_2024-10-29_10-16-37

How to set up and validate locally

  1. Enable the reviewer_assign_drawer feature flag ==> rails c; Feature.enable( :reviewer_assign_drawer )
  2. Assign a user as a reviewer of an MR
  3. Open the reviewer edit dropdown (on the primary sidebar, not in the drawer)
    • Previously: No reviewers show
    • Now: All selected reviewers show
Edited by Thomas Randolph

Merge request reports

Loading